public inbox for [email protected]
help / color / mirror / Atom feedPATCH: To fix column editor issue (pgAdmin4)
2+ messages / 2 participants
[nested] [flat]
* PATCH: To fix column editor issue (pgAdmin4)
@ 2016-09-19 10:10 Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2016-09-19 10:10 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA patch to fix the issue in column editor where subnode control was not
expanding properly.
RM#1703/04
*Issue:*
There was issue in SecurityGroup function(used to show/hide security tab)
which was not able to find node_info property when called from subnode
control, due t which it was breaking while expanding subnode control.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] RM_1703_1704.patch (1.1K, 3-RM_1703_1704.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/js/schema.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/js/schema.js
index 76919aa..121af60 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/js/schema.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/schema/js/schema.js
@@ -112,8 +112,11 @@ function($, _, S, pgAdmin, pgBrowser, Backform, alertify) {
id: 'security', label: '{{ _("Security") }}', type: 'group',
// Show/Hide security group for nodes under the catalog
visible: function(args) {
- if (args && 'node_info' in args && 'catalog' in args.node_info) {
- return false;
+ if (args && 'node_info' in args) {
+ // If node_info is not present in current object then it might in its
+ // parent in case if we used sub node control
+ var node_info = args.node_info || args.handler.node_info;
+ return 'catalog' in node_info ? false : true;
}
return true;
}
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: PATCH: To fix column editor issue (pgAdmin4)
@ 2016-09-19 14:37 Dave Page <[email protected]>
parent: Murtuza Zabuawala <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-09-19 14:37 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks, applied.
On Mon, Sep 19, 2016 at 11:10 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi,
>
> PFA patch to fix the issue in column editor where subnode control was not
> expanding properly.
> RM#1703/04
>
> Issue:
> There was issue in SecurityGroup function(used to show/hide security tab)
> which was not able to find node_info property when called from subnode
> control, due t which it was breaking while expanding subnode control.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-09-19 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-09-19 10:10 PATCH: To fix column editor issue (pgAdmin4) Murtuza Zabuawala <[email protected]>
2016-09-19 14:37 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox