Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewVke-00070D-Uf for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 16:29:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewVkd-0002h2-QP for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 16:29:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewVhL-00089T-Mj for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 16:25:47 +0000 Received: from mail-ot0-x22f.google.com ([2607:f8b0:4003:c0f::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewVhH-0001LO-SD for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 16:25:46 +0000 Received: by mail-ot0-x22f.google.com with SMTP id m22-v6so7451157otf.10 for ; Thu, 15 Mar 2018 09:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MqCFKuFqCozJJcNMlXY+dJ+yV63Erw8shjbRoldxDxE=; b=vCvV3Q20YDDZjELZ4WPT0qrrWKBZOfTb1xNacTFYBnh2nb7bt+gkBymP007k3tzYOp C6OuRrgeW9uyZn5Zt5tCKsr9QjWRcA1qznWepMYS1IwBiuGQQj/WFWrzKhVWsNgUVtmU zVvMVD3HkMvZfqvl6bIlTVlvkwi9lqwSozbdYqGO3NICZNRKE2ivSzHFmcvH24xssuMl M703jQuiBdtZFZ5/x6EPoN4jjWeb0rWG2t9zL2N5YSFSSXudIFsabtKsW7OKse8RqEIU BCC7GWushk4Mf3FrxOFiUqgfnEVSza7im9XZ5EUIRu9y5e/Yh98nW1jv6chjI2q5Bnsr dsVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MqCFKuFqCozJJcNMlXY+dJ+yV63Erw8shjbRoldxDxE=; b=Dk0SbnYqqoBg1ntDIbanw3C2OaL06UuDjR8KtsBFy5+p5dAMUADL866yx+Cm7Fnjnt 0sOSxCYjzaRATbZPFmR862I1qwDqk81NksqSVrIrHoGPtVacGIGK7+AlBtlBKbvDnR1q s3UerR70YbbKX9eLI2LV88iq8x3l45Q2zXC23hAGYQII1jlrE8+jlY6CAcdkrZU5Qrqf 4JVMWFn6I4FW74l71uwP5BD6wGyaP45gUeS63qHTj9yWHKgOb3uvJsfidK+XDyMyIU4O 9YsLwHvb5tnt5qfE4FOyu5oMqfSDcrZxZjfgSts1kHAeh/3Fqd/9Lm7zfF/npz2LlN84 5bpA== X-Gm-Message-State: AElRT7E8R7EopPNQmhIu+vQWO83igazf7I6K5LccraDVTY2dzXAR9ZiY v4LbKH6GTiz1xSdgycqwLv91FGyo4d+3Clzf6C3BDw== X-Google-Smtp-Source: AG47ELt9CkBJCy0SVs/0LaOBJs/pY45/joiZNCB4hZ9xeANO9NyVWzQodcIm+UPpCVk44MYCIao880aiE0GuwTYDFAs= X-Received: by 10.157.49.47 with SMTP id e44mr6373880otc.46.1521131142460; Thu, 15 Mar 2018 09:25:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Thu, 15 Mar 2018 09:25:22 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 15 Mar 2018 21:55:22 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn To: Dave Page Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113daf626766dc056775f119" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113daf626766dc056775f119 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dave, On Thu, Mar 15, 2018 at 9:42 PM, Dave Page wrote: > > > On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> I have just noticed, we're ignoring migrations directory too. >>>> Should we not also check code styling for migrations directory? >>>> >>> >>> Yeah, I was going to ask about that :-). Is there a specific reason why >>> we're ignoring the migrations Murtuza? >>> >> =E2=80=8BTo ease writing long SQL's. >> >> > > Perhaps we could just skip the long line check for those files? > =E2=80=8BWe have to create separate config for that and then run pycodestyl= e using that config for migration.=E2=80=8B =E2=80=8B1) pycodestyle --config=3D.pycodestyle =E2=80=8B2) pycodestyle --config=3D.pycodestyle_migration something like that, Because I checked the documentation and I didn't find any option to have single config file for individual directories. > >> >>> >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page wrote: >>>> >>>>> Ignore config_local.py and config_distro.py when running PEP-8 checks= . >>>>> >>>>> Branch >>>>> ------ >>>>> master >>>>> >>>>> Details >>>>> ------- >>>>> https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdif >>>>> f;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe >>>>> >>>>> Modified Files >>>>> -------------- >>>>> web/.pycodestyle | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113daf626766dc056775f119 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

On Thu, Mar 15, 2018 at 9= :42 PM, Dave Page <dpage@pgadmin.org> wrote:


On Thu, Mar 15, 2018 at 8:30 AM, = Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.co= m> wrote:
On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <dpage@pgadmin.org><= span style=3D"font-family:arial,sans-serif;color:rgb(34,34,34)"> wrote:
<= span>
Hi<= br>

On Thu, Mar 15= , 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com= > wrote:
Hi,

I have just noticed, we'r= e ignoring migrations directory too.
Should we not also check cod= e styling for migrations directory?

Yeah, I was going to ask about that :-). Is there a specific reaso= n why we're ignoring the migrations Murtuza?
=E2=80=8BTo ease writing long SQL's.
= =C2=A0

Perhaps we c= ould just skip the long line check for those files?
=
=E2=80=8BWe have to create = separate config for that and then run pycodestyle using that config for mig= ration.=E2=80=8B
=C2=A0
=E2=80=8B1) pycodes= tyle --config=3D.pycodestyle
=E2=80=8B2)=C2=A0pycodesty= le --config=3D.pycodestyle_migration

something like that, Because I checked the documentation and I didn&= #39;t find any option to have single config file for individual directories= .=C2=A0

= =C2=A0
=C2=A0

--

<= p style=3D"margin:0pt">Thanks & Regards,

<= span style=3D"font-style:italic">Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL = Company


http://www.linkedin.com/in/asheshvashi


On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
Ignore config_local.py and config_distro.py when running= PEP-8 checks.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcom= mitdiff;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe

Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company




--
Dave Page
Blog: http://pgsnake.blogspot.com<= br>Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpri= se PostgreSQL Company
--001a113daf626766dc056775f119--