Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cacAO-00022B-Gv for pgadmin-hackers@arkaria.postgresql.org; Mon, 06 Feb 2017 05:48:44 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cacAO-0003LF-45 for pgadmin-hackers@arkaria.postgresql.org; Mon, 06 Feb 2017 05:48:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cacAA-00035U-AL for pgadmin-hackers@postgresql.org; Mon, 06 Feb 2017 05:48:30 +0000 Received: from mail-ot0-x22f.google.com ([2607:f8b0:4003:c0f::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cacA6-0005fr-HK for pgadmin-hackers@postgresql.org; Mon, 06 Feb 2017 05:48:29 +0000 Received: by mail-ot0-x22f.google.com with SMTP id 73so54947130otj.0 for ; Sun, 05 Feb 2017 21:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lmwwqIBxxhg8dTbPZ/5FopRbIJgS7F8C2SCfILPjJIA=; b=o+qRoqNNWSrnB0FKqI/4NUcyDcmFOCgnWx2fjN/UPOljgoifTjz/SmhUY3HGQWCtkd NbBWHfKk4iBXUC++vlxQywINTP4SgIUvJZ5KAw4LYf07KtFgFKKF/Xzkda16xo5tkRvh oqhuOaD7k+d7RDgh+yUBe1jdmhCPGRCcT7H+Aotd9+DnfJNL8+cQ8oKcyzzRKCPw+s2T nvy29bqjCT0Usr+Zr0Q7Gu1djd+7j65l1ml5k1qtgv8UCTqfWT/1y6cIc3SH5xy5ug54 QELeXufWhwKeidaZhqBDGygHL1UwNGg3MotCB7ENw9l3mhiPf0fs5lm06DQGdRlfgMoT N9gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lmwwqIBxxhg8dTbPZ/5FopRbIJgS7F8C2SCfILPjJIA=; b=FxLivnytxwdpK2hQOfCl+zyDSC3F4rAHTARPKbpWui74Os1ct3A0eIJ5qu8/8n/Dxz ATR67hBeVzc1ThhwR8dTlnZ/5otbMzk8Wae60P1BrEcuqXOMlIWIQqTzj6AQVnKnjugk U0K4+DDy/1Dk7MSSuzpI1O01uS4qaXA/Ia8foyiZrdJPFTGEF/QokND8rFcxok6doBkJ Vhhth67C9y3GutHOgfTuMnMUMkJwCyQCyfLNXFyx3cDkeSvG9xEdQmFUB5gMdvfTStf7 SV1GlMiVq4UUWJmq/pN1DF4I8Gz6LnjZWmtY/8JBhmXCiWvGPssjDiO4e6EIRXDPRXbG eR2Q== X-Gm-Message-State: AMke39l7AfeM2y+U3oX9c6l8uZdreWGmNuwy8KSiwD73/V36PWOzDLAmT5YOUTWHWJTWgzMDVYLOA7iLwUecxyii X-Received: by 10.157.9.170 with SMTP id q39mr4721428otd.147.1486360104845; Sun, 05 Feb 2017 21:48:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.183.26.2 with HTTP; Sun, 5 Feb 2017 21:48:04 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 6 Feb 2017 11:18:04 +0530 Message-ID: Subject: Re: [pgAdmin4][PATCH] To fix the issue in handling of timestamp type To: Dave Page Cc: pgadmin-hackers , Ashesh Vashi Content-Type: multipart/alternative; boundary=001a113dc2160ed6c40547d62e7b X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113dc2160ed6c40547d62e7b Content-Type: text/plain; charset=UTF-8 Sure, Checking. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sat, Feb 4, 2017 at 7:34 PM, Dave Page wrote: > Hi Murtuza, > > I clearly neglected to run the regression tests with this patch, and > unfortunately it looks like it broke them. Can you look at this ASAP > please? > > runTest (pgadmin.browser.server_groups.servers.databases. > schemas.tables.column.tests.test_column_add.ColumnAddTestCase) > This function will add column under table node. (Add table Node URL) > ... 2017-02-04 14:43:55,191: ERROR pgadmin: Failed to execute query > (execute_scalar) for the server #4 - DB:test_db_9e176 (Query-id: > 4792242): > Error Message:ERROR: syntax error at or near "False" > LINE 2: ADD COLUMN test_column_add_f0d5d char(False); > ^ > FAIL > > As far as I can see, the app works fine - it's only the test that > broke (probably because the application uses type name aliases (e.g. > character) rather than the base type name that the test is using > ("char"). > > Thanks. > > On Fri, Feb 3, 2017 at 1:52 PM, Dave Page wrote: > > Thanks - patch applied. > > > > On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala > > wrote: > >> Hi, > >> > >> Please find updates patch for the same. > >> RM#2076 > >> > >> -- > >> Regards, > >> Murtuza Zabuawala > >> EnterpriseDB: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > >> > >> On Wed, Feb 1, 2017 at 3:08 PM, Dave Page wrote: > >>> > >>> Hi > >>> > >>> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala > >>> wrote: > >>> > Hi Dave, > >>> > > >>> > PFA updated patch. > >>> > >>> This seems to display "timestamp(0) with[out] timezone" columns > >>> correctly in both the properties panel and dialog now, but the size is > >>> still ignored if I try to add a new column through the table or column > >>> dialogue. > >>> > >>> -- > >>> Dave Page > >>> Blog: http://pgsnake.blogspot.com > >>> Twitter: @pgsnake > >>> > >>> EnterpriseDB UK: http://www.enterprisedb.com > >>> The Enterprise PostgreSQL Company > >> > >> > > > > > > > > -- > > Dave Page > > Blog: http://pgsnake.blogspot.com > > Twitter: @pgsnake > > > > EnterpriseDB UK: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113dc2160ed6c40547d62e7b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sure, Checking.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
=

On Sat, Feb 4, 2017 at 7:34 PM, Dave Page <= dpage@pgadmin.org> wrote:
H= i Murtuza,

I clearly neglected to run the regression tests with this patch, and
unfortunately it looks like it broke them. Can you look at this ASAP
please?

runTest (pgadmin.browser.server_groups.servers.databases.schemas.= tables.column.tests.test_column_add.ColumnAddTestCase)
This function will add column under table node. (Add table Node URL)
... 2017-02-04 14:43:55,191: ERROR pgadmin: Failed to execute query
(execute_scalar) for the server #4 - DB:test_db_9e176 (Query-id:
4792242):
Error Message:ERROR:=C2=A0 syntax error at or near "False"
LINE 2:=C2=A0 =C2=A0 =C2=A0ADD COLUMN test_column_add_f0d5d char(False); =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
FAIL

As far as I can see, the app works fine - it's only the test that
broke (probably because the application uses type name aliases (e.g.
character) rather than the base type name that the test is using
("char").

Thanks.

On Fri, Feb 3, 2017 at 1:52 PM, Dave Page <dpage@pgadmin.org> wrote:
> Thanks - patch applied.
>
> On Fri, Feb 3, 2017 at 11:46 AM, Murtuza Zabuawala
> <murtuza.zabu= awala@enterprisedb.com> wrote:
>> Hi,
>>
>> Please find updates patch for the same.
>> RM#2076
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Wed, Feb 1, 2017 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi
>>>
>>> On Tue, Jan 31, 2017 at 5:19 AM, Murtuza Zabuawala
>>> <murt= uza.zabuawala@enterprisedb.com> wrote:
>>> > Hi Dave,
>>> >
>>> > PFA updated patch.
>>>
>>> This seems to display "timestamp(0) with[out] timezone&qu= ot; columns
>>> correctly in both the properties panel and dialog now, but the= size is
>>> still ignored if I try to add a new column through the table o= r column
>>> dialogue.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113dc2160ed6c40547d62e7b--