public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Joao De Almeida Pereira <[email protected]>
Cc: Neethu Mariya Joy <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Bug #2309 fix
Date: Fri, 2 Mar 2018 09:45:20 +0530
Message-ID: <CAKKotZQrunVSAH1=GFezerbCFWNRa+hF8g99J9NPTcZsw5SadA@mail.gmail.com> (raw)
In-Reply-To: <CAE+jjamYZfYvwqjonCsO_A5FNP-EuSzXNEdR8sk34hCNC3sUKA@mail.gmail.com>
References: <CAAdJd1Mwu7ths9DfsjZNOshML9wq_guMb5vXzrKhH-8kZojvbQ@mail.gmail.com>
<CAE+jjamYZfYvwqjonCsO_A5FNP-EuSzXNEdR8sk34hCNC3sUKA@mail.gmail.com>
Hi Neethu,
Patch looks good.
We are facing similar issue on dashboard as well where users are not able
to copy the sql from server activity table, I've attached screenshot for
your reference.
Bug: https://redmine.postgresql.org/issues/3137
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Mar 2, 2018 at 3:35 AM, Joao De Almeida Pereira <
[email protected]> wrote:
> Hello Neethu,
>
> We run the patch though our test pipeline and all tests are green.
> Everything looks good with this patch
>
> Thanks
> Joao
> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <
> [email protected]> wrote:
>
>> Hi,
>> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science
>> at BITS Pilani.
>>
>> I've attempted to fix https://redmine.postgresql.org/issues/2309.
>> Codemirrors catches all the keyboard and mouse events when 'readOnly'
>> option is set to 'noCursor' and does not allow copying.
>> So, I've set 'readOnly' option to true. In order to hide the cursor, I've
>> added a class 'hide-cursor-workaround' and applied css styles to hide the
>> cursor.
>>
>> I'm attaching my patch as bug2309.diff below as per the contribution
>> guidelines.
>>
>> Hope this helps. Thank you for your consideration!
>>
>> Sincerely,
>> Neethu Mariya Joy
>> GitHub <https://github.com/Roboneet; | Linkedin
>> <https://www.linkedin.com/in/neethu-mariya-joy-653655128/;
>>
>>
>>
Attachments:
[image/png] Screen Shot 2018-03-02 at 9.24.04 am.png (227.9K, 3-Screen%20Shot%202018-03-02%20at%209.24.04%20am.png)
download | view image
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Bug #2309 fix
In-Reply-To: <CAKKotZQrunVSAH1=GFezerbCFWNRa+hF8g99J9NPTcZsw5SadA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox