Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3f4R-0002yg-4Y for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 09:51:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3f4P-0005cK-R2 for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 09:51:09 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3f4P-0005c9-E4 for pgadmin-hackers@lists.postgresql.org; Wed, 04 Apr 2018 09:51:09 +0000 Received: from mail-ot0-x231.google.com ([2607:f8b0:4003:c0f::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3f4M-0001ZV-1l for pgadmin-hackers@postgresql.org; Wed, 04 Apr 2018 09:51:08 +0000 Received: by mail-ot0-x231.google.com with SMTP id n40-v6so22644779otd.3 for ; Wed, 04 Apr 2018 02:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qYnHeJ4727fAR4oaHmb0EZNPK6sMEb83J8ejZr+WM+c=; b=pkG0m7nfqLyoseI+kZJnrD/tVk9tATEuOkeJSjQjJSW7FE0vsLKb3z/Z+DiEbOTgRq XWd/eeG/Y5v6CTEhKzelNxdCdL3VrD5JbMPzlHEtJvvm1X6DFxnbmWHPc/QCeUDtbnKF lz5X7ucvRWs+etdqByUlibUmtYMjmZQ5xHrleMGKpNzW4yMsal3l7IkB03jmQGfrQ2/J sPyi7NHYP+HKaQW2UNmdPcM0fOj3Ickn/l/wrD5PfXOk9gXyn9lZU+taE8AQHDhi63Zq 9ElkV9gGZdVnOTLDa3ryWOEbirYEsGlOBOItnuNeOOmNiBvdij2q6x5+6AYTCP1mEjT7 XhhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qYnHeJ4727fAR4oaHmb0EZNPK6sMEb83J8ejZr+WM+c=; b=E6/y+WZv428WbBEAnKTCFQpCpEW8UTAvAVqbI9rySu5bCd4Gi1j1u7pK1JgpoSNWFr EROqS/NbUiNYccCLmh3E+AL7xizJ1+0m/6jxNZS1rg3dzOT86VK6QSPJEp2JDeIDL4Js FQjvJj2fqVoovWZGdAlz8AIehLT07ovHtf0rdw4QG0QucXqYD1o5dYyX1hoh+Jvvomxc ysWdSwqxBNqHBVaVud9aWns2hR0FGJqfi7HQvDiZaFmahWJndfJ2jbEx6+cXnAwZe9R1 rAvs0BfOhjSXmMZhCmJ+J5SSOG8JMqrprLJL5o9jG7hFckSuoDH9Bl5esrF3hlLz5e5l Jaww== X-Gm-Message-State: ALQs6tCSp2tYsxJRurxfVRFTjvVFpjVOwK9jLt7ZrjMIT1n/T5oibfI2 TlL7yRQEkiWcenwqYQnYokEt0IbuJAz/bpCy0WCfOA== X-Google-Smtp-Source: AIpwx49zZE1jwi/dbiRsqLdu3h6GydQpSpjaNnY3eVFeTcJ5zlF33qbP7typ5LPo51UgcCQ/vQA7scduKOAi9I+ra9A= X-Received: by 2002:a9d:5904:: with SMTP id t4-v6mr2167460oth.284.1522835465054; Wed, 04 Apr 2018 02:51:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.138.6.138 with HTTP; Wed, 4 Apr 2018 02:50:44 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Wed, 4 Apr 2018 15:20:44 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version To: Dave Page Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000f24a4f056902c2ea" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f24a4f056902c2ea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 4, 2018 at 3:19 PM, Dave Page wrote: > > > On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Joao, >> >> Yes it bundles latest version but I doubt that is not using it, If we >> upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. >> I have tried that and I started getting jQuery related errors when tryin= g >> to run query tool or when running jasmine tests. >> > > Can you spend some time trying to figure it out please? We need to get on > to 3.x as older versions are no longer receiving updates which could pose= a > security risk. > =E2=80=8BSure Dave.=E2=80=8B > > >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Murtuza, >>> >>> The patches look good and they pass all tests in CI. >>> One think that we realized was the SlickGrid as a npm package now: >>> https://www.npmjs.com/package/slickgrid >>> Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully >>> supported or not...... >>> >>> Thanks >>> Victoria & Joao >>> >>> On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> =E2=80=8BHi Dave, >>>> >>>> Reverted back jQuery version to 1.x because of SlickGrid dependancy. >>>> Please find updated patch. >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Please hold on my previous patch. >>>>> >>>>> We can't use latest jQuery version as SlickGrid has dependancy on >>>>> older version. >>>>> I'll send updated patch again. >>>>> >>>>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> Please find updated patches, there are two patches attached one is >>>>>> for the story and another is for changes required as per new modules= . >>>>>> >>>>>> >>>>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> PFA patch to update the modules to latest version. >>>>>>>> >>>>>>>> >>>>>>> - Why isn't jQuery updated to 3.3.1? >>>>>>> >>>>>> =E2=80=8BDone=E2=80=8B >>>>>> >>>>>> >>>>>>> =E2=80=8B >>>>>>> >>>>>>> >>>>>> >>>>>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg= 2 >>>>>>> and pycrypto etc? >>>>>>> >>>>>> =E2=80=8BDone=E2=80=8B >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> We are not able to update some of the modules to latest version du= e >>>>>>>> to dependancy on other modules, For example >>>>>>>> - Python: Flask-Security has dependancy on flask-babelex which >>>>>>>> causes conflict with flask_babel >>>>>>>> >>>>>>> >>>>>>> Hmm, flask-babelex might be a better option anyway; in particular, >>>>>>> it avoids loading catalogs with every request which seems desirable= given >>>>>>> the size of ours. On the other hand, it hasn't been updated so rece= ntly. >>>>>>> >>>>>> =E2=80=8BI have removed flask-babel and used flask_babelex instead.= =E2=80=8B >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & >>>>>>>> Bootstrap Datetime picker has dependancy on Bootstrap3. >>>>>>>> >>>>>>> >>>>>>> OK. >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000f24a4f056902c2ea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Apr 4, 2018 at 3:19 PM, Dave Page <dpage@pgadmin.org&g= t; = wrote:


On Wed, Apr 4, 2018 at 8:24 AM, Murtuz= a Zabuawala <murtuza.zabuawala@enterprisedb.com&= gt; wrote:
Hi Joao,

Yes it bundles latest ver= sion but I doubt that is not using it, If we upgrade the jQuery to 3.3.1 th= en it's breaking the SlickGrid.
I have tried that and I started getting jQuery re= lated errors when trying to run query tool or when running jasmine tests.

Can you spend some time trying t= o figure it out please? We need to get on to 3.x as older versions are no l= onger receiving updates which could pose a security risk.
=
=E2=80=8BSure Dave.= =E2=80=8B
=C2=A0
=
=C2=A0

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company

<= /div>

On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Murtuza,

The patches l= ook good and they pass all tests in CI.
One think that we realize= d was the SlickGrid as a npm package now:=C2=A0https://www.npmjs.com/packag= e/slickgrid=C2=A0
Also Slickgrid comes packaged with jquery 3= .1 not sure if it is fully supported or not......

= Thanks
Victoria & Joao

On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala <murtuza.z= abuawala@enterprisedb.com> wrote:
=E2=80=8BHi Dave,

Reverted back jQuery version to 1.x becau= se of SlickGrid dependancy.
Please find updated pat= ch.

--
Regards,
Murtuza Zabua= wala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The E= nterprise PostgreSQL Company

=

On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Please hold on my previou= s patch.=C2=A0

= We can't use latest jQuery version as SlickGrid has dependancy on older= version.
= I'll send updated patch again.

On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Hi Dave,

Please find updated patches, there are tw= o patches attached one is for the story and another is for changes required= as per new modules.


On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to update the modules to latest version.


- Why isn't jQuery updated to 3.3.1?
=E2=80=8BDone=E2=80=8B
= =C2=A0
=E2=80=8B
=C2=A0

- Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2= and pycrypto etc?=C2=A0
=E2=80=8BDone=E2=80=8B
=C2=A0
<= div dir=3D"ltr">
=
=C2=A0
=
We are not able to updat= e some of the modules to latest version due to dependancy on other modules,= For example
- Python: Flask-Security has dependancy on flask-babelex which causes co= nflict with flask_babel

Hmm, fl= ask-babelex might be a better option anyway; in particular, it avoids loadi= ng catalogs with every request which seems desirable given the size of ours= . On the other hand, it hasn't been updated so recently.
=E2=80=8BI have removed flask-babel and us= ed flask_babelex instead.=E2=80=8B
=C2=A0
=C2=A0
- JS: Can't updat= e to Bootstrap4 because Bootstrap Switch & = Bootstrap=C2=A0Datetime picker has dependancy on Bootstrap3.

OK.=C2=A0


--
Dave Page
Blog: http://pgsnake.blogsp= ot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company







--
Dave Page
= Blog: http://pgsn= ake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company
--000000000000f24a4f056902c2ea--