Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyWol-0001DK-RZ for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 06:01:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyWoj-0002n5-Rq for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 06:01:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyWoj-0002mv-Ij for pgadmin-hackers@lists.postgresql.org; Wed, 21 Mar 2018 06:01:45 +0000 Received: from mail-ot0-x229.google.com ([2607:f8b0:4003:c0f::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyWod-0003zJ-8T for pgadmin-hackers@postgresql.org; Wed, 21 Mar 2018 06:01:44 +0000 Received: by mail-ot0-x229.google.com with SMTP id x6-v6so2979316otg.11 for ; Tue, 20 Mar 2018 23:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=adwSN07KOOqp/l4B0olJkxl7o19dDvfR3uZHeUBLMc8=; b=qI4OXiXplDHP90WadoBkfjkPmdfxMmW+eb9Z0mkwEKvtz3teKMEj7oZ77FzjJKO00e ON6m/2zc2jMZJ3avBJKxNUAXVGTYCjqYGWECgTBNU8idLG9Q6cNCAarSugUxXm5QFikC cVbEm9Js1cGf/+Uz79nYfnzhjC9tGyLJZe2eahxwGPgggWjGLnDlUXVD8P5Kbu9/+JDf dbYXPPZjBPysLS3w0W2XxG2UoyjSpOeMeinmGV8jh5+VJdjP/IcD/z9ykJz9Ylzxa+W+ c52fs5nHdOVRib+M8FZOLDJjpUU5eb7ElpV2iDyEnCtMp8edXhOFVkzOKYYH63fbHto5 aGzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=adwSN07KOOqp/l4B0olJkxl7o19dDvfR3uZHeUBLMc8=; b=t03ux9DN4xNv6ExBgZTaGo0GKsuilFNkwOX1YclkUC7GsupZWWl40VBAZmWFxd0WUb QGz0zPvVL0svG1D/HmixUH6c4wjB35DaV++4g3OCut18b22Hx7NivNuH+HaHDAGneWCY vE8dsmjROpZvaC3v9taZk64dcRR1TSt/NL9AC+WzDGSIwlPeWjAV2+lRQ8cFTUaP+lv0 FGNH2mYkfrNO/L9i71ag8OtxP9IO2/VrHPnw7TVIGiHqyrgD5+txSztz+acTVZPo1sm8 IHufbJJD9KJilu0el9JGXswGqdI5gVG8O4Mwh+OyQ0iDN+WGacCAPeTxqNlg6+rOmZab 6Jrg== X-Gm-Message-State: AElRT7EJF2xO69AA8yW0VsdOm/A2h9YwQW6/wxU/iyCX2/BiMucwrcCB SWmAGSNZjCa/6tl34vKJUZFEeGvA/lXT796gEzoLD3IU X-Google-Smtp-Source: AG47ELsix6HV6dirP5naK9ahOmnYQlVxsQwykyfaAsZc+iyEUd/Tq7CGeHn02jdm11fIrEfbqpR/oOWiw8BeY7EASJw= X-Received: by 2002:a9d:5e12:: with SMTP id d18-v6mr4651777oti.386.1521612095689; Tue, 20 Mar 2018 23:01:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.149.198 with HTTP; Tue, 20 Mar 2018 23:01:15 -0700 (PDT) From: Murtuza Zabuawala Date: Wed, 21 Mar 2018 11:31:15 +0530 Message-ID: Subject: Checklist before sending patch to pgAdmin4-hackers To: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000732f920567e5ec9b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000732f920567e5ec9b Content-Type: text/plain; charset="UTF-8" Hello, Here is the common checklist to follow before sending patch to pgAdmin4-hackers group, 1) Get the latest pull from master branch. 2) Apply your patch and check if applies successfully on the latest code. 3) Check for PEP8 issues - activate virtual env - cd ../web - yarn run pep8 4) Run regression test python regression/runtests.py - To run only UI/feature tests python regression/runtests.py --pkg feature_tests - To run regression test (without UI/Feature tests) python regression/runtests.py --exclude feature_tests 5) Run Jasmine tests - activate virtual env - cd ../web yarn run test:karma-once 6) Make sure to add or update help docs and screenshot(s) if you have added any new feature or changed any existing one. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000732f920567e5ec9b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Here is the common checklist to= follow before sending patch to pgAdmin4-hackers group,

1) Get the latest pull from master branch.
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:r= gb(68,68,68)">
2) Apply your patch and check if app= lies successfully on the latest code.

3) Check for PEP8 issues
- activate virtual env=
- cd ../web
- yarn run pep8

=
4) Run regression test
python regression/runtests.py=C2=A0

- To run only UI/feature tes= ts
<= div class=3D"gmail_default" style=3D"font-size:small;font-style:normal;font= -variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-s= pacing:normal;text-align:start;text-indent:0px;text-transform:none;white-sp= ace:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-c= olor:initial;font-family:verdana,sans-serif;color:rgb(68,68,68)">python regression/runtests.py --pkg= feature_tests=C2=A0
<= br>
- To run regression test (withou= t UI/Feature tests)
python regression/runtests.py --exclude feature_tests=C2=A0<= /span>

5) Run Jasmine tests
- activate virtual env
- cd ../web
yarn run= =C2=A0test:karma-once

6) Make sure to add or update help docs and screen= shot(s) if you have added any new=C2=A0feature= =C2=A0or changed any existing one.

--
Regards,
= Murtuza Zabuawala
E= nterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise= PostgreSQL Company

--000000000000732f920567e5ec9b--