Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjicE-0002hT-Hh for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Sep 2016 07:58:50 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bjicD-0007Bd-RR for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Sep 2016 07:58:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bjicC-0007BA-N4 for pgadmin-hackers@postgresql.org; Tue, 13 Sep 2016 07:58:48 +0000 Received: from mail-qk0-x229.google.com ([2607:f8b0:400d:c09::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bjic9-00080r-KW for pgadmin-hackers@postgresql.org; Tue, 13 Sep 2016 07:58:47 +0000 Received: by mail-qk0-x229.google.com with SMTP id t7so64489680qkh.2 for ; Tue, 13 Sep 2016 00:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=ConcSdtq85V6bJQ0WTxhv8wIP9E6IaN2xr0J5NiH2po=; b=jXphIjn4Tgq/OOkWmJzqgycgFlY/KBCjZj7EfYbGEz+pVqKVE+F94J8ThpjlW2sYfU GEPIewwwzW0igpqTu8dEeokIgCJ+jblFjeXGkXnMjP4oP8k7uYP7aCf4N5Dft9Y4g5HO 4t1epZ2YbG3IJ2IYqxE3CVerKZEor4GnmFujtafHx6KqODlowBEpj8uOaL++9OwQeu2y 8JoJtVBSpT1QBG+jA+xDUE7uu3A2pu+4y7uzpUAbBXDN1MhdZa+TY0nnvQc7ui5TBDND 7Muxx92cJ1yDoBEV1JkGQBcaeGn2KLtBdRQ3qSNwXtL5GhMGPqoH7s2MKR8ER+UFh6i5 IKzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ConcSdtq85V6bJQ0WTxhv8wIP9E6IaN2xr0J5NiH2po=; b=Btig49Pyy21rhSruPIhPK2eRph2+OpU8/t3n5dtVOmmQdViZoLq33r9p/HFpSwK595 pRmpZMMjZ1FLH39hqNgiKHo1QbvOgIIrVMU3GFcneG6vT6SpyYRFWx6P++vdLkKksFst XqvELl4OXtpoAOHMuSYV1fIkrZL9Rfy/w58yHlbKTDOTNQaXjd9q503Gk+jGiOJN5a4G WVRh/8k4ZRVWwCyIuUxnMmLtIkqknOcU+KXNfrGkzMYRGPnspHLMhkrnssQiVyMN63E6 d2RelzHyZ/F7IZsPRqHhda8DztDQDGSQ9Lx/cdb1J1ngvDqVl1ci/7v/yJGNj5vU7/oe 8zQg== X-Gm-Message-State: AE9vXwO2ocaAmn6gL4VJKiFTBpqj1/M+EH6FzeMgLLj9i093wA7YtVKg/C0CiQAK38OMbWkJlMfg0SbOetsOkDyq X-Received: by 10.55.158.210 with SMTP id h201mr23643856qke.41.1473753523655; Tue, 13 Sep 2016 00:58:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.129.194 with HTTP; Tue, 13 Sep 2016 00:58:23 -0700 (PDT) From: Murtuza Zabuawala Date: Tue, 13 Sep 2016 13:28:23 +0530 Message-ID: Subject: PATCH: To fix the issue on Table collection node refresh (pgAdmin4) To: pgadmin-hackers Content-Type: multipart/mixed; boundary=94eb2c06547443d80a053c5efb46 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c06547443d80a053c5efb46 Content-Type: multipart/alternative; boundary=94eb2c06547443d806053c5efb44 --94eb2c06547443d806053c5efb44 Content-Type: text/plain; charset=UTF-8 Hi, PFA patch to fix the issue where user tries to refresh on Table collection node it was throwing error. RM#1686 Issue: Nodes method was not implemented properly to handle such request in Table node. Also attaching a separate patch for typo in browser.js file due to which this error was displaying on console and not on GUI. @Ashesh, Would you please review this minor patch (File: misc_typo_fix.patch), I hope it does not affect anything else :) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c06547443d806053c5efb44 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA patch to fix= the issue where user tries to refresh on Table collection node it was thro= wing error.
RM#1686

Issue: Nodes method was not imple= mented properly to handle such request in Table node.

Also att= aching a separate patch for typo in browser.js file due to which this error= was displaying on console and not on GUI.

@Ashesh, Would you = please review this minor patch (File: misc_typo_fix.patch), I hope it does = not affect anything else :)


--
Regards,=
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany
<= /div>
--94eb2c06547443d806053c5efb44-- --94eb2c06547443d80a053c5efb46 Content-Type: text/x-patch; charset=US-ASCII; name="RM_1686.patch" Content-Disposition: attachment; filename="RM_1686.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_it16jasc0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9fX2luaXRfXy5w eSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJz L2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy9fX2luaXRfXy5weQppbmRleCA4 MmMzNDNkLi4wNDBhZmI4IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVz L19faW5pdF9fLnB5CkBAIC0yMyw3ICsyMyw3IEBAIGZyb20gcGdhZG1pbi5i cm93c2VyLnNlcnZlcl9ncm91cHMuc2VydmVycy51dGlscyBpbXBvcnQgcGFy c2VfcHJpdl9mcm9tX2RiLCBcCiAgICAgcGFyc2VfcHJpdl90b19kYgogZnJv bSBwZ2FkbWluLmJyb3dzZXIudXRpbHMgaW1wb3J0IFBHQ2hpbGROb2RlVmll dwogZnJvbSBwZ2FkbWluLnV0aWxzLmFqYXggaW1wb3J0IG1ha2VfanNvbl9y ZXNwb25zZSwgaW50ZXJuYWxfc2VydmVyX2Vycm9yLCBcCi0gICAgbWFrZV9y ZXNwb25zZSBhcyBhamF4X3Jlc3BvbnNlCisgICAgbWFrZV9yZXNwb25zZSBh cyBhamF4X3Jlc3BvbnNlLCBnb25lCiBmcm9tIHBnYWRtaW4udXRpbHMuZHJp dmVyIGltcG9ydCBnZXRfZHJpdmVyCiAKIGZyb20gY29uZmlnIGltcG9ydCBQ R19ERUZBVUxUX0RSSVZFUgpAQCAtMzUwLDYgKzM1MCw0NiBAQCBjbGFzcyBU YWJsZVZpZXcoUEdDaGlsZE5vZGVWaWV3LCBEYXRhVHlwZVJlYWRlciwgVmFj dXVtU2V0dGluZ3MpOgogICAgICAgICApCiAKICAgICBAY2hlY2tfcHJlY29u ZGl0aW9uCisgICAgZGVmIG5vZGUoc2VsZiwgZ2lkLCBzaWQsIGRpZCwgc2Np ZCwgdGlkKToKKyAgICAgICAgIiIiCisgICAgICAgIFRoaXMgZnVuY3Rpb24g aXMgdXNlZCB0byBsaXN0IGFsbCB0aGUgdGFibGUgbm9kZXMgd2l0aGluIHRo YXQgY29sbGVjdGlvbi4KKworICAgICAgICBBcmdzOgorICAgICAgICAgICAg Z2lkOiBTZXJ2ZXIgZ3JvdXAgSUQKKyAgICAgICAgICAgIHNpZDogU2VydmVy IElECisgICAgICAgICAgICBkaWQ6IERhdGFiYXNlIElECisgICAgICAgICAg ICBzY2lkOiBTY2hlbWEgSUQKKyAgICAgICAgICAgIHRpZDogVGFibGUgSUQK KworICAgICAgICBSZXR1cm5zOgorICAgICAgICAgICAgSlNPTiBvZiBhdmFp bGFibGUgdGFibGUgbm9kZXMKKyAgICAgICAgIiIiCisgICAgICAgIHJlcyA9 IFtdCisgICAgICAgIFNRTCA9IHJlbmRlcl90ZW1wbGF0ZSgiLyIuam9pbihb c2VsZi50ZW1wbGF0ZV9wYXRoLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICdub2Rlcy5zcWwnXSksCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzY2lkPXNjaWQsIHRpZD10aWQpCisgICAgICAg IHN0YXR1cywgcnNldCA9IHNlbGYuY29ubi5leGVjdXRlXzJkYXJyYXkoU1FM KQorICAgICAgICBpZiBub3Qgc3RhdHVzOgorICAgICAgICAgICAgcmV0dXJu IGludGVybmFsX3NlcnZlcl9lcnJvcihlcnJvcm1zZz1yc2V0KQorICAgICAg ICBpZiBsZW4ocnNldFsncm93cyddKSA9PSAwOgorICAgICAgICAgICAgICAg IHJldHVybiBnb25lKGdldHRleHQoIkNvdWxkIG5vdCBmaW5kIHRoZSB0YWJs ZS4iKSkKKworICAgICAgICByZXMgPSBzZWxmLmJsdWVwcmludC5nZW5lcmF0 ZV9icm93c2VyX25vZGUoCisgICAgICAgICAgICAgICAgcnNldFsncm93cydd WzBdWydvaWQnXSwKKyAgICAgICAgICAgICAgICBzY2lkLAorICAgICAgICAg ICAgICAgIHJzZXRbJ3Jvd3MnXVswXVsnbmFtZSddLAorICAgICAgICAgICAg ICAgIGljb249Imljb24tdGFibGUiLAorICAgICAgICAgICAgICAgIHRpZ2dl cl9jb3VudD1yc2V0Wydyb3dzJ11bMF1bJ3RyaWdnZXJjb3VudCddLAorICAg ICAgICAgICAgICAgIGhhc19lbmFibGVfdHJpZ2dlcnM9cnNldFsncm93cydd WzBdWydoYXNfZW5hYmxlX3RyaWdnZXJzJ10KKyAgICAgICAgICAgICkKKwor ICAgICAgICByZXR1cm4gbWFrZV9qc29uX3Jlc3BvbnNlKAorICAgICAgICAg ICAgZGF0YT1yZXMsCisgICAgICAgICAgICBzdGF0dXM9MjAwCisgICAgICAg ICkKKworCisgICAgQGNoZWNrX3ByZWNvbmRpdGlvbgogICAgIGRlZiBub2Rl cyhzZWxmLCBnaWQsIHNpZCwgZGlkLCBzY2lkKToKICAgICAgICAgIiIiCiAg ICAgICAgIFRoaXMgZnVuY3Rpb24gaXMgdXNlZCB0byBsaXN0IGFsbCB0aGUg dGFibGUgbm9kZXMgd2l0aGluIHRoYXQgY29sbGVjdGlvbi4KZGlmZiAtLWdp dCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJz L2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMvdGFibGUvc3Fs LzkuMV9wbHVzL25vZGVzLnNxbCBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2Vy dmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90 ZW1wbGF0ZXMvdGFibGUvc3FsLzkuMV9wbHVzL25vZGVzLnNxbAppbmRleCA0 M2YxNGNiLi40MDkyNDdjIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvdGVtcGxhdGVzL3RhYmxlL3NxbC85LjFfcGx1cy9ub2Rlcy5zcWwK KysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZl cnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRlcy90YWJsZS9z cWwvOS4xX3BsdXMvbm9kZXMuc3FsCkBAIC0zLDQgKzMsNSBAQCBTRUxFQ1Qg cmVsLm9pZCwgcmVsLnJlbG5hbWUgQVMgbmFtZSwKICAgICAoU0VMRUNUIGNv dW50KCopIEZST00gcGdfdHJpZ2dlciBXSEVSRSB0Z3JlbGlkPXJlbC5vaWQg QU5EIHRnaXNpbnRlcm5hbCA9IEZBTFNFIEFORCB0Z2VuYWJsZWQgPSAnTycp IEFTIGhhc19lbmFibGVfdHJpZ2dlcnMKIEZST00gcGdfY2xhc3MgcmVsCiAg ICAgV0hFUkUgcmVsLnJlbGtpbmQgSU4gKCdyJywncycsJ3QnKSBBTkQgcmVs LnJlbG5hbWVzcGFjZSA9IHt7IHNjaWQgfX06Om9pZAotICAgIE9SREVSIEJZ IHJlbC5yZWxuYW1lOwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKKyAg ICB7JSBpZiB0aWQgJX0gQU5EIHJlbC5vaWQgPSB7e3RpZH19OjpPSUQgeyUg ZW5kaWYgJX0KKyAgICBPUkRFUiBCWSByZWwucmVsbmFtZTsKZGlmZiAtLWdp dCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJz L2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMvdGFibGUvc3Fs LzkuNV9wbHVzL25vZGVzLnNxbCBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2Vy dmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90 ZW1wbGF0ZXMvdGFibGUvc3FsLzkuNV9wbHVzL25vZGVzLnNxbAppbmRleCA0 M2YxNGNiLi40MDkyNDdjIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93 c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90 YWJsZXMvdGVtcGxhdGVzL3RhYmxlL3NxbC85LjVfcGx1cy9ub2Rlcy5zcWwK KysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZl cnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRlcy90YWJsZS9z cWwvOS41X3BsdXMvbm9kZXMuc3FsCkBAIC0zLDQgKzMsNSBAQCBTRUxFQ1Qg cmVsLm9pZCwgcmVsLnJlbG5hbWUgQVMgbmFtZSwKICAgICAoU0VMRUNUIGNv dW50KCopIEZST00gcGdfdHJpZ2dlciBXSEVSRSB0Z3JlbGlkPXJlbC5vaWQg QU5EIHRnaXNpbnRlcm5hbCA9IEZBTFNFIEFORCB0Z2VuYWJsZWQgPSAnTycp IEFTIGhhc19lbmFibGVfdHJpZ2dlcnMKIEZST00gcGdfY2xhc3MgcmVsCiAg ICAgV0hFUkUgcmVsLnJlbGtpbmQgSU4gKCdyJywncycsJ3QnKSBBTkQgcmVs LnJlbG5hbWVzcGFjZSA9IHt7IHNjaWQgfX06Om9pZAotICAgIE9SREVSIEJZ IHJlbC5yZWxuYW1lOwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKKyAg ICB7JSBpZiB0aWQgJX0gQU5EIHJlbC5vaWQgPSB7e3RpZH19OjpPSUQgeyUg ZW5kaWYgJX0KKyAgICBPUkRFUiBCWSByZWwucmVsbmFtZTsK --94eb2c06547443d80a053c5efb46 Content-Type: text/x-patch; charset=US-ASCII; name="misc_typo_fix.patch" Content-Disposition: attachment; filename="misc_typo_fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_it16mvw91 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jy b3dzZXIvanMvYnJvd3Nlci5qcyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVt cGxhdGVzL2Jyb3dzZXIvanMvYnJvd3Nlci5qcwppbmRleCA3YTIwMmU4Li5i OTFlZWZkIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBs YXRlcy9icm93c2VyL2pzL2Jyb3dzZXIuanMKKysrIGIvd2ViL3BnYWRtaW4v YnJvd3Nlci90ZW1wbGF0ZXMvYnJvd3Nlci9qcy9icm93c2VyLmpzCkBAIC0x NDMwLDEwICsxNDMwLDEwIEBAIGZ1bmN0aW9uKHJlcXVpcmUsICQsIF8sIFMs IEJvb3RzdHJhcCwgcGdBZG1pbiwgQWxlcnRpZnksIENvZGVNaXJyb3IpIHsK ICAgICAgICAgICAgICAgICAgIHN1Y2Nlc3MoKTsKICAgICAgICAgICAgICAg ICB9CiAgICAgICAgICAgICAgIH0sCi0gICAgICAgICAgICAgIGVycm9yOiBm dW5jdGlvbihqcXgsIGVycm9yLCBzdGF0dXMpIHsKKyAgICAgICAgICAgICAg ZXJyb3I6IGZ1bmN0aW9uKHhociwgZXJyb3IsIHN0YXR1cykgewogICAgICAg ICAgICAgICAgIGlmICgKICAgICAgICAgICAgICAgICAgICFBbGVydGlmeS5w Z0hhbmRsZUl0ZW1FcnJvcigKLSAgICAgICAgICAgICAgICAgICAgeGhyLCBl cnJvciwgbWVzc2FnZSwge2l0ZW06IF9pLCBpbmZvOiBpbmZvfQorICAgICAg ICAgICAgICAgICAgICB4aHIsIGVycm9yLCBzdGF0dXMsIHtpdGVtOiBfaSwg aW5mbzogaW5mb30KICAgICAgICAgICAgICAgICAgICkKICAgICAgICAgICAg ICAgICApIHsKICAgICAgICAgICAgICAgICAgIHZhciBtc2cgPSB4aHIucmVz cG9uc2VUZXh0LAo= --94eb2c06547443d80a053c5efb46 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c06547443d80a053c5efb46--