Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2zQD-0005FG-EE for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 May 2016 11:13:49 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b2zQD-0005Op-0b for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 May 2016 11:13:49 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b2zPz-0005Ax-7i for pgadmin-hackers@postgresql.org; Wed, 18 May 2016 11:13:35 +0000 Received: from mail-qg0-x233.google.com ([2607:f8b0:400d:c04::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b2zPr-0000tK-5S for pgadmin-hackers@postgresql.org; Wed, 18 May 2016 11:13:33 +0000 Received: by mail-qg0-x233.google.com with SMTP id f92so23383183qgf.0 for ; Wed, 18 May 2016 04:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UEThODOwyn0q9YacsMoKkCVfxJDBY1Un4OIF4gLPMgo=; b=cxbzNBKMhHamSqqYPUX7mVh5L+C5QSTrkggKY68UmJlrXA0g9cilC5nL2yYt/l8syT jIh+6sTfGtICvuvG27+CXXxQCUYqrkCaAiRf/NgS27LJJ4j7bWRUvH9IFJMf4JfHxvQf 54sacKWismGrvAp5ltOpEItzQ4N4L9t3hfn1SRhAJV4yrDR7mf2mq6sTJaV8++HgDMvr xKt4Rb5FiVXdNBGhAifyykfwzxUo7tKztb12WDDIGuFA5eBQW+jBriQcNTrjtWPff+UA 2s4RpwUZIB0eNtUscEmRhAdZZgJQo7ubNrq1NnLD3/2KybbkxGPwWjbGdtnCgLSiVphz 0zcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UEThODOwyn0q9YacsMoKkCVfxJDBY1Un4OIF4gLPMgo=; b=gubUvlJL6wGzOvXg9J0C/ZgbVTvP5QgJBSm0davMa1xDf62MN31eInubfNdkcu4WCN 7PAVrNUg/5QJqMzZ+7ZPGZnguV9C3VQ2mo8WO5VQTU5WpucfUxmnNlzvUzqY6ObOslZm VoEONhlrV82EK8KBcFLPi1lYoB4Z8A3KMLFHDt1KGcW7o9lxWhDdMcTfg6ZXmbAOjONI /nVZ6XqNsRHKG/dKx9pwp1Ve3v7K3ZgmFjHNZi7wzzIMyFHFtEw84BfQErwU3zz+HyJ4 OHVn4iK099mExM2XeYx32IHNFQQpQg9rbYw4yqHzLCc9E6RAfiwaQFbWaquYDNmLJToC q4Fg== X-Gm-Message-State: AOPr4FVa9NuQVP8YQHF7gr1V+PevCXXzLN432o36UWHd1j9SseT/+QFH6tw8p4l6E/7DcbjGvSTD1xkr5nmgIRAm X-Received: by 10.140.136.16 with SMTP id 16mr7195996qhi.25.1463570005984; Wed, 18 May 2016 04:13:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.207.202 with HTTP; Wed, 18 May 2016 04:13:06 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Wed, 18 May 2016 16:43:06 +0530 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) To: Harshal Dhumal Cc: pgadmin-hackers , Sanket Mehta Content-Type: multipart/mixed; boundary=001a1138ee4e5004db05331bf27d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1138ee4e5004db05331bf27d Content-Type: multipart/alternative; boundary=001a1138ee4e5004d805331bf27b --001a1138ee4e5004d805331bf27b Content-Type: text/plain; charset=UTF-8 Hi, PFA table add-on patch version 8.4. (apply after 8.3) This includes changes for trigger node issues. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 4:19 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA table add-on patch version 8.3. (apply after 8.2) > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, May 18, 2016 at 3:20 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> PFA table add-on patch version 8.2 >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Wed, May 18, 2016 at 2:42 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch for table node (version 8.1). apply this patch on version 7 >>> patch. Not all issue are fixed in this patch. Murtuza will be sending >>> version 8.2 witch will have resolution for remaining issues. Apply version >>> 8.2 patch on version 8.1 >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer * >>> >>> >>> >>> EenterpriseDB >>> >>> On Tue, May 17, 2016 at 10:12 PM, Sanket Mehta < >>> sanket.mehta@enterprisedb.com> wrote: >>> >>>> Hi Harshal, >>>> >>>> >>>> Below are my review comments: >>>> >>>> I got below warning when I tried to apply the patch for table node as >>>> mentioned below: >>>> >>>> Table creation: >>>> >>>> - Trailing white spaces warnings >>>> >>>> $ git apply >>>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch >>>> >>>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch:6008: trailing >>>> whitespace. >>>> return false; >>>> >>>> /projects/patches/pgadmin4/Table/table_14_May_V6.patch:6016: trailing >>>> whitespace. >>>> return false; >>>> warning: 2 lines add whitespace errors. >>>> >>> >>> Fixed (These were introduced due to rules node.) >>> >>> >>>> >>>> - In Table creation dialog, while adding a new primary key, it does >>>> not allow to change the tablespace to empty. (which is not the case in case >>>> of tablespace in table) >>>> >>>> Fixed >>> >>>> >>>> - In Table creation dialog, while adding a new column, data type >>>> and name field must be mandatory. otherwise while clicking on save it gives >>>> below error >>>> >>>> File >>>> "/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py", >>>> line 1319, in _parse_format_columns >>>> c['cltype'] = self._cltype_formatter(c['cltype']) >>>> KeyError: 'cltype >>>> >>> Fixed >>> >>> >>>> >>>> - In Table creation dialog, While adding a new column, in primary >>>> check box is needed to click twice in order to check it. Ideally it should >>>> be checked by only one click. >>>> >>>> This is Backgrid behaviour. >>> >>>> >>>> - In Table creation dialog, While adding a new column, primary key >>>> should not be allowed to added unless user has provided name and data type >>>> for at least one column. >>>> >>>> Fixed >>> >>>> >>>> - currently if user has clicked on add column button and >>>> immediately click on add primary key button, it will add a row in primary >>>> key data grid >>>> >>>> Fixed >>> >>>> >>>> - When delete table/drop cascade is apply on any table, i got a >>>> javascript error as mentioned below >>>> >>>> node.js:94 Uncaught TypeError: self.canDrop.apply is >>>> not a function >>>> >>> Already fixed in other commit. >>> >>> >>>> >>>> - Once the above error generated, every time user tries to open a >>>> context menu by right clicking on any existing table, that same error comes >>>> >>>> Already fixed in other commit. >>> >>>> >>>> - In table creation dialog, if table is inherited from another >>>> table, if a new primary key is added manually there, the create sql will >>>> not have an entry for primary key >>>> >>>> Fixed >>> >>>> >>>> - In table creation dialog, if primary key check box is checked >>>> while adding the row, a new row is added in primary key datagrid but >>>> unchecking the primary key checkbox from column datagrid, does not removes >>>> that row from primary key data grid. >>>> >>>> Fixed. >>> >>>> >>>> - In AutoVacuum tab, if user provides any invalid value to any >>>> parameter, then a error message should be prompted, only background color >>>> change would not tell user to change the value. >>>> >>>> Expected behaviour. >>> >>>> >>>> - In table creation dialog, security label are not being added. >>>> javascript error is coming as mentioned below: >>>> {"success": 0, "info": "", "result": null, "data": null, >>>> "errormsg": "can't adapt type 'Undefined'"} >>>> >>>> Fixed >>> >>>> >>>> - In Table creation dialog, while adding foreign key, in action >>>> tab. if user click on 'x' button in "on update" or "on delete" select2 >>>> control, it gives error "Uncaught SyntaxError: Unexpected end of input" >>>> >>>> Fixed >>> >>>> >>>> - In Table creation dialog, while adding a check constraint, >>>> "validated" button does not work properly >>>> >>>> Fixed. >>> >>>> >>>> - After successfully creation of table, "table name cannot be >>>> empty" error is not getting cleared. >>>> >>>> Not reproducible. >>> >>>> >>>> - In Table creation dialog, if user has added an empty column >>>> without entering its name or type and trying to add check constraint, it >>>> will add an empty constraint >>>> >>>> Expected behaviour (Columns are not mandatory for check constrains) >>> >>>> >>>> - In Table creation dialog, while adding an exclude constraint, for >>>> "character varying" column type, no operators are being listed >>>> >>>> There are no operators for character varying data type. >>> >>>> >>>> - In Table creation dialog, while adding an exclude constraint, >>>> below mentioned error comes if user removes operator class by clicking 'x' >>>> on that control Uncaught TypeError: Cannot read property 'id' of undefined >>>> >>>> TODO >>> >>>> >>>> - In Table creation dialog, SQL is not getting generated for >>>> exclude constraint >>>> >>>> Fixed >>> >>>> >>>> - In Table creation dialog, schema should be prefixed with table >>>> name in "of type" control >>>> >>>> Fixed >>> >>>> >>>> - In Table creation dialog, while adding privileges, it always >>>> shows default privileges even if user has selected different privileges. >>>> (This works fine once user edit the privileges in edit table mode and shows >>>> only those privileges which user selects). Ashesh, please confirm the >>>> behaviour. >>>> >>>> Privileges are set correctly. Only it shows in incorrect order. >>> >>> >>>> Table edit mode: >>>> >>>> - If in edit mode, any constraint is already having any comment, >>>> then remove it. It will not create the SQL for the same. >>>> >>>> >>> Fixed >>> >>>> >>>> - Changing Schema will give server error >>>> >>>> This is generic issue for each node. >>> >>> >>>> Column Creation: >>>> >>>> - Save button is enabled by default >>>> - Data type validation is not provided. Save button is enabled just >>>> after providing column name >>>> - Length field limitation is not provided. (i.e. for numeric type, >>>> length should be allowed greater than 1000) >>>> >>>> *Fixed* >> >>> Exclusion constraint creation: >>>> >>>> - Access method should not be allowed to be empty. (currently by >>>> clicking 'x' will remove the selection in it) >>>> >>>> Access method is optional. >>> >>> >>>> Index creation: >>>> >>>> - No error message for name field when empty >>>> - No error message when column name is not provided while adding a >>>> column in index >>>> - While adding a column if no name is provided, "None" appears in >>>> SQL tab which will give error on OK button click >>>> - when comment is provided while creation, it gives error saying >>>> index does not exists. because schema name is not added before it. >>>> >>>> *Fixed* >> >>> Rule creation: >>>> >>>> - Name is empty error does not come till user enters something in >>>> definition tab >>>> - DO INSTEAD button does not make any difference to SQL (it works >>>> in edit mode) >>>> >>>> *Surinder will send patch* >> >>> Rule edit mode: >>>> >>>> - Add comment in edit mode, check the SQL in sql tab. Now come back >>>> to general tab and removes comment and check the sql tab again. >>>> SQL for comment is still there with empty string as comment >>>> >>>> *Surinder will send patch* >> >>> Trigger Creation: >>>> >>>> - SQL is not proper when creating a trigger. "()" should be >>>> appended to function name in SQL. >>>> It gives error while creating a trigger >>>> - "+" sign is visible in browser tree in front of trigger. either >>>> On expanding trigger, it should show the trigger function name or that "+" >>>> sign should not appear >>>> >>>> *Fixed* >> >>> Trigger edit node: >>>> >>> >>>> - On removing comment, nothing happens. No sql is being created. >>>> Comment is still there in properties. >>>> >>>> *Fixed* >> >>> >>>> Regards, >>>> Sanket Mehta >>>> Sr Software engineer >>>> Enterprisedb >>>> >>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > --001a1138ee4e5004d805331bf27b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA table add-on= patch version 8.4. (apply after 8.3)
= This includes changes for trigger node issues.


=
--Regards,
Murtuza Zabuawala
EnterpriseDB:=C2= =A0http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

On Wed, May 18, 2016 at 4:19 PM, Murtuza Zab= uawala <murtuza.zabuawala@enterprisedb.com>= wrote:
Hi,

PFA table add-on patch version 8.3. (apply after = 8.2)


--
Regards,=
Murtuza Zabuawala
<= span style=3D"color:rgb(136,136,136)">EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise Postg= reSQL Company

On Wed, May 18, 2016 at 3:20 PM, Murtuza Zab= uawala <murtuza.zabuawala@enterprisedb.com>= wrote:
Hi,

PFA table add-on patch version 8.2
<= br clear=3D"all">
--
<= span style=3D"color:rgb(136,136,136)">Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The = Enterprise PostgreSQL Company

On Wed, May 18, 2016 at 2:42 PM, Harshal Dhu= mal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA patch for tab= le node (version 8.1). apply this patch on version 7 patch. Not all issue a= re fixed in this patch. Murtuza will be sending version 8.2 witch will have= resolution for remaining issues. Apply version 8.2 patch on version 8.1
--=C2=A0
Harshal Dhumal
Software Engineer=C2=A0



On Tue, May 17, 2016 at 10:12 PM, Sanket Meh= ta <sanket.mehta@enterprisedb.com> wrote:
Hi Harshal,


Below are my review comments:

=C2=A0I got below = warning when I tried to apply the patch for table node as mentioned below:<= /div>

Table creation:
  • =C2=A0Trail= ing white spaces warnings=C2=A0
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $ git apply /projects/patc= hes/pgadmin4/Table/table_14_May_V6.patch
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /projects/patches/pgadmin4/Ta= ble/table_14_May_V6.patch:6008: trailing whitespace.
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 return false;=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/projects/patches/pgadmin4/Tab= le/table_14_May_V6.patch:6016: trailing whitespace.
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 return false;=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0warning: 2 lines add whitespace e= rrors.

Fixed (These were introduced = due to rules node.)
=C2=A0
  • In Table creation dialog, while adding a new primary key,= it does not allow to change the tablespace to empty. (which is not the cas= e in case of tablespace in table)
Fi= xed=C2=A0
  • In Table crea= tion dialog, while adding a new column, data type and name field must be ma= ndatory. otherwise while clicking on save it gives below error
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 File= "/projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databas= es/schemas/tables/__init__.py", line 1319, in _parse_format_columns
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0c['cltype'] =3D self._cltype_formatter(c['cltype'])
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= KeyError: 'cltype
Fixed
=C2= =A0
  • In Table creation d= ialog, While adding a new column, in primary check box is needed to click t= wice in order to check it. Ideally it should be checked by only one click.<= br>
This is Backgrid behaviour.
  • In Table creation dialog, W= hile adding a new column, primary key should not be allowed to added unless= user has provided name and data type for at least one column.
=C2=A0Fixed
  • currently if user has clicked on add column button = and immediately click on add primary key button, it will add a row in prima= ry key data grid
Fixed=C2=A0
  • When delete table/drop cas= cade is apply on any table, i got a javascript error as mentioned below
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0no= de.js:94 Uncaught TypeError: self.canDrop.apply is not a function
Already fixed in other commit.
=C2=A0
  • Once the above error gen= erated, every time user tries to open a context menu by right clicking on a= ny existing table, that same error comes=C2=A0
Already fixed in other commit.
  • In table creation dialog, if table is inherited from ano= ther table, if a new primary key is added manually there, the create sql wi= ll not have an entry for primary key
Fixed=C2=A0
  • In table c= reation dialog, if primary key check box is checked while adding the row, a= new row is added in primary key datagrid but unchecking the primary key ch= eckbox from column datagrid, does not removes that row from primary key dat= a grid.
Fixed.=C2=A0
  • In AutoVacuum tab, if user provide= s any invalid value to any parameter, then a error message should be prompt= ed, only background color change would not tell user to change the value.
Expected =C2=A0behaviour.
  • In table creation dialog, security= label are not being added. javascript error is coming as mentioned below:<= br>=C2=A0=C2=A0{"= ;success": 0, "info": "", "result": null= , "data": null, "errormsg": "can't adapt type = 'Undefined'"}
= =C2=A0Fixed
  • In Table creation dialog,= while adding foreign key, in action tab. if user click on 'x' but= ton in "on update" or "on delete" select2 control, it g= ives error "Uncaught SyntaxError: Unexpected end of input"=
Fixed
  • In Table creation dialog, while adding a check constra= int, "validated" button does not work properly
    • =
Fixed.=C2=A0
  • After successfully creation of table, "table name cannot be= empty" error is not getting cleared.
Not reproducible.=C2=A0
  • In Table creation dialog, if user has added an empty column wit= hout entering its name or type and trying to add check constraint, it will = add an empty constraint
=C2=A0Expected =C2=A0behaviour (Columns are not mandatory for check const= rains)
  • In Table creation dialog, whil= e adding an exclude constraint, for "character varying" column ty= pe, no operators are being listed
=C2=A0There are no operators for=C2=A0character varying data type.
  • In Table creation dialog, while adding an exclu= de constraint, below mentioned error comes if user removes operator class b= y clicking 'x' on that control Uncaught TypeError: Cannot read property 'id' of unde= fined
=C2=A0TODO
=
  • In Table creation dialog, SQL is not getti= ng generated for exclude constraint
Fixed
  • In Table creation= dialog, schema should be prefixed with table name in "of type" c= ontrol
=C2=A0Fixed
  • In Table creation dialog, while adding p= rivileges, it always shows default privileges even if user has selected dif= ferent privileges. (This works fine once user edit the privileges in edit t= able mode and shows only those privileges which user selects).=20 Ashesh, please confirm the behaviour.
= Privileges are set correctly. Only it shows in incorrect order.
<= /div>
=C2=A0
Table edit mode:=
  • If in edit mode, any constraint is already having any comment, = then remove it. It will not create the SQL for the same.
    • =

Fixed=C2=A0
  • <= span style=3D"white-space:pre-wrap">Changing Schema will give server error<= /span>
This is generic = issue for each node.
=C2=A0
Co= lumn Creation:
  • Save button is enabled by default
  • = Data type validation is not provided. Save button is enabled just after pro= viding column name
  • Length field limitation is not provided. (i.e. f= or numeric type, length should be allowed greater than 1000)<= /li>
=
=
Fixed=C2=A0
Exclusion constraint creation:
  • = Access method should not be allowed to be empty. (currently by clicking = 9;x' will remove the selection in it)
Access method is optional.
=C2=A0
Index creation:
  • No error message for name field when empty
  • No error message wh= en column name is not provided while adding a column in index
  • While= adding a column if no name is provided, "None" appears in SQL ta= b which will give error on OK button click
  • when comment is provided= while creation, it gives error saying index does not exists. because schem= a name is not added before it.
    • Fixed=C2=A0
    Rule crea= tion:
    • Name is empty error does not come till = user enters something in definition tab
    • DO INSTEAD button does not = make any difference to SQL (it works in edit mode)
    Surinder = will send patch=C2=A0
    Rule edit mode:
    • Add comment in e= dit mode, check the SQL in sql tab. Now come back to general tab and remove= s comment and check the sql tab again.
      SQL for comment is still there wi= th empty string as comment
    Surinder will send patch=C2= =A0
    =
    Trig= ger Creation:
    • SQL is not proper when creating a tri= gger. "()" should be appended to function name in SQL.
      It give= s error while creating a trigger
    • "+" sign is visible in b= rowser tree in front of trigger. =C2=A0either On expanding trigger, it shou= ld show the trigger function name or that "+" sign should not app= ear
    Fixed=C2=A0
    <= div>
    =
    Trigger edit node:
    • On removing comment, nothin= g happens. No sql is being created. Comment is still there in properties.= =C2=A0
    Fixed=C2=A0

    Regards,
    Sank= et Mehta
    Sr Software engineer
    Enterprisedb
    <= /div>



    --
    Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
    To make changes to your subscription:
    http://www.postgresql.org/mailpref/pgadmin-hackers=

    <= font color=3D"#888888">


    --001a1138ee4e5004d805331bf27b-- --001a1138ee4e5004db05331bf27d Content-Type: application/octet-stream; name="table_v8.4.patch" Content-Disposition: attachment; filename="table_v8.4.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iocrrz2g1 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMv dHJpZ2dlci9zcWwvOS4xX3BsdXMvY3JlYXRlLnNxbCBiL3dlYi9wZ2FkbWlu L2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hl bWFzL3RhYmxlcy90ZW1wbGF0ZXMvdHJpZ2dlci9zcWwvOS4xX3BsdXMvY3Jl YXRlLnNxbAppbmRleCBiOGJjYmZjLi5iNjE5ZjcxIDEwMDY0NAotLS0gYS93 ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRh YmFzZXMvc2NoZW1hcy90YWJsZXMvdGVtcGxhdGVzL3RyaWdnZXIvc3FsLzku MV9wbHVzL2NyZWF0ZS5zcWwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVz L3RlbXBsYXRlcy90cmlnZ2VyL3NxbC85LjFfcGx1cy9jcmVhdGUuc3FsCkBA IC0xOSw3ICsxOSw3IEBAIENSRUFURXslIGlmIGRhdGEuaXNfY29uc3RyYWlu dF90cmlnZ2VyICV9IENPTlNUUkFJTlR7JSBlbmRpZiAlfSBUUklHR0VSIHt7 IGNvbm58CiAKICAgICBXSEVOIHt7IGRhdGEud2hlbmNsYXVzZSB9fXslIGVu ZGlmICV9CiAKLSAgICB7JSBpZiBkYXRhLmNvZGUgJX17eyBkYXRhLmNvZGUg fX17JSBlbHNlICV9RVhFQ1VURSBQUk9DRURVUkUge3sgZGF0YS50ZnVuY3Rp b24gfX17JSBpZiBkYXRhLnRnYXJncyAlfSh7eyBkYXRhLnRnYXJncyB9fSl7 JSBlbmRpZiV9eyUgZW5kaWYlfTsKKyAgICB7JSBpZiBkYXRhLmNvZGUgJX17 eyBkYXRhLmNvZGUgfX17JSBlbHNlICV9RVhFQ1VURSBQUk9DRURVUkUge3sg ZGF0YS50ZnVuY3Rpb24gfX17JSBpZiBkYXRhLnRnYXJncyAlfSh7eyBkYXRh LnRnYXJncyB9fSl7JSBlbHNlICV9KCl7JSBlbmRpZiV9eyUgZW5kaWYlfTsK IAogeyUgaWYgZGF0YS5kZXNjcmlwdGlvbiAlfQogQ09NTUVOVCBPTiBUUklH R0VSIHt7IGNvbm58cXRJZGVudChkYXRhLm5hbWUpIH19IE9OIHt7IGNvbm58 cXRJZGVudChkYXRhLnNjaGVtYSwgZGF0YS50YWJsZSkgfX0KZGlmZiAtLWdp dCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJz L2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZW1wbGF0ZXMvdHJpZ2dlci9z cWwvOS4xX3BsdXMvdXBkYXRlLnNxbCBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIv c2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxl cy90ZW1wbGF0ZXMvdHJpZ2dlci9zcWwvOS4xX3BsdXMvdXBkYXRlLnNxbApp bmRleCBmMTg3YTU1Li5mYTY0ODA5IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1p bi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2No ZW1hcy90YWJsZXMvdGVtcGxhdGVzL3RyaWdnZXIvc3FsLzkuMV9wbHVzL3Vw ZGF0ZS5zcWwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3Jv dXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3RlbXBsYXRl cy90cmlnZ2VyL3NxbC85LjFfcGx1cy91cGRhdGUuc3FsCkBAIC0yLDcgKzIs NyBAQAogQUxURVIgVFJJR0dFUiB7eyBjb25ufHF0SWRlbnQob19kYXRhLm5h bWUpIH19IE9OIHt7IGNvbm58cXRJZGVudChvX2RhdGEubnNwbmFtZSwgb19k YXRhLnJlbG5hbWUpIH19CiAgICAgUkVOQU1FIFRPIHt7IGNvbm58cXRJZGVu dChkYXRhLm5hbWUpIH19OwogeyUgZW5kaWYgJX0KLXslIGlmIGRhdGEuZGVz Y3JpcHRpb24gYW5kIG9fZGF0YS5kZXNjcmlwdGlvbiAhPSBkYXRhLmRlc2Ny aXB0aW9uICV9Cit7JSBpZiBkYXRhLmRlc2NyaXB0aW9uIGlzIGRlZmluZWQg IGFuZCBvX2RhdGEuZGVzY3JpcHRpb24gIT0gZGF0YS5kZXNjcmlwdGlvbiAl fQogQ09NTUVOVCBPTiBUUklHR0VSIHt7IGNvbm58cXRJZGVudChkYXRhLm5h bWUpIH19IE9OIHt7IGNvbm58cXRJZGVudChvX2RhdGEubnNwbmFtZSwgb19k YXRhLnJlbG5hbWUpIH19CiAgICAgSVMge3tkYXRhLmRlc2NyaXB0aW9ufHF0 TGl0ZXJhbH19OwogeyUgZW5kaWYgJX0KXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCg== --001a1138ee4e5004db05331bf27d Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1138ee4e5004db05331bf27d--