Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYVnk-00023U-Pt for pgadmin-hackers@arkaria.postgresql.org; Tue, 31 Jan 2017 10:36:40 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cYVnk-0002tx-4D for pgadmin-hackers@arkaria.postgresql.org; Tue, 31 Jan 2017 10:36:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cYVni-0002tC-O0 for pgadmin-hackers@postgresql.org; Tue, 31 Jan 2017 10:36:38 +0000 Received: from mail-oi0-x22d.google.com ([2607:f8b0:4003:c06::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cYVnb-000883-LZ for pgadmin-hackers@postgresql.org; Tue, 31 Jan 2017 10:36:38 +0000 Received: by mail-oi0-x22d.google.com with SMTP id u143so211545122oif.3 for ; Tue, 31 Jan 2017 02:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vSx+oGKWzkdIOcZQTePKKOdDuEF15VFUJsZOsODYcqw=; b=UFqiKySnmp7zvkdW+tEJWfDCFeMJGiwGjgBzJH7b9RMilp7xmbrEfX5Abgu45RnnAR ozPcv687/ypeIfdxrVFgY2RCY0JdvYKgpvwXQTgxNKWT5TWCG0OVsKKTYPsYELvsFKhY K5Tnj1LBFSxi+vzvT22+8uZYZc4nwF2wwlLKFYXhZEJSM+RGQDKPiiycMLT8KfoXPAec zkQgvkq6IEJYBuDFdtWw2n3mEasPYSbwckBjuympqFxpiLL3+0mbDYTnDZQlQwkyM4TB IlXec93ndiryXkyGD+LS+5rwDj7t2w17kmgUgAiMPyWYPXlUaN+CKslo0YIFzJIk5fYw 0BwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vSx+oGKWzkdIOcZQTePKKOdDuEF15VFUJsZOsODYcqw=; b=JOBzoL1exsbaaLukkz20BuZWARuhi324atu7A7yHGpj3IdWZp/1NdM+bfKSLlJeqEy P3ySsV4FDtUjEt5IOc0kp5tLDQ+Dlw9UMz99/k5QiDWMiy65b2cpD+9MM89h1C6fqq0X j/e9sDAhfl6J+O3PyQ+hBcHV0CY4OUzjOQlYwqQ7kUMMaLZnzYcFa4oDqRtEULZNpvTD A7Y3KHBsbihYcF/HMV2Gn0d58gqPBOdFmnPtShCLaVLfPdNRfsEtE5MGhjv47Gul0mJh ytsh7JDQox5/oVgzBqlecA4MjQmvAzv91QCzdgZl//TqUHIzx7LtdjTtFFO4LWN5MpwE ud4Q== X-Gm-Message-State: AIkVDXI8Za9xs8r53AeF0JFDv77JTkOeTGBo3qNuKlfsg05lVS7/9gKRj+LeQyKpeocruB9Yz4Ks20UMbwo0z6Jc X-Received: by 10.202.63.85 with SMTP id m82mr15092919oia.151.1485858989476; Tue, 31 Jan 2017 02:36:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.183.26.2 with HTTP; Tue, 31 Jan 2017 02:36:08 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Tue, 31 Jan 2017 16:06:08 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] Minor fix in test file for the Template loader To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113dd4924120d7054761813e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113dd4924120d7054761813e Content-Type: text/plain; charset=UTF-8 Hi Dave, Even I tested against Python3.5 but did not receive any such error and I tried again after your mail but still did not receive error. murtuza@vm:~/pgadmin4/web/regression$ python3 --version Python 3.5.0 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 31, 2017 at 3:34 PM, Dave Page wrote: > Thanks Murtuza. When you get a minute, can you also look at the > following issue I get with the tests under Python 3.5? It doesn't seem > to stop them working. > > Traceback (most recent call last): > File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/route.py", line > 75, in load_generators > import_module(module_name) > File "/Users/dpage/.virtualenvs/pgadmin4-py35/lib/python3.5/ > importlib/__init__.py", > line 126, in import_module > return _bootstrap._gcd_import(name[level:], package, level) > File "", line 986, in _gcd_import > File "", line 969, in _find_and_load > File "", line 958, in > _find_and_load_unlocked > File "", line 673, in _load_unlocked > File "", line 673, in exec_module > File "", line 222, in > _call_with_frames_removed > File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/ > sqlautocomplete/counter.py", > line 6, in > from itertools import repeat, ifilter > ImportError: cannot import name 'ifilter' > > > On Tue, Jan 31, 2017 at 5:25 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to fix the issue in test suite for template loader. > > > > Issue(Python3): > > murtuza@vm:~/pgadmin4/web/regression$ python3 runtests.py > > pgAdmin 4 - Application Initialisation > > ====================================== > > > > > > The configuration database - '/../.pgadmin/test_pgadmin4.db' does not > exist. > > Entering initial setup mode... > > NOTE: Configuring authentication for SERVER mode. > > > > > > The configuration database has been created at > /../.pgadmin/test_pgadmin4.db > > Traceback (most recent call last): > > File "runtests.py", line 250, in > > test_module_list = get_test_modules(args) > > File "runtests.py", line 138, in get_test_modules > > TestsGeneratorRegistry.load_generators('pgadmin') > > File "../../pgadmin4/web/pgadmin/utils/route.py", line 66, in > > load_generators > > import_module(module_name) > > File "/../../3.5/lib/python3.5/importlib/__init__.py", line 126, in > > import_module > > return _bootstrap._gcd_import(name[level:], package, level) > > File "", line 986, in _gcd_import > > File "", line 969, in _find_and_load > > File "", line 958, in > _find_and_load_unlocked > > File "", line 673, in _load_unlocked > > File "", line 658, in > exec_module > > File "", line 764, in get_code > > File "", line 724, in > source_to_code > > File "", line 222, in > > _call_with_frames_removed > > File > > "/../../pgadmin4/web/pgadmin/utils/tests/test_versioned_ > template_loader.py", > > line 50 > > except TemplateNotFound, e: > > ^ > > SyntaxError: invalid syntax > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113dd4924120d7054761813e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Dave,

Even I tested against Python3.5 but did not receive any such = error and I tried again after your mail but still did not receive error.=C2= =A0

murtuza@vm:~/pgadmin4/web/regression$ pytho= n3 --version

Python 3.5.0

<= /div>

--=
Regards,
Murtuza ZabuawalaE= nterpriseDB:=C2=A0http://www.enter= prisedb.com
The Enterprise PostgreSQL Company

On Tue, Jan 31, 2017 at 3:34 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Thanks Murtuza. When you get a minute, can you also look at the
following issue I get with the tests under Python 3.5? It doesn't seem<= br> to stop them working.

Traceback (most recent call last):
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/route.py= ", line
75, in load_generators
=C2=A0 =C2=A0 import_module(module_name)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4-py35/lib/python3.= 5/importlib/__init__.py",
line 126, in import_module
=C2=A0 =C2=A0 return _bootstrap._gcd_import(name[level:], package, lev= el)
=C2=A0 File "<frozen importlib._bootstrap>", line 986, in _= gcd_import
=C2=A0 File "<frozen importlib._bootstrap>", line 969, in _= find_and_load
=C2=A0 File "<frozen importlib._bootstrap>", line 958, in _= find_and_load_unlocked
=C2=A0 File "<frozen importlib._bootstrap>", line 673, in _= load_unlocked
=C2=A0 File "<frozen importlib._bootstrap_external>", = line 673, in exec_module
=C2=A0 File "<frozen importlib._bootstrap>", line 222, in _= call_with_frames_removed
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/sql= autocomplete/counter.py",
line 6, in <module>
=C2=A0 =C2=A0 from itertools import repeat, ifilter
ImportError: cannot import name 'ifilter'


On Tue, Jan 31, 2017 at 5:25 AM, Murtuza Zabuawala
<murtuza.zabuawala= @enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in test suite for template loader.
>
> Issue(Python3):
> murtuza@vm:~/pgadmin4/web/regression$ python3 runtests.py
> pgAdmin 4 - Application Initialisation
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
>
> The configuration database - '/../.pgadmin/test_pgadmin4.db&#= 39; does not exist.
> Entering initial setup mode...
> NOTE: Configuring authentication for SERVER mode.
>
>
> The configuration database has been created at /../.pgadmin/test_pgadm= in4.db
> Traceback (most recent call last):
>=C2=A0 =C2=A0File "runtests.py", line 250, in <module><= br> >=C2=A0 =C2=A0 =C2=A0test_module_list =3D get_test_modules(args)
>=C2=A0 =C2=A0File "runtests.py", line 138, in get_test_module= s
>=C2=A0 =C2=A0 =C2=A0TestsGeneratorRegistry.load_generators('pg= admin')
>=C2=A0 =C2=A0File "../../pgadmin4/web/pgadmin/utils/route.py&= quot;, line 66, in
> load_generators
>=C2=A0 =C2=A0 =C2=A0import_module(module_name)
>=C2=A0 =C2=A0File "/../../3.5/lib/python3.5/importlib/__init_= _.py", line 126, in
> import_module
>=C2=A0 =C2=A0 =C2=A0return _bootstrap._gcd_import(name[level:], pa= ckage, level)
>=C2=A0 =C2=A0File "<frozen importlib._bootstrap>", line= 986, in _gcd_import
>=C2=A0 =C2=A0File "<frozen importlib._bootstrap>", line= 969, in _find_and_load
>=C2=A0 =C2=A0File "<frozen importlib._bootstrap>", line= 958, in _find_and_load_unlocked
>=C2=A0 =C2=A0File "<frozen importlib._bootstrap>", line= 673, in _load_unlocked
>=C2=A0 =C2=A0File "<frozen importlib._bootstrap_external>", line 658, in exec_module
>=C2=A0 =C2=A0File "<frozen importlib._bootstrap_external>", line 764, in get_code
>=C2=A0 =C2=A0File "<frozen importlib._bootstrap_external>", line 724, in source_to_code
>=C2=A0 =C2=A0File "<frozen importlib._bootstrap>", line= 222, in
> _call_with_frames_removed
>=C2=A0 =C2=A0File
> "/../../pgadmin4/web/pgadmin/utils/tests/test_versioned_template_loader.py",
> line 50
>=C2=A0 =C2=A0 =C2=A0except TemplateNotFound, e:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
> SyntaxError: invalid syntax
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113dd4924120d7054761813e--