Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP28i-0007CG-8Q for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jul 2016 06:34:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bP28h-0005Sk-Rg for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jul 2016 06:34:51 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bP28U-0005Ea-TE for pgadmin-hackers@postgresql.org; Mon, 18 Jul 2016 06:34:39 +0000 Received: from mail-qk0-x229.google.com ([2607:f8b0:400d:c09::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bP28R-0004Om-4M for pgadmin-hackers@postgresql.org; Mon, 18 Jul 2016 06:34:37 +0000 Received: by mail-qk0-x229.google.com with SMTP id s63so148980649qkb.2 for ; Sun, 17 Jul 2016 23:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sFTzCw0UXxP0vLJmn5lJ3qiCWktdhEQ9m+I8AVnztOQ=; b=Yn1EdqJwjZhE1xE+zThM23vjoF+c3QvMF4n6em1B6Z0Rm97XXb2jdzNmaoMP3NAlJC fwV5PoJEvewE0RUu2/GdCCvreeAkROlMOVTwRA6sIkp1MAdmEUSyRPfhbQkNNd8fcaRO D4nTUlYyLYK82cpwnf4Zul5ik2qxT/VX+vfwV3oqgeCmkymXatY65jM3ccDslGffglaO 4Np4dYdR9U0zbhzvmNtpQHB75/hxWS2kB/JEGE+RYQHEFoTs+aNTRHU0SpP49+mqysuT FauNSbXeIqk8bCHt1KHfpkdkOVTHetobLEw99TVysU+8m7MBbAc5U8MpsKG1pUy6emBD 4XFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sFTzCw0UXxP0vLJmn5lJ3qiCWktdhEQ9m+I8AVnztOQ=; b=fE5L0qqO+jOIVp1nPAz2GhK8pk/8/u0RPQ2OHRY345TBqmabEJdJAq9fk3bDb+VWAa j0u6tsAg9VEwjZfJ95r21MKDA0lkRYGCALZ3WO6VaH6kWrQgdiEgZUOQnN2Fuvr6G8jA K46+gbL2jgl8yCVwZIqXmSTHp4SBJn3fIzd/cTZzhXWUCfRGu5kVsPn+qVK3FOrFqB3M A7cuZg5SQ3Xb5JRYZpoOEKwt9TnExw7dAf8xx85nqRyC/VGg/uaV4mlPQhMU7333w2W5 QsqU/sKf9umxfKxQc+u/Vzp3XZqgLWgZtdPdSgVGcl60Z8eAv4Gzlb2Il4FbYSR1HzCW SqvQ== X-Gm-Message-State: ALyK8tLXjMuCTkX/jtLfupZuVC9hdhqcrwLNXcqITIuHQCrjgzfzuR7oKkG+YHjJPWMvh8K6+N7HwNfxd7Giocqu X-Received: by 10.55.159.87 with SMTP id i84mr43933221qke.115.1468823673827; Sun, 17 Jul 2016 23:34:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.8.3 with HTTP; Sun, 17 Jul 2016 23:34:14 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 18 Jul 2016 12:04:14 +0530 Message-ID: Subject: Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114d31b051701d0537e32925 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114d31b051701d0537e32925 Content-Type: multipart/alternative; boundary=001a114d31b051701a0537e32923 --001a114d31b051701a0537e32923 Content-Type: text/plain; charset=UTF-8 Hi Dave, Please find patch to fix the issue for interval type casting. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 15, 2016 at 4:31 PM, Dave Page wrote: > Hi > > On Thu, Jul 14, 2016 at 7:00 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to fix the issue in timestamp datatype(s) displaying with time > as > > 00:00 > > (RM#1437) > > > > The issue was with backgrid datetime cell which do not fully support > > ISO-8601 datetime format. > > Thanks - this worked, except for the 'interval' type, I've committed > the patch without that change; please submit another fixing that > remaining issue. > > e.g. select '1 month'::interval > > displays: 00:00:00 > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114d31b051701a0537e32923 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

Please find patch to fix the i= ssue for interval type casting.


Reg= ards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Comp= any

On Fri, Jul 15, 2016 at 4:31 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Hi

On Thu, Jul 14, 2016 at 7:00 AM, Murtuza Zabuawala
<murtuza.zabuawala= @enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in timestamp datatype(s) displaying with ti= me as
> 00:00
> (RM#1437)
>
> The issue was with backgrid datetime cell which do not fully support > ISO-8601 datetime format.

Thanks - this worked, except for the 'interval' type, I've comm= itted
the patch without that change; please submit another fixing that
remaining issue.

e.g. select '1 month'::interval

displays: 00:00:00

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114d31b051701a0537e32923-- --001a114d31b051701d0537e32925 Content-Type: application/octet-stream; name="add_support_for_interval.patch" Content-Disposition: attachment; filename="add_support_for_interval.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iqrnnk370 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3V0aWxzL2RyaXZlci9wc3ljb3Bn Mi9fX2luaXRfXy5weSBiL3dlYi9wZ2FkbWluL3V0aWxzL2RyaXZlci9wc3lj b3BnMi9fX2luaXRfXy5weQppbmRleCA3NTFkZDBjLi5lYzBhOGZjIDEwMDY0 NAotLS0gYS93ZWIvcGdhZG1pbi91dGlscy9kcml2ZXIvcHN5Y29wZzIvX19p bml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vdXRpbHMvZHJpdmVyL3BzeWNv cGcyL19faW5pdF9fLnB5CkBAIC01Myw2ICs1MywxMSBAQCBwc3ljb3BnMi5l eHRlbnNpb25zLnJlZ2lzdGVyX3R5cGUoCiAgICAgcHN5Y29wZzIuZXh0ZW5z aW9ucy5uZXdfdHlwZSgoNzAxLCksICdOYU5fVEVYVCcsIHBzeWNvcGcyLlNU UklORykKICkKIAorIyBUaGlzIHJlZ2lzdGVycyBhIHR5cGUgY2FzdGVyIGZv ciBkYXRhdHlwZSAnaW50ZXJ2YWwnLgorcHN5Y29wZzIuZXh0ZW5zaW9ucy5y ZWdpc3Rlcl90eXBlKAorICAgIHBzeWNvcGcyLmV4dGVuc2lvbnMubmV3X3R5 cGUoKDExODYsKSwgJ0lOVEVSVkFMX1RFWFQnLCBwc3ljb3BnMi5TVFJJTkcp CispCisKIAogZGVmIHJlZ2lzdGVyX2RhdGVfdHlwZWNhc3RlcnMoY29ubmVj dGlvbik6CiAgICAgIiIiCg== --001a114d31b051701d0537e32925 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114d31b051701d0537e32925--