Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFE6a-0006FS-H4 for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 May 2017 06:24:40 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dFE6Z-0005lF-8Q for pgadmin-hackers@arkaria.postgresql.org; Mon, 29 May 2017 06:24:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dFE6K-0005LR-9H for pgadmin-hackers@postgresql.org; Mon, 29 May 2017 06:24:24 +0000 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dFE6F-00073i-9n for pgadmin-hackers@postgresql.org; Mon, 29 May 2017 06:24:23 +0000 Received: by mail-wm0-x233.google.com with SMTP id b84so42297204wmh.0 for ; Sun, 28 May 2017 23:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/DAmlMLbZf51lTLIQKuOCoQXBjbpelLxxMPvvc6ubvI=; b=Vu1xJAC/ZzepRGSFVrXT0djtE/EtUpNdxuHTZS/EGGLpwu5NFlw/1no5XiLfwNAy0K Fk7S2hzWuptJl5B7tCqT+Yysr5nKLwFmvq+bAstVNH7QgN74f13911naJsqGQQiERr/p QSskLgKCHb3pzwprbbv/nA41jQsy+mrf4D7QFrctqaspGS4G8C6XB3lWM3pm8bZRdBcL 8oWnYt934smm9OAsJWMyXKjX2uKR+29yGMYE+54jMUYgspvvOwHMqna14//7RJzgIxgc xZPnMW4vrJNCeboDYstTvPLi1yYxRD782mOzBgz++Qu8QfzQOEC/LeGTpCCDI6v4FGX3 0Ilg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/DAmlMLbZf51lTLIQKuOCoQXBjbpelLxxMPvvc6ubvI=; b=Sqv6190bDosucFUWdVCGtXEsGLTMUnaZiMCo5Tp9sohjoMa6VAYzWL2u6InryLWhCw dFu6QSBFjrlMiHKFpWZS7Vqmc5EBGF7JRXrZ7HDcb+a7aHpXhfEbtz+bmQCq7kHqY2K9 C/oJBREF1dG/YJEpTmHLeAjzfiTJMq1wzy5HprZUv1SqnE2hhVS0znOmQzPsceAIS6Mo 29Nz+nWlSk4fbHMA5RR35a9OA4uW+lQ3pTfozyiXyuowyGDe2GGahbSVWDz0gYsKiDI0 nNVfIjhgqYSJkZXE59V3Q/jeak2Gyf3IddgDIvMvvZQAo9ByWf027WtXpNAwMDACEHp4 UrNg== X-Gm-Message-State: AODbwcD6MFtxIIb2JNoYH+Vl9soKsfUjFNSjHiwJnjvmubz4Kxr8yOfs o96fjJ+1bF2+5yfVo2kG7foc9nWOZuwCtOY= X-Received: by 10.28.157.14 with SMTP id g14mr21574765wme.114.1496039057676; Sun, 28 May 2017 23:24:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.161.199 with HTTP; Sun, 28 May 2017 23:23:57 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 29 May 2017 11:53:57 +0530 Message-ID: Subject: Re: feature test timeouts To: Dave Page Cc: George Gelashvili , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114b9f329a75d10550a3bcfa" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114b9f329a75d10550a3bcfa Content-Type: text/plain; charset="UTF-8" Hi Dave, With latest pull, PG data-type test fails on my system, ====================================================================== ERROR: runTest (pgadmin.feature_tests.pg_datatype_validation_test. PGDataypeFeatureTest) Test checks for PG data-types output ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/ feature_tests/pg_datatype_validation_test.py", line 44, in runTest self._check_datatype() File "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/ feature_tests/pg_datatype_validation_test.py", line 97, in _check_datatype self.page.fill_codemirror_area_with(query) File "/Users/edb/Documents/projects/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 122, in fill_codemirror_area_with "//pre[contains(@class,'CodeMirror-line')]/../../../*[ contains(@class,'CodeMirror-code')]").click() File "/Users/edb/Documents/projects/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 87, in find_by_xpath return self.wait_for_element(lambda driver: driver.find_element_by_xpath(xpath)) File "/Users/edb/Documents/projects/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 152, in wait_for_element return self._wait_for("element to exist", element_if_it_exists) File "/Users/edb/Documents/projects/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 188, in _wait_for "Timed out waiting for " + waiting_for_message) File "/Users/edb/Documents/projects/venv_pg4/lib/python3. 5/site-packages/selenium/webdriver/support/wait.py", line 80, in until raise TimeoutException(message, screen, stacktrace) selenium.common.exceptions.TimeoutException: Message: Timed out waiting for element to exist ---------------------------------------------------------------------- Ran 6 tests in 170.026s FAILED (errors=1) ====================================================================== Test Result Summary ====================================================================== PG_95: 5 tests passed 1 test failed: PGDataypeFeatureTest (Test checks for PG data-types output) 0 tests skipped ====================================================================== Please check output in file: /Users/edb/Documents/projects/ pgadmin4/web/regression/regression.log -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sat, May 27, 2017 at 11:47 PM, Dave Page wrote: > Thanks, patch applied. > > On Fri, May 26, 2017 at 6:26 PM, George Gelashvili > wrote: > > Hello Hackers, > > > > We are running tests including feature tests in Circle CI, and have been > > seeing some flakiness due to what we believe are insufficient wait-for > > timeouts. > > > > This shouldn't increase the overall test time, but only allow waiting > longer > > for an element to appear, if needed. > > > > We've also split out the app start timeout since that seemed to need more > > time on CI. > > > > Patch attached. > > > > Thanks! > > Joao, Matt, and George > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --001a114b9f329a75d10550a3bcfa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

With latest pull, PG data-type= test fails on my system,

=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
ERROR: runTest (pgadmin.feature_tests.pg_datatype= _validation_test.PGDataypeFeatureTest)
T= est checks for PG data-types output
---------= -------------------------------------------------------------
Traceback (most recent call last):
<= div style=3D"font-size:12.8px">=C2=A0 File "/Users/edb/Documents/projects/pgadm= in4/web/pgadmin/feature_tests/pg_datatype_validation_test.py"= ;, line 44, in runTest
=C2=A0 =C2=A0 self._ch= eck_datatype()
=C2=A0 File "/Users/edb/D= ocuments/projects/pgadmin4/web/pgadmin/feature_tests/pg_datatype_= validation_test.py", line 97, in _check_datatype
=C2=A0 =C2=A0 self.page.fill_codemirror_area_with(query)=
=C2=A0 File "/Users/edb/Documents/= projects/pgadmin4/web/regression/feature_utils/pgadmin_page.py&qu= ot;, line 122, in fill_codemirror_area_with
= =C2=A0 =C2=A0 "//pre[contains(@class,'CodeMirror-line')]/= ../../../*[contains(@class,'CodeMirror-code')]").cli= ck()
=C2=A0 File "/Users/edb/Documents/<= wbr>projects/pgadmin4/web/regression/feature_utils/pgadmin_page.p= y", line 87, in find_by_xpath
=C2=A0 =C2= =A0 return self.wait_for_element(lambda driver: driver.find_element_by_xpat= h(xpath))
=C2=A0 File "/Users/edb/D= ocuments/projects/pgadmin4/web/regression/feature_utils/pgad= min_page.py", line 152, in wait_for_element
=C2=A0 =C2=A0 return self._wait_for("element to exist", eleme= nt_if_it_exists)
=C2=A0 File "/Users/edb= /Documents/projects/pgadmin4/web/regression/feature_utils/pg= admin_page.py", line 188, in _wait_for
= =C2=A0 =C2=A0 "Timed out waiting for " + waiting_for_message)
=C2=A0 File "/Users/edb/Documents/proj= ects/venv_pg4/lib/python3.5/site-packages/selenium/webdriver/supp= ort/wait.py", line 80, in until
=C2=A0 = =C2=A0 raise TimeoutException(message, screen, stacktrace)
selenium.common.exceptions.TimeoutException: Message: Ti= med out waiting for element to exist


-------------= ---------------------------------------------------------<= /div>
Ran 6 tests in 170.026s

FAILED (errors=3D1)

=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Test Result Summary
=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

PG_95:

5 tests= passed
1 test f= ailed:
PGDatay= peFeatureTest (Test checks for PG data-types output)
0 tests skipped

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Please check output in file: /Users/edb/Doc= uments/projects/pgadmin4/web/regression/regression.log


<= div>
--
Regards,Mur= tuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
= The Enterprise PostgreSQL Company

On Sat, May 27, 2017 at 11:47 PM, Dave Page = <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Fri, May 26, 2017 at 6:26 PM, George Gelashvili
<ggelashvili@pivotal.io>= ; wrote:
> Hello Hackers,
>
> We are running tests including feature tests in Circle CI, and have be= en
> seeing some flakiness due to what we believe are insufficient wait-for=
> timeouts.
>
> This shouldn't increase the overall test time, but only allow wait= ing longer
> for an element to appear, if needed.
>
> We've also split out the app start timeout since that seemed to ne= ed more
> time on CI.
>
> Patch attached.
>
> Thanks!
> Joao, Matt, and George
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers

--001a114b9f329a75d10550a3bcfa--