Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aycmW-0005ov-Qq for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 May 2016 10:14:48 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aycmW-0003KZ-C7 for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 May 2016 10:14:48 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aycmI-0002v6-Up for pgadmin-hackers@postgresql.org; Fri, 06 May 2016 10:14:35 +0000 Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aycmG-0006hh-ID for pgadmin-hackers@postgresql.org; Fri, 06 May 2016 10:14:33 +0000 Received: by mail-qg0-x22e.google.com with SMTP id f92so53422115qgf.0 for ; Fri, 06 May 2016 03:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=K4cehaAzsDo9VXNLeqMRlBStWNHYixge1UUBHDxsNCs=; b=bEsdVdt6QQgGfQTALuRrm9ilyAGlnu52K9NC8VkGptMBjw23WzGaeo86NreOQvRdz/ tQU7YCMs6NX+66eqFFrumlsEWqEYmjBokKEjqDPJ0/15yuZ5XM17+2ZzECwsB5ofYaUG 81t07U4t55mhdxEdwei2Q9It5QafVWBAAVaxccTZd5lWRGqmYfbuivfkWuV3q2k4liZ2 DBrRd55XfpU3ms9je2/xMaGj/gXDC06adrsG8+65RUQ90ppIs0EpjFKI/hcC8V4j62By JUBeSmYOwe8KZmJbZzfhmurPtRa/juhidfRe835Q27nIWcZ7MFc74ZnCjbJRn1Xxgeeh ja5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=K4cehaAzsDo9VXNLeqMRlBStWNHYixge1UUBHDxsNCs=; b=FnD42vN9jRIyjkBAVrnEDLMgSeaHNAvaewMKZ9VsLmRCyu/KBLYqmHll2rZyRfEmhs GDM6IM6vIzO98FaDtk6JZKFpWrFht1fIMy1ui5IHsBBDaelukZ+HdkR66ERqFXLwVF4e /naW7niQ8f7n/t3vX3uRXec+tAu+4+eCbocRAXH4MEyDkLuyLGyOaAsr8ONJrwawUDvR u6ZKG6n+RCqna7eBsQbu+m3BdmwZS6dCzA/tlCWdi0cwkrABzyVoTBh4RQipzXQVIOrb 3HYHuD07vMbxcv3RN/id8R50uj9d4wVcE+QVi7UXToN3RhmQ7B34zMnYH7u1TRCwhsgP 28PQ== X-Gm-Message-State: AOPr4FUN2r8WMf0aWPZFxeTdCi/cL05x6uxq4CJgSiHZyvPRY0qYVmmMYoqza3zspbdsvKpuOMq4MnWbocfwIdGc X-Received: by 10.140.106.163 with SMTP id e32mr19069392qgf.77.1462529671680; Fri, 06 May 2016 03:14:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.170.147 with HTTP; Fri, 6 May 2016 03:14:12 -0700 (PDT) From: Murtuza Zabuawala Date: Fri, 6 May 2016 15:44:12 +0530 Message-ID: Subject: PATCH: Fixed typo in Server node To: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a113a2a7c8e514c053229b9ef X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113a2a7c8e514c053229b9ef Content-Type: multipart/alternative; boundary=001a113a2a7c8e5144053229b9ed --001a113a2a7c8e5144053229b9ed Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, Looks like below given commit has left a typo in the code, I=E2=80=99m gett= ing error while updating any Server node, *Commit:* 0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page 2016-05-05 16:42:16 +0100 377) node=3Dself.blueprint.generate_browser_node( *Error:* * return method(*args, **kwargs)* * File "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/servers/= __init__.py", line 385, in update* * server_type=3D'pg' # default server type* *TypeError: make_json_response() got an unexpected keyword argument =E2=80= =98node'* PFA patch to fix the issue. Regards, Murtuza --001a113a2a7c8e5144053229b9ed Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,<= /div>

Looks like below given commit has left a typo in t= he code, I=E2=80=99m getting error while updating any Server node,

Commit:
0628ee04 web/pgadmin/browser/server_gr= oups/servers/__init__.py (Dave Page =C2=A0 =C2=A0 =C2=A0 =C2=A0 2016-05-05 = 16:42:16 +0100 377) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 node=3Dself.b= lueprint.generate_browser_node(

Error:
=
=C2=A0 =C2=A0 return method(*args, **kwargs= )
=C2=A0 File "/Users/murtuza/Desktop/pgadmin4/web/pg= admin/browser/server_groups/servers/__init__.py", line 385, in update<= /i>
=C2=A0 =C2=A0 server_type=3D'pg' =C2=A0# default s= erver type
TypeError: make_json_response() got an unexpect= ed keyword argument=C2=A0=E2=80=98node'

=


PFA patch to fix the issue.=



Regards,
= Murtuza
--001a113a2a7c8e5144053229b9ed-- --001a113a2a7c8e514c053229b9ef Content-Type: application/octet-stream; name="fixed_typo.patch" Content-Disposition: attachment; filename="fixed_typo.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_invkak900 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL19faW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvX19pbml0X18ucHkKaW5kZXggYWMxZDMy Zi4uM2JjMDcxNyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvX19pbml0X18ucHkKKysrIGIvd2ViL3Bn YWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvX19pbml0X18u cHkKQEAgLTM3NCw3ICszNzQsNyBAQCBjbGFzcyBTZXJ2ZXJOb2RlKFBHQ2hp bGROb2RlVmlldyk6CiAKICAgICAgICAgcmV0dXJuIG1ha2VfanNvbl9yZXNw b25zZSgKICAgICAgICAgICAgIHN1Y2Nlc3M9MSwKLSAgICAgICAgICAgIG5v ZGU9c2VsZi5ibHVlcHJpbnQuZ2VuZXJhdGVfYnJvd3Nlcl9ub2RlKAorICAg ICAgICAgICAgZGF0YT1zZWxmLmJsdWVwcmludC5nZW5lcmF0ZV9icm93c2Vy X25vZGUoCiAgICAgICAgICAgICAgICAgIiVkIiAlIChzZXJ2ZXIuaWQpLCBz ZXJ2ZXIuc2VydmVyZ3JvdXBfaWQsCiAgICAgICAgICAgICAgICAgc2VydmVy Lm5hbWUsCiAgICAgICAgICAgICAgICAgImljb24tc2VydmVyLW5vdC1jb25u ZWN0ZWQiIGlmIG5vdCBjb25uZWN0ZWQgZWxzZQo= --001a113a2a7c8e514c053229b9ef Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a113a2a7c8e514c053229b9ef--