Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boUnl-0003J6-Bv for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Sep 2016 12:14:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1boUnk-0005ao-MI for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Sep 2016 12:14:28 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1boUnk-0005af-0c for pgadmin-hackers@postgresql.org; Mon, 26 Sep 2016 12:14:28 +0000 Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1boUng-0007Vs-F5 for pgadmin-hackers@postgresql.org; Mon, 26 Sep 2016 12:14:26 +0000 Received: by mail-qk0-x22c.google.com with SMTP id g67so100593357qkd.0 for ; Mon, 26 Sep 2016 05:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SQTyESwN3iSEwNGrYDTpDXS7wsE6O+HvCvoLZP6B9bs=; b=V37K14Pvyc8uXeCgNJwWqU7hLIVV/tuIckSnIe8aP2t+UttMk3L6Nl+TqerhbxruYP scPJTxoLqsE8dlVVZsebpuFb11GZN7048Wxscs3ey07q3omugFinWIQUtm4KCv0ryb2w Zcm7DFGNQ2dNe2HAQVW3rhTsRGnJGRy2rhNVZpi+TsmDDTVCvUywJNdd/nG983RBtAAQ QdF/oChHPrSpxSaej8u+AICqw0z5jgUlr77SxH1fmusPF+iKng1hsT1mONWE+2EddKqS uJ0ZVj8So6uqB3KThbSen0xgcMUAWB2dK9ZtQ0pfZyxCa/ITYHehv6qN0quGj4T3VIaj 3NjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SQTyESwN3iSEwNGrYDTpDXS7wsE6O+HvCvoLZP6B9bs=; b=bTQfHd4xZkS429pndzGgvIn4nOy3ZMDYBJdyr1LvG5RGUSe8X8ESIYvFy4Emys3J5c 0wDar9BTGxZeWezACGVcP1U1aJynmm6EluUP7wQCGsCim+tepNVyhKvHNNYFbSDnuk+8 DYg46/l3riyfU7pZiWX1rkRzb88Oax8GHaKYfSAQMz2z9vvtDaiy5CR6vL8hp+WXf9hu JUN7MdUbn9abWQwwpQigFeMTX0PW+AgJbe7fAtt4XlD/ESMRylyjjbYBx3epFJg+qB9z SpdE4rYlI548p/4K/10OrFBecnTPhYufzOT6G9aZfJBLRA8x5U4Dye/XO6joDcGlE2ZF JvUA== X-Gm-Message-State: AA6/9RlxVhd2nyT93PCBfC4qiUadbw1/+N63ozMxdNOJCnXYCNmiZK3E4C7ZILI0vrETxn3X6hyI+3c3LyFExbg9 X-Received: by 10.55.88.199 with SMTP id m190mr22472744qkb.78.1474892063822; Mon, 26 Sep 2016 05:14:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.129.194 with HTTP; Mon, 26 Sep 2016 05:14:03 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 26 Sep 2016 17:44:03 +0530 Message-ID: Subject: Re: PATCH: To fix the issue in Debugger module (pgAdmin4) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114e507e8bed4a053d68111c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114e507e8bed4a053d68111c Content-Type: text/plain; charset=UTF-8 On Mon, Sep 26, 2016 at 5:08 PM, Dave Page wrote: > Hi > > On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to fix the issue where it was not disabling buttons after > > execution gets finished. > > RM#1227 > > > > Issue: > > If user clicks on buttons after execution is complete then it was > throwing > > error, expected behaviour was all button should gets disabled except > execute > > button. > > This is an improvement I think, but not complete: > > - The info messages are now shown, but: > - Not until execution ends, which limits their usefulness for > additional debugging. Not sure if that's easily changeable though. - The line breaks in messages are displaying like this: "INFO: > Employee 1 not found
SELECT 1" > It's showing properly on my side, Please clear browser cache & try again. > - The first execution of the function worked OK, but following the > second execution, I again saw: "Debugger: Step into execution error" > as I stepped out of the RETURN statement on line 18. > This is transient issue, so need more debugging. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114e507e8bed4a053d68111c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Mon, Sep 26, 2016 at 5:08 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Hi

On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where it was not disabling buttons after > execution gets finished.
> RM#1227
>
> Issue:
> If user clicks on buttons after execution is complete then it was thro= wing
> error, expected behaviour was all button should gets disabled except e= xecute
> button.

This is an improvement I think, but not complete:

- The info messages are now shown, but:
=C2=A0 - Not until execution ends, which limits their usefulness for
additional debugging. Not sure if that's easily changeable though.=C2= =A0
=C2=A0 - The line breaks in messages are displaying like this: "INFO:<= br> Employee 1 not found <br>SELECT 1"=C2=A0
It= 's showing properly on my side, Please clear browser cache & try ag= ain.=C2=A0
- The first execution of the function worked OK, but following the
second execution, I again saw: "Debugger: Step into execution error&qu= ot;
as I stepped out of the RETURN statement on line 18.
T= his is transient issue, so need more debugging.
=C2=A0

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114e507e8bed4a053d68111c--