Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iiHDi-0005Gx-Bw for pgadmin-hackers@arkaria.postgresql.org; Fri, 20 Dec 2019 12:17:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iiHDg-0003Y6-Qp for pgadmin-hackers@arkaria.postgresql.org; Fri, 20 Dec 2019 12:17:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iiHDg-0003Xz-J1 for pgadmin-hackers@lists.postgresql.org; Fri, 20 Dec 2019 12:17:24 +0000 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iiHDZ-0008V3-JQ for pgadmin-hackers@postgresql.org; Fri, 20 Dec 2019 12:17:24 +0000 Received: by mail-ot1-x335.google.com with SMTP id b18so11701170otp.0 for ; Fri, 20 Dec 2019 04:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=m4fyuS5fti6itLoNxR4fWkhxDrCc5W47DCyGNui55gc=; b=hC00hgho3aHQDNS/f7oJ2EWHDIIiicK1SbpXE/Db9ovFD/QWjrxOLPVqUCR6Wsgmag MaRptxsy4KNNPSkHoNwEQDIcSHv30Dv7C+IxPm9KeFTBD/LGwNwBlIr7FrzLCIbfo8b0 jGSxIp54FND4CpmSZsE6QDh78kFsJgosuVCQY/czmBXTLEUMCfIWzfA2Ot844xYAbJg9 UAgayqMtm79PQHOxSR8ZlbW28xv97h3bVLml+cm5j2kCL4w6+jDEVpUlh6KYJUjQelRg adzMCl91VpMGZhaBVcFmiXXT+9gNxpMdcYLYmoYJqF2+1+bECdBu9iI1T44qHdv/GD5z tkbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=m4fyuS5fti6itLoNxR4fWkhxDrCc5W47DCyGNui55gc=; b=EmKLYW8ZzU3Vvf3jGOBaKOVcZ4ri1L9BKMRwudTrw0hfw8ZQ7B9yH09MC+XPekNTxt Ac+srrg6Tak8RmIaymAQrRhF2ncTnInwOn2wdwZ40y9w8EayAn1y47s/Dz/mGBQDH180 Fc4Bv7goHC4gwVlj2IA8XQr5HXknchZIhe7tSOMEljISyGS4B6Iz4+jgqPThkvRrOg0e t4dbTgOhuYjVf4QW3vZymhNAgJFYDHgSvS+0qsLegPi0j3p8hc77RV++kTWn67qQBtz6 P2XL4+JDcqXA0oEcOY7ipgQLYoE7IFeJNyDbmIsv5y9rpSxf/E+i47MM7RszLAjhHWGZ YWJQ== X-Gm-Message-State: APjAAAWuiZBXKQnLAzOizEpMnWzCH9MiynJVHHoUp8iC5de6UkqIhUzx IMFjTbCwXpMfbo/WXroH2/EKcuH9QmWkZYsw/RZ/CNEZUCRfdZ6Amplq5IiwLwaKaA+tpUm/zGD 7ApEC5NdPUBFncfPNLySz1YNFsncPgqXWiZPXDL2doErcGW7gOLJyyR+m7MCXc/JjZJBOGwVTCj fTh/whML9W6IH2MOW5xMqmI/xQM1CgXZ6+fV6J9tmvbL/griJYOWGEjYxPv7g= X-Google-Smtp-Source: APXvYqxy8UTjQCB0xoc1bkn6py9CJPDKq8b+wRKe67Q20opplEsPCRxJWyAxH81z1dq4UNHRZZkkY6U+85k8tyOhJZI= X-Received: by 2002:a05:6830:681:: with SMTP id q1mr15068024otr.162.1576844235157; Fri, 20 Dec 2019 04:17:15 -0800 (PST) MIME-Version: 1.0 From: Murtuza Zabuawala Date: Fri, 20 Dec 2019 17:46:58 +0530 Message-ID: Subject: [pgAdmin4][RM#4772] Add aria-label attribute to buttons used in graphical explain plan To: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000081101e059a21a85c" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000081101e059a21a85c Content-Type: multipart/alternative; boundary="00000000000081101b059a21a85a" --00000000000081101b059a21a85a Content-Type: text/plain; charset="UTF-8" Hi, PFA patch for adding aria-label to buttons used in graphical explain plan section. - Fixed another minor issue where we will only use dialog tab navigator keyboard shortcuts only on visible tabs. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000081101b059a21a85a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

PFA patch for add= ing aria-label to buttons used in graphical explain plan section.

- Fixed another minor issue where we wi= ll only use=C2=A0dialog tab navigator keyboard shortcuts only on visible ta= bs.


--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2= =A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= /font>

--00000000000081101b059a21a85a-- --00000000000081101e059a21a85c Content-Type: application/octet-stream; name="pgadmin4.diff" Content-Disposition: attachment; filename="pgadmin4.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k4dzax6s0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGljL2V4cGxhaW4vanMvZXhwbGFpbi5q cyBiL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGljL2V4cGxhaW4vanMvZXhwbGFpbi5qcwppbmRleCAx NGNhNzZhMTU4Li41OGQxMTJkZWY5IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9taXNjL3N0YXRp Yy9leHBsYWluL2pzL2V4cGxhaW4uanMKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9zdGF0aWMvZXhw bGFpbi9qcy9leHBsYWluLmpzCkBAIC0xMjgzLDcgKzEyODMsOCBAQCBkZWZpbmUoJ3BnYWRtaW4u bWlzYy5leHBsYWluJywgWwogICAgICAgICB9KS5hcHBlbmRUbyhncmFwaGljYWxDb250YWluZXIp LAogICAgICAgICB6b29tSW5CdG4gPSAkKCc8YnV0dG9uPjwvYnV0dG9uPicsIHsKICAgICAgICAg ICBjbGFzczogJ2J0biBidG4tc2Vjb25kYXJ5IHBnLWV4cGxhaW4tem9vbS1idG4nLAotICAgICAg ICAgIHRpdGxlOiAnWm9vbSBpbicsCisgICAgICAgICAgdGl0bGU6IGdldHRleHQoJ1pvb20gaW4n KSwKKyAgICAgICAgICAnYXJpYS1sYWJlbCc6IGdldHRleHQoJ1pvb20gaW4nKSwKICAgICAgICAg ICB0YWJpbmRleDogMCwKICAgICAgICAgfSkuYXBwZW5kVG8oem9vbUFyZWEpLmFwcGVuZCgKICAg ICAgICAgICAkKCc8aT48L2k+JywgewpAQCAtMTI5MSw3ICsxMjkyLDggQEAgZGVmaW5lKCdwZ2Fk bWluLm1pc2MuZXhwbGFpbicsIFsKICAgICAgICAgICB9KSksCiAgICAgICAgIHpvb21Ub05vcm1h bCA9ICQoJzxidXR0b24+PC9idXR0b24+JywgewogICAgICAgICAgIGNsYXNzOiAnYnRuIGJ0bi1z ZWNvbmRhcnkgcGctZXhwbGFpbi16b29tLWJ0bicsCi0gICAgICAgICAgdGl0bGU6ICdab29tIHRv IG9yaWdpbmFsJywKKyAgICAgICAgICB0aXRsZTogZ2V0dGV4dCgnWm9vbSB0byBvcmlnaW5hbCcp LAorICAgICAgICAgICdhcmlhLWxhYmVsJzogZ2V0dGV4dCgnWm9vbSB0byBvcmlnaW5hbCcpLAog ICAgICAgICAgIHRhYmluZGV4OiAwLAogICAgICAgICB9KS5hcHBlbmRUbyh6b29tQXJlYSkuYXBw ZW5kKAogICAgICAgICAgICQoJzxpPjwvaT4nLCB7CkBAIC0xMjk5LDcgKzEzMDEsOCBAQCBkZWZp bmUoJ3BnYWRtaW4ubWlzYy5leHBsYWluJywgWwogICAgICAgICAgIH0pKSwKICAgICAgICAgem9v bU91dEJ0biA9ICQoJzxidXR0b24+PC9idXR0b24+JywgewogICAgICAgICAgIGNsYXNzOiAnYnRu IGJ0bi1zZWNvbmRhcnkgcGctZXhwbGFpbi16b29tLWJ0bicsCi0gICAgICAgICAgdGl0bGU6ICda b29tIG91dCcsCisgICAgICAgICAgdGl0bGU6IGdldHRleHQoJ1pvb20gb3V0JyksCisgICAgICAg ICAgJ2FyaWEtbGFiZWwnOiBnZXR0ZXh0KCdab29tIG91dCcpLAogICAgICAgICAgIHRhYmluZGV4 OiAwLAogICAgICAgICB9KS5hcHBlbmRUbyh6b29tQXJlYSkuYXBwZW5kKAogICAgICAgICAgICQo JzxpPjwvaT4nLCB7CkBAIC0xMzEzLDcgKzEzMTYsOCBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlzYy5l eHBsYWluJywgWwogICAgICAgICBkb3dubG9hZEJ0biA9ICQoJzxidXR0b24+PC9idXR0b24+Jywg ewogICAgICAgICAgIGlkOiAnYnRuLWV4cGxhaW4tZG93bmxvYWQnLAogICAgICAgICAgIGNsYXNz OiAnYnRuIGJ0bi1zZWNvbmRhcnkgcGctZXhwbGFpbi1kb3dubG9hZC1idG4nLAotICAgICAgICAg IHRpdGxlOiAnRG93bmxvYWQnLAorICAgICAgICAgIHRpdGxlOiBnZXR0ZXh0KCdEb3dubG9hZCcp LAorICAgICAgICAgICdhcmlhLWxhYmVsJzogZ2V0dGV4dCgnRG93bmxvYWQnKSwKICAgICAgICAg ICB0YWJpbmRleDogMCwKICAgICAgICAgICBkaXNhYmxlZDogZnVuY3Rpb24oKSB7CiAgICAgICAg ICAgICB2YXIgY3VycmVudF9icm93c2VyID0gcGdBZG1pbi5Ccm93c2VyLmdldF9icm93c2VyKCk7 CkBAIC0xMzQxLDcgKzEzNDUsOCBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlzYy5leHBsYWluJywgWwog ICAgICAgJCgnPGJ1dHRvbj48L2J1dHRvbj4nLCB7CiAgICAgICAgIGlkOiAnYnRuLWV4cGxhaW4t c3RhdHMnLAogICAgICAgICBjbGFzczogJ2J0biBidG4tc2Vjb25kYXJ5IHBnLWV4cGxhaW4tc3Rh dHMtYnRuJywKLSAgICAgICAgdGl0bGU6ICdTdGF0aXN0aWNzJywKKyAgICAgICAgdGl0bGU6IGdl dHRleHQoJ1N0YXRpc3RpY3MnKSwKKyAgICAgICAgJ2FyaWEtbGFiZWwnOiBnZXR0ZXh0KCdTdGF0 aXN0aWNzJyksCiAgICAgICAgIHRhYmluZGV4OiAwLAogICAgICAgfSkuYXBwZW5kVG8oc3RhdHNB cmVhKS5hcHBlbmQoCiAgICAgICAgICQoJzxpPjwvaT4nLCB7CmRpZmYgLS1naXQgYS93ZWIvcGdh ZG1pbi9zdGF0aWMvanMvZGlhbG9nX3RhYl9uYXZpZ2F0b3IuanMgYi93ZWIvcGdhZG1pbi9zdGF0 aWMvanMvZGlhbG9nX3RhYl9uYXZpZ2F0b3IuanMKaW5kZXggNTk0MzcxMTU5OC4uYjNmZmM5OTZm NyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2RpYWxvZ190YWJfbmF2aWdhdG9y LmpzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9kaWFsb2dfdGFiX25hdmlnYXRvci5qcwpA QCAtMTksNyArMTksNyBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3IgewogCiAgICAgdGhpcy50 YWJTd2l0Y2hpbmcgPSBmYWxzZTsKIAotICAgIHRoaXMudGFicyA9IHRoaXMuZGlhbG9nQ29udGFp bmVyLmZpbmQoJy5uYXYtdGFicycpOworICAgIHRoaXMudGFicyA9IHRoaXMuZGlhbG9nQ29udGFp bmVyLmZpbmQoJy5uYXYtdGFiczp2aXNpYmxlJyk7CiAKICAgICBpZiAodGhpcy50YWJzLmxlbmd0 aCA+IDAgKSB7CiAgICAgICB0aGlzLnRhYnMgPSB0aGlzLnRhYnNbMF07CkBAIC0zNSw3ICszNSw3 IEBAIGNsYXNzIGRpYWxvZ1RhYk5hdmlnYXRvciB7CiAKICAgb25LZXlib2FyZEV2ZW50KGV2ZW50 LCBzaG9ydGN1dCkgewogICAgIHZhciBjdXJyZW50VGFiUGFuZSA9ICB0aGlzLmRpYWxvZ0NvbnRh aW5lcgotICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2 ZTpmaXJzdCcpLAorICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5l LmFjdGl2ZTpmaXJzdDp2aXNpYmxlJyksCiAgICAgICBjaGlsZFRhYkRhdGEgPSB0aGlzLmlzQWN0 aXZlUGFuZUhhc0NoaWxkVGFicyhjdXJyZW50VGFiUGFuZSk7CiAKICAgICBpZiAodGhpcy50YWJT d2l0Y2hpbmcpIHsKQEAgLTU3LDEyICs1NywxMiBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3Ig ewogICB9CiAKICAgaXNBY3RpdmVQYW5lSGFzQ2hpbGRUYWJzKGN1cnJlbnRUYWJQYW5lKSB7Ci0g ICAgdmFyIGNoaWxkVGFiID0gY3VycmVudFRhYlBhbmUuZmluZCgnLm5hdi10YWJzOmZpcnN0Jyks CisgICAgdmFyIGNoaWxkVGFiID0gY3VycmVudFRhYlBhbmUuZmluZCgnLm5hdi10YWJzOmZpcnN0 OnZpc2libGUnKSwKICAgICAgIGNoaWxkVGFiUGFuZTsKIAogICAgIGlmIChjaGlsZFRhYi5sZW5n dGggPiAwKSB7CiAgICAgICBjaGlsZFRhYlBhbmUgPSBjdXJyZW50VGFiUGFuZQotICAgICAgICAu ZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdCcpOworICAg ICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdDp2 aXNpYmxlJyk7CiAKICAgICAgIHJldHVybiB7CiAgICAgICAgICdjaGlsZFRhYic6IGNoaWxkVGFi LApAQCAtOTMsNyArOTMsNyBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3IgewogCiAgICAgICBu ZXh0VGFiUGFuZSA9IHRhYl9wYW5lLnByZXYoKTsKICAgICAgIGlubmVyVGFiQ29udGFpbmVyID0g bmV4dFRhYlBhbmUKLSAgICAgICAgLmZpbmQoJy50YWItY29udGVudDpmaXJzdCA+IC50YWItcGFu ZS5hY3RpdmU6Zmlyc3QnKTsKKyAgICAgICAgLmZpbmQoJy50YWItY29udGVudDpmaXJzdCA+IC50 YWItcGFuZS5hY3RpdmU6Zmlyc3Q6dmlzaWJsZScpOwogCiAgICAgICBpZiAoaW5uZXJUYWJDb250 YWluZXIubGVuZ3RoID4gMCkgewogICAgICAgICBmaW5kQW5kU2V0Rm9jdXMoaW5uZXJUYWJDb250 YWluZXIpOwpAQCAtMTI0LDcgKzEyNCw3IEBAIGNsYXNzIGRpYWxvZ1RhYk5hdmlnYXRvciB7CiAK ICAgICAgIG5leHRUYWJQYW5lID0gdGFiX3BhbmUubmV4dCgpOwogICAgICAgaW5uZXJUYWJDb250 YWluZXIgPSBuZXh0VGFiUGFuZQotICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4g LnRhYi1wYW5lLmFjdGl2ZTpmaXJzdCcpOworICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZp cnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdDp2aXNpYmxlJyk7CiAKICAgICAgIGlmIChpbm5l clRhYkNvbnRhaW5lci5sZW5ndGggPiAwKSB7CiAgICAgICAgIGZpbmRBbmRTZXRGb2N1cyhpbm5l clRhYkNvbnRhaW5lcik7Cg== --00000000000081101e059a21a85c--