Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGPEM-0001aP-5S for pgadmin-hackers@arkaria.postgresql.org; Fri, 24 Jun 2016 11:25:02 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bGPEL-00056O-2w for pgadmin-hackers@arkaria.postgresql.org; Fri, 24 Jun 2016 11:25:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bGPEK-00056H-5t for pgadmin-hackers@postgresql.org; Fri, 24 Jun 2016 11:25:00 +0000 Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bGPEB-0007m8-R7 for pgadmin-hackers@postgresql.org; Fri, 24 Jun 2016 11:24:59 +0000 Received: by mail-qk0-x233.google.com with SMTP id p10so141975093qke.3 for ; Fri, 24 Jun 2016 04:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aT0gJy9xPiD9m3rRtd8+hx+7D9GEeSlK934IQ4QPDcI=; b=NaWAfXEVQQHurhb+9Um2n8eKbMyXNqPb56Gt40X2hYI370ckVsopnhI0OA9ggIc56+ 60DfS7E6qPPiIrGfYuqVrbjoojVh9FNiKZBt3HjbOJu/USYhibBPW07GMvFjNdeUts+o GDkdPzGSMXb+oXxOvsbJLTrSfJTKJ4fpLHA00OsZMF6/qKtv+O1ArXTOJ9Qa4Hcgp0Pk 1Y7o9WctYROMHlgSDLD1V7pzvtXl3OlJQDevM3toblq8YLBm+/n32RRoj3DvkyYomkqO w3n0t8xUb+vxnlMAgA1vjwHxOuTf0enJHH4it5kBhPVfBcVrPKM3sDY/hc4/Ze0+6Amm KaRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aT0gJy9xPiD9m3rRtd8+hx+7D9GEeSlK934IQ4QPDcI=; b=j3ho5h978FJAyCqPcl6DB0OT3GB5vpZHhKxGIHOPFsdvAdh0J+0hgKhrlrXDeozbnZ QWDcN0Pa+4X7nDVcqEGpjuB4b/+iunY9iOpyrIv9POslWPLybNeES/LUsi3MDQE0m4pL duyvpgcica/ALXrEzR9lLk0a6NryQfXUsVA3jbkOPV9gFp8+721QyzkycvCQ2D9j6ppQ JFxM0zvhhHZp5GAmw+A7BAQ3OWcxM03SPuQO/7C7jTEXVcKhuf7dfZmbym9DEB4KiCE/ 0ydUwdv8N+b1GRn2le3cJlprp4KDm0HIy+dxcg9sex4jzC0UHnW8Oxnnux+VEzj8z3/M bhlw== X-Gm-Message-State: ALyK8tIPR78ipoZYNX0mYcO4Nvq1teJGReQsiLSi2QWHfF4693sVMTusBe/h+GYpaLoRqiNs0dkM82fRzJzUBu1b X-Received: by 10.55.22.154 with SMTP id 26mr4145576qkw.115.1466767489774; Fri, 24 Jun 2016 04:24:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.221.28 with HTTP; Fri, 24 Jun 2016 04:24:30 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Fri, 24 Jun 2016 16:54:30 +0530 Message-ID: Subject: Re: Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers To: Dave Page Cc: Sanket Mehta , pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114773de32853c0536046bd8 X-Pg-Spam-Score: -1.6 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114773de32853c0536046bd8 Content-Type: multipart/alternative; boundary=001a114773de3285370536046bd6 --001a114773de3285370536046bd6 Content-Type: text/plain; charset=UTF-8 Hi, PFA patch to fix the issue RM#1292. Earlier patch was not handling spaces properly. e.g- If user creates any objects which has spaces in its name then it fails to parse it next time user select it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jun 20, 2016 at 8:34 PM, Dave Page wrote: > Thanks, patch applied. > > On Mon, Jun 20, 2016 at 2:56 PM, Sanket Mehta > wrote: > > Hi, > > > > PFA the revised patch to resolve this issue which consists the change in > > control formatter. > > > > > > Regards, > > Sanket Mehta > > Sr Software engineer > > Enterprisedb > > > > On Mon, Jun 13, 2016 at 3:12 PM, wrote: > >> > >> Issue #1292 has been updated by Dave Page. > >> > >> Target version deleted (1.0 Beta 1) > >> > >> ________________________________ > >> > >> Bug #1292: ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," > does > >> not exist message throws if template database contain special charterers > >> > >> Author: Fahar Abbas > >> Status: In Progress > >> Priority: Normal > >> Assignee: Sanket Mehta > >> Category: > >> Target version: > >> > >> Commit ID: > >> ----------- > >> commit 954163b4957c1dce89c0632d009b845cbe90faf4 > >> > >> Browser version: > >> ---------------- > >> Firefox 45.0.2 > >> > >> Python version: > >> ---------------- > >> 3.5.1+ > >> > >> Platforms: > >> All > >> > >> ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not > exist > >> message throws if user try to create database with template database > that > >> name contain special charterers. > >> > >> Please note that this issue is not reproducible in other template > >> databases that name is simple one. > >> > >> Please note that this is not reproduce in pgAdmin3. > >> > >> Steps: > >> > >> 1. Install pgAdmin4 on Ubuntu 16.04 > >> 2. Install PG-9.6-beta 1 installer > >> 3. Expand database node > >> 4. give it's name !#$%^&*()_+{}|:"<>?=-\][';/., > >> 5. Database created successfully > >> 6. Again create new database and give it's name abcd > >> 7. Click on definition tab > >> 8. select template database !#$%^&*()_+{}|:"<>?=-\][';/., > >> 9. Click on Save button > >> > >> Files Screen Shot 2016-06-02 at 10.25.34 am.png (1020 KB) > >> Screen Shot 2016-06-02 at 10.26.01 am.png (1.03 MB) > >> ________________________________ > >> > >> You have received this notification because you have either subscribed > to > >> it, or are involved in it. > >> To change your notification preferences, please click here: > >> https://redmine.postgresql.org/my/account > > > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --001a114773de3285370536046bd6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA patch to fix the issue RM#1292.= =C2=A0

Earlier patch was not handling spaces prope= rly.
e.g- If user creates any objects which has spaces in its nam= e then it fails to parse it next time user select it.

<= div>=C2=A0=C2=A0

--
Regards,Murt= uza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
<= span style=3D"color:rgb(136,136,136)">The Enterprise PostgreSQL Company

On Mon, Jun 20, 2016 at 8:34 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Thanks, patch applied.

On Mon, Jun 20, 2016 at 2:56 PM, Sanket Mehta
<sanket.mehta@enterpris= edb.com> wrote:
> Hi,
>
> PFA the revised patch to resolve this issue which consists the change = in
> control formatter.
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Mon, Jun 13, 2016 at 3:12 PM, <redmine@postgresql.org> wrote:
>>
>> Issue #1292 has been updated by Dave Page.
>>
>> Target version deleted (1.0 Beta 1)
>>
>> ________________________________
>>
>> Bug #1292: ERROR: template database "!@#$%^&*()_+{}|:&quo= t;<>?=3D-\\][';/.," does
>> not exist message throws if template database contain special char= terers
>>
>> Author: Fahar Abbas
>> Status: In Progress
>> Priority: Normal
>> Assignee: Sanket Mehta
>> Category:
>> Target version:
>>
>> Commit ID:
>> -----------
>> commit 954163b4957c1dce89c0632d009b845cbe90faf4
>>
>> Browser version:
>> ----------------
>> Firefox 45.0.2
>>
>> Python version:
>> ----------------
>> 3.5.1+
>>
>> Platforms:
>> All
>>
>> ERROR: template database "!@#$%^&*()_+{}|:"<>?= =3D-\\][';/.," does not exist
>> message throws if user try to create database with template databa= se that
>> name contain special charterers.
>>
>> Please note that this issue is not reproducible in other template<= br> >> databases that name is simple one.
>>
>> Please note that this is not reproduce in pgAdmin3.
>>
>> Steps:
>>
>> 1. Install pgAdmin4 on Ubuntu 16.04
>> 2. Install PG-9.6-beta 1 installer
>> 3. Expand database node
>> 4. give it's name !#$%^&*()_+{}|:"<>?=3D-\][= 9;;/.,
>> 5. Database created successfully
>> 6. Again create new database and give it's name abcd
>> 7. Click on definition tab
>> 8. select template database !#$%^&*()_+{}|:"<>?=3D-= \][';/.,
>> 9. Click on Save button
>>
>> Files Screen Shot 2016-06-02 at 10.25.34 am.png (1020 KB)
>> Screen Shot 2016-06-02 at 10.26.01 am.png (1.03 MB)
>> ________________________________
>>
>> You have received this notification because you have either subscr= ibed to
>> it, or are involved in it.
>> To change your notification preferences, please click here:
>> https://redmine.postgresql.org/my/account
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-ha= ckers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=

--001a114773de3285370536046bd6-- --001a114773de32853c0536046bd8 Content-Type: application/octet-stream; name="RM_1292.patch" Content-Disposition: attachment; filename="RM_1292.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iptnf9340 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5w Z2FkbWluLmpzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBn YWRtaW4uanMKaW5kZXggNzQzMTc2NS4uMTM3MDY5OCAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKKysr IGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMK QEAgLTE3ODcsMTAgKzE3ODcsMTAgQEAKICAgdmFyIFNlbGVjdDJGb3JtYXR0 ZXIgPSBmdW5jdGlvbigpIHt9OwogICBfLmV4dGVuZChTZWxlY3QyRm9ybWF0 dGVyLnByb3RvdHlwZSwgewogICAgIGZyb21SYXc6IGZ1bmN0aW9uKHJhd0Rh dGEsIG1vZGVsKSB7Ci0gICAgICByZXR1cm4gSlNPTi5wYXJzZShKU09OLnN0 cmluZ2lmeShfLmVzY2FwZShyYXdEYXRhKSkpOworICAgICAgcmV0dXJuIGVu Y29kZVVSSUNvbXBvbmVudChyYXdEYXRhKTsKICAgICB9LAogICAgIHRvUmF3 OiBmdW5jdGlvbihmb3JtYXR0ZWREYXRhLCBtb2RlbCkgewotICAgICAgcmV0 dXJuIGZvcm1hdHRlZERhdGE7CisgICAgICByZXR1cm4gZGVjb2RlVVJJQ29t cG9uZW50KGZvcm1hdHRlZERhdGEpOwogICAgIH0KICAgfSk7CiAK --001a114773de32853c0536046bd8 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114773de32853c0536046bd8--