Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPlVM-0008WG-PP for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Oct 2020 11:51:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kPlVL-0003Q6-NK for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Oct 2020 11:51:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPlVL-0003Pv-Av for pgadmin-hackers@lists.postgresql.org; Tue, 06 Oct 2020 11:51:39 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kPlVH-0007UY-Hv for pgadmin-hackers@postgresql.org; Tue, 06 Oct 2020 11:51:38 +0000 Received: by mail-ot1-x341.google.com with SMTP id n61so11982669ota.10 for ; Tue, 06 Oct 2020 04:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3NyAdG/iY340MxugUQrQZ7QJCGKOO7HrTI9XKiNpNSc=; b=VwPraMsi4YTNGFrcX9tV0xVNONlOXPVCP7Xs6rxyay3zoqGsvAcW7bypd2JsNp2NXG mGKZJK3FKP+5Xuk6ezb4FZgnoOjKcXIxC9H7ZlptUrZO1/yvWRjhFmr4+yTyKC01i880 vwP/j2moqc3NRvXDsKvUe5aipG1C2G/Q0VrsycRA8bV2wuyowa89N/AdqjizRd40ALR8 sXBzxMOu3j9VXGXRlVC/Z/osHRDiGfFLflR1CVN2N9R6mmRIGz2YFUdMZgWNOfzwV97m dnDeiOI3zpf9Qad32aL2BW+va1jU7yMMYSuGG6J8Br3qTnjjOKNTouJJq2ndt1li4rww 3AYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3NyAdG/iY340MxugUQrQZ7QJCGKOO7HrTI9XKiNpNSc=; b=iqf0TCEApdErbsOyxAQtDffD+J3ED/4Ta+Kehz+2xzhh8KfrGuRdUjAbM368jdBr4i Ca998nyqNaTQ6Fwv9CLSZIbjYxMAtipEr5ZZnGUzhPSmnREQrB0Dg+teoktx0U9Beal8 gG6jN5BdKM8Cv+b+NdK4CsU5I93iGGndbpN5CbLxRzlX3GOa3FDJoau2Yah2Cyu2D0s5 p6N+Svs10YmJWApuko28lkeF9n1UVtZ7XXjojKdCPympgv1P7tQWh/SUu1vqOeXFVrv+ y/ZxSTQW3EKWGtQOzoB39rHNP8UqMvO00QpGVtcb/bEbxgw5+sPEbqpzbHMjM2Wjjvpz F0Ww== X-Gm-Message-State: AOAM532jMP0N3XZ8xlJugCjPz6NZIGtZ7iqW13dPeXltS/QE6n7U3YJN cSuLAO/CVJITvg89R0se/kjTaK5G5k+K1G2CmQoA8Xuyrj+tYvtyzOANVeEBNsDFqtFHu5x32em z1EHvwOaSefJ0pZkaiNH8EJTKSzuYaHv6AkE+i6xdAm2sg6k2F1DQv8OD/qYTvVJXg8/zg9YOzY z87qk0L18pUkvTMI8VR2L8WRV7rv6UVUvkwd31MLc8Ew4hysmKLJjuzc7T9g== X-Google-Smtp-Source: ABdhPJyjb8GPc+02mRn9fBegF6qNko6DdQLXNWzUqADiTXjETV2eNyNnStLXgTzZZCJDtit5Z5yfmHbDHSJe9pzR7I8= X-Received: by 2002:a05:6830:2ee:: with SMTP id r14mr2766937ote.0.1601985093334; Tue, 06 Oct 2020 04:51:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Murtuza Zabuawala Date: Tue, 6 Oct 2020 17:21:17 +0530 Message-ID: Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab To: Akshay Joshi , Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000006c8fd905b0ff3846" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006c8fd905b0ff3846 Content-Type: text/plain; charset="UTF-8" Hi Akshay, We have used aysnc=False in most ajax calls with this feature, It is causing UI hang in case of slow server response. You can try adding a time.sleep() call at the python side response and check the UI hang, I think we should avoid sync calls as much as possible. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite < > nikhil.mohite@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I have resolved the sonarQube issues, PFA updated patch for the same. >> >> >> Regards, >> Nikhil Mohite. >> >> >> On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Nikhil >>> >>> Your patch introduces 1 new Bug and 13 new code smells, please fix those >>> and resend the patch. >>> >>> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite < >>> nikhil.mohite@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> I have resolved code conflict issues and sonarqube issues. >>>> PFA updated patch. >>>> >>>> Regards, >>>> Nikhil Mohite. >>>> >>>> On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Nikhil >>>>> >>>>> The patch is not applying, rebase, and send it again. Please check >>>>> your code should not create any new SonarQube issues. >>>>> >>>>> On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite < >>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>> >>>>>> Hi Akshay, >>>>>> >>>>>> I have resolved all the review comments and also updated the test >>>>>> cases as per the new implementation. >>>>>> >>>>>> PFA updated patch. >>>>>> >>>>>> >>>>>> >>>>>> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Nikhil >>>>>>> >>>>>>> Following are the initial review comments: >>>>>>> >>>>>>> - Open View/Edit data on any table and click on the same >>>>>>> database connection and then click on the Execute button. Got >>>>>>> "get_primary_keys() takes 1 positional argument but 2 were given" error. >>>>>>> - In my opinion, we should hide the option to change the >>>>>>> database connection for View/Edit Data. >>>>>>> - If the user clicks on the same database connection multiple >>>>>>> times then no need to change the backend connection and transaction id. Add >>>>>>> validation at the backend, no action required in this case. >>>>>>> - The role option is missing from the "connect to server" dialog. >>>>>>> - The Password field should not be there on the "connect to >>>>>>> server" dialog. Sometimes we saved the password so asking a password every >>>>>>> time is not correct. Check the pgAdmin 3 behavior. >>>>>>> >>>>>>> Code review still remains. >>>>>>> >>>>>>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite < >>>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Team, >>>>>>>> >>>>>>>> Regarding RM-3794 >>>>>>>> allow the user to change the database connection from an open query tool: >>>>>>>> I have implemented the feature and also added documentation for it. >>>>>>>> >>>>>>>> PFA patch. >>>>>>>> >>>>>>>> -- >>>>>>>> *Thanks & Regards,* >>>>>>>> *Nikhil Mohite* >>>>>>>> *Software Engineer.* >>>>>>>> *EDB Postgres* >>>>>>>> *Mob.No: +91-7798364578.* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards* >>>>>>> *Akshay Joshi* >>>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>>> *EDB Postgres * >>>>>>> >>>>>>> *Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>> *EDB Postgres * >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Sr. Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --0000000000006c8fd905b0ff3846 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

We ha= ve used aysnc=3DFalse in most ajax calls with this feature, It is causing= =C2=A0UI hang in case of slow server response.
You can try ad= ding a time.sleep() call at the python side response and check the UI hang,= I think we should avoid sync calls as much as possible.

=

--Regards,
Murtuza Zabuawala
EDB
POWER TO POSTGRES
=


On Thu, Oct 1, 2020 at 1:31 PM Aksh= ay Joshi <akshay.joshi@= enterprisedb.com> wrote:
Thanks, patch applied.

On Thu, Oct 1, 2= 020 at 10:42 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
H= i Akshay,

I have=C2=A0resolved the sonarQube issues,= PFA updated patch for the same.


Re= gards,
Nikhil Mohite.


On Tue, Sep 29, 2020 at= 11:31 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Ni= khil

Your patch introduces 1 new Bug and 13 new code sme= lls, please fix those and resend the patch.

On Mon, Sep 28, 2020 at 7:= 31 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Akshay,<= br>

I have resolved code conflict issues and sonarqube i= ssues.
PFA updated patch.

Regards,
=
Nikhil Mohite.

On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi <<= a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.jo= shi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil

The = patch is not applying, rebase, and send it again. Please check your code sh= ould not create any new SonarQube issues.

On Mon, Sep 28, 2020 at 11:2= 0 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Akshay,

I have resolved all the review comments and also upda= ted the test cases as per the new implementation.

= PFA updated patch.



On Mon, Sep 21, 2020= at 5:24 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Hi=C2=A0= Nikhil

Following are the initial review comments:
  • Open View/Edit data on any table and click on the same database conne= ction and then click on the Execute button. Got "get_primary_keys() ta= kes 1 positional argument but 2 were given" error.
  • In my opini= on, we should hide the option to change the database connection for View/Ed= it Data.
  • If the user clicks on the same database connection multipl= e times then no need to change the backend connection and transaction id. A= dd validation at the backend, no action required in this case.
  • The = role option is missing from the "connect to server" dialog.
    • <= li>The Password field should not be there on the "connect to server&qu= ot; dialog. Sometimes we saved the password so asking a password every time= is not correct. Check the pgAdmin 3 behavior.Code review still r= emains.

    On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <nikhil.mohite= @enterprisedb.com> wrote:
    Hi Team,

    Regarding RM-37= 94 allow the=C2=A0user to change the database connection from an open q= uery tool:
    I have implemented the feature and also added document= ation for it.

    PFA patch.

    --=
    = Software Engineer.
    Mob.No: +91= -7798364578.


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Sr. Software Ar= chitect
    EDB Postgres=
    Mobile: +91 976-788-8246



    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Sr. Software Ar= chitect
    EDB Postgres=
    Mobile: +91 976-788-8246



    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Sr. Software Ar= chitect
    EDB Postgres=
    Mobile: +91 976-788-8246



    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Sr. Software Ar= chitect
    EDB Postgres=
    Mobile: +91 976-788-8246

    --0000000000006c8fd905b0ff3846--