Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1essuV-00040E-0G for pgadmin-hackers@arkaria.postgresql.org; Mon, 05 Mar 2018 16:24:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1essuT-0000lF-P2 for pgadmin-hackers@arkaria.postgresql.org; Mon, 05 Mar 2018 16:24:21 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1essuT-0000ky-GY for pgadmin-hackers@lists.postgresql.org; Mon, 05 Mar 2018 16:24:21 +0000 Received: from mail-ot0-x230.google.com ([2607:f8b0:4003:c0f::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1essuP-0004um-Ij for pgadmin-hackers@postgresql.org; Mon, 05 Mar 2018 16:24:19 +0000 Received: by mail-ot0-x230.google.com with SMTP id y11so15463451otg.0 for ; Mon, 05 Mar 2018 08:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7a7jJTvjeugzfTtAzF2A9qNxOH9EeKEdsS4LHxG81zk=; b=VEV52JgzdGwULZ/mWFkepeYOK3r71fZAOwcQlQKr2GHPM8v1TvNxRbk8j7CS/DfW9v lOqlwmqkdFp4dNS28yNwN3HBoVM2bYLpIlUmINiWuDMR24tX/Vmyj9s068/T9piIL5+w oCwjReXWdIccJ5CZTOfV/76ro/LB9v585r+RfEV21u+L8pl05kFAolAbjytKHMPWCddd 9Hm2WColxD7weYH7UEBo19PEeiiI4xoVlEpNoAcw66F/ZvKN5XMQYpZ/0KRqy5zq6yC6 jfMyze70shQhXYPCuWn2LUHqJgODuZj/dIXSjdYBgcwxUz9+WVcAml8TZULcbDQL0QoL BfUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7a7jJTvjeugzfTtAzF2A9qNxOH9EeKEdsS4LHxG81zk=; b=QB0vqXj1YmM4xXa3lTXcqi7omFzlcArzV2NuMVnisRxeZx+tdrfrijjjQDIjh3Avh+ brRQIY30hgLagsyhgL4WAzlp6IeSQdtPHRbPSw+ER6oJNZIxfBtXYrybjhN1OsV2T4qd euySejBvYbQeT6B4OamTLJ+7UfRUaB0dcMHrclwh9RAqKwXSQh0tXEHBW5boorgBHQVn 86oPMm32pAhCh11BvtzgqloY728sTjcl2WXZ9e9DJhFt8BaeRw1sEQjQhqpU2ONVMruv bGZZeD2gOPhVeW7+KMZpC8TEnSVAC5xgsuNyuKl12vnffIyM4a03Z5+vDO64Y0kPm9ge +JTQ== X-Gm-Message-State: AElRT7GGpGt37ipfEEVhwshR82TRMF+JERTbc2Gd6VziKA2SYVzI6KaR YzcTlvOGN5y0fPcn00731qqRHZxMa2S5gRXnTL6gaA== X-Google-Smtp-Source: AG47ELudFUNTHtjLJ+sG3nFDhLYpeNMPPPjbeowZ28pJRQWgfeXuxrmURODxK61WjTq496oQHJGUws0E4/bhdZb+xdA= X-Received: by 10.157.49.47 with SMTP id e44mr11322340otc.46.1520267056576; Mon, 05 Mar 2018 08:24:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Mon, 5 Mar 2018 08:23:56 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 5 Mar 2018 21:53:56 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3175] Fix PEP-8 issues To: Joao De Almeida Pereira Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113daf62df347b0566acc1f3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113daf62df347b0566acc1f3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Joao for reviewing. On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Murtuza, > > Looks good, and all tests are green. I run the commands provided and > nothing pops up. > > Only missing 374 :D > =E2=80=8B:-) =E2=80=8B > > Thanks > Joao > > On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix PEP8 issues in Browser & Database modules, >> pycodestyle --config=3D.pycodestyle pgadmin/browser/__init__.py >> pycodestyle --config=3D.pycodestyle pgadmin/browser/tests/ >> pycodestyle --config=3D.pycodestyle pgadmin/browser/server_groups/ >> servers/databases/__init__.py >> pycodestyle --config=3D.pycodestyle pgadmin/browser/server_groups/ >> servers/databases/tests/ >> >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> --001a113daf62df347b0566acc1f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Joao for reviewing.

=

On Mon, Mar 5, 2018 at 8:58 PM, Joao De Alme= ida Pereira <jdealmeidapereira@pivotal.io> wrote:=
Hi Murtuza,

Looks good, and all tests are green. I run the commands provided an= d nothing pops up.

Only missing 374 :D
=
=E2=80=8B:-) =E2=80=8B=C2=A0

Thanks
Joao

On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <murtuza.zabua= wala@enterprisedb.com> wrote:
Hi,

PFA patch to fix PEP8 issues in Browser & Database modu= les,=C2=A0
pycodestyle --config=3D.pycodest= yle pgadmin/browser/__init__.py
pycodestyle --config=3D.pycodestyle pgadmin/browser/tests/
=
pycodestyle --config=3D.pycodestyle= pgadmin/browser/server_groups/servers/databases/__init__.py
pycodestyle --config=3D.pycodestyle pgadm= in/browser/server_groups/servers/databases/tests/



--
Regards,
Murtuza Zabuawala
Enterpr= iseDB:=C2=A0http://www.enterprisedb.com
The Enterprise Postg= reSQL Company

=

--001a113daf62df347b0566acc1f3--