Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX218-0002Hg-RD for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Oct 2020 12:54:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kX217-0000A8-Q0 for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Oct 2020 12:54:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX217-0000A1-Jf for pgadmin-hackers@lists.postgresql.org; Mon, 26 Oct 2020 12:54:29 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kX20z-0000LZ-G2 for pgadmin-hackers@lists.postgresql.org; Mon, 26 Oct 2020 12:54:28 +0000 Received: by mail-oi1-x242.google.com with SMTP id k27so10334082oij.11 for ; Mon, 26 Oct 2020 05:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HthCCgA57iFhcOwYbBhJ/ruheOuJRhWOWAQfoMlmbT0=; b=kD/H2wsSOErMZR8Hs0TF5sNOh63nBSorX/VaZRwUhbVFGgryJqMEr+gImJqMjYR7wb DQzZZ4vuhufDYXoTE4qt7roKhO4T31AcuxWPN+t6Xj4FORlmD26XvyeqWa9JF0cFJfvr hb95NPum3B0y+ka0cW3BfmT5o/y4eUAUF5JoADJk7WVttOZJshQaEvdsz/TZY1Z9RH3z t1bxTS8EzK3+N5j2gqUJQ5X5mhe2C9bJf/P39hg99YzbbA78zXCGiagAXw7/WMU/NHvz QbGCxmojyLVP1sQ7rGgL19qai818H+bUjpjdBGlyv145n98xn/zGJxKkafOoB2dkT9gf kDJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HthCCgA57iFhcOwYbBhJ/ruheOuJRhWOWAQfoMlmbT0=; b=tcU5pg/9X+afMTEjyDvmAT2G0zYGvaks4P+FowweThg7wSN1PfQDbdrCb58yJ6je8q GVPnjnqaIU3ESm5dSDbz9fivOWR3T2J4d9cxcrhNscDM6RYxsQQIFNpn882PSqC3eviD jhWwwTKbBkRnokaPlWqLNiEunR2J39rqN5BgVM7TuvC1eG7r8cXKZN9+ygZUW67d9Ae/ owY5DUyW6ADekPsVGBru5M7Qz4ejbHBKxj8TupH1ZFw87YayMBggWMitiGNK7KPmleHi DBBaIx3Ejq+s3nHwwCCMfeyvG+EJYqdnHkkIVtuzDjHGW5Fe4vBt4icBgSqo1rHRRbW2 4TNQ== X-Gm-Message-State: AOAM5319EFWcvmmZMXZFGTi83phE6hYCf7bNELmYTpXV3L+f+iWvRSfk cDwaYXu4ncyc1q0rzDCegADWn44ddLV8hsryyRHCeRRXBM/Xoy9bppbYjuiVrgsCxtODidF+a5+ HnBSsvRcR1iNluM3hkyvl+3ol5MCbvROf//zGRrxSLn2WHe7lXtDdyVR2hB07XNwMjfWDJnVF7R ZPmKkoW1UE0RUfXz3XR3WZE/7o08qclWi+/GMSoHXK/jZ53lIr1jf+WLAOTSlI+crvG8d3YmyKh A== X-Google-Smtp-Source: ABdhPJyAfRwxPQ3mnBkU2hWG7GL8Kie+C07Ijk/7BbY2Mn6LDhKwInYnBm52rTb2gnZ3tciwqzpy2gM2avraWFTaTLk= X-Received: by 2002:aca:1e08:: with SMTP id m8mr10305584oic.168.1603716858967; Mon, 26 Oct 2020 05:54:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Murtuza Zabuawala Date: Mon, 26 Oct 2020 18:24:03 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Added support to download utility files at the client To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000b3fb3805b2926df6" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b3fb3805b2926df6 Content-Type: multipart/alternative; boundary="000000000000b3fb3705b2926df4" --000000000000b3fb3705b2926df4 Content-Type: text/plain; charset="UTF-8" Hi, PFA minor patch to remove dead code which was introduced with this patch. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi wrote: > Added support to download utility files at the client-side. Fixes #3318 > > Branch > ------ > master > > Details > ------- > > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2ad97d0ab761ad57cf98b192ffe75e9a0d2605a > Author: Rahul Shirsat > > Modified Files > -------------- > docs/en_US/release_notes_4_28.rst | 1 + > web/pgadmin/misc/bgprocess/processes.py | 58 +++- > .../misc/bgprocess/static/css/bgprocess.css | 4 + > .../misc/bgprocess/static/img/storage_manager.svg | 13 + > web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 44 ++- > web/pgadmin/misc/file_manager/__init__.py | 17 +- > .../misc/file_manager/static/js/file_manager.js | 6 +- > .../misc/file_manager/static/js/select_dialogue.js | 3 +- > .../file_manager/static/js/storage_dialogue.js | 45 +++ > web/pgadmin/misc/file_manager/static/js/utility.js | 76 ++++- > web/pgadmin/tools/backup/__init__.py | 5 + > .../tools/backup/tests/test_backup_message.py | 34 +- > web/pgadmin/tools/import_export/__init__.py | 93 ++++-- > .../import_export/tests/test_batch_process.py | 244 ++++++++++++++ > .../import_export/tests/test_create_export_job.py | 149 +++++++++ > .../import_export/tests/test_create_import_job.py | 241 ++++++++++++++ > .../test_import_export_create_job_unit_test.py | 353 > +++++++++++++++++++++ > .../tests/test_import_export_message.py | 135 ++++++++ > .../tests/test_import_export_utils.py | 194 +++++++++++ > web/pgadmin/tools/storage_manager/__init__.py | 75 +++++ > .../storage_manager/static/js/storage_manager.js | 93 ++++++ > .../javascript/file_manager/file_manager_specs.js | 18 ++ > web/webpack.config.js | 1 + > web/webpack.shim.js | 1 + > 24 files changed, 1842 insertions(+), 61 deletions(-) > > --000000000000b3fb3705b2926df4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

PFA minor pa= tch to remove dead code which was introduced with this patch.

--
Regards,
Murtuza Z= abuawala
EDB
POWER TO POSTGRES
=


On Fri, Oct 23, 2020 at 5:17 PM Akshay Joshi = <akshay.joshi@enterpris= edb.com> wrote:
Added support to download utility files at the client-side. Fixes #3= 318

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdi= ff;h=3Dc2ad97d0ab761ad57cf98b192ffe75e9a0d2605a
Author: Rahul Shirsat <rahul.shirsat@enterprisedb.com>

Modified Files
--------------
docs/en_US/release_notes_4_28.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01 +
web/pgadmin/misc/bgprocess/processes.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 58 +++-
.../misc/bgprocess/static/css/bgprocess.css=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 =C2=A04 +
.../misc/bgprocess/static/img/storage_manager.svg=C2=A0 |=C2=A0 13 +
web/pgadmin/misc/bgprocess/static/js/bgprocess.js=C2=A0 |=C2=A0 44 ++-
web/pgadmin/misc/file_manager/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= |=C2=A0 17 +-
.../misc/file_manager/static/js/file_manager.js=C2=A0 =C2=A0 |=C2=A0 =C2=A0= 6 +-
.../misc/file_manager/static/js/select_dialogue.js |=C2=A0 =C2=A03 +-
.../file_manager/static/js/storage_dialogue.js=C2=A0 =C2=A0 =C2=A0|=C2=A0 4= 5 +++
web/pgadmin/misc/file_manager/static/js/utility.js |=C2=A0 76 ++++-
web/pgadmin/tools/backup/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 =C2=A05 +
.../tools/backup/tests/test_backup_message.py=C2=A0 =C2=A0 =C2=A0 |=C2=A0 3= 4 +-
web/pgadmin/tools/import_export/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 93 ++++--
.../import_export/tests/test_batch_process.py=C2=A0 =C2=A0 =C2=A0 | 244 +++= +++++++++++
.../import_export/tests/test_create_export_job.py=C2=A0 | 149 +++++++++
.../import_export/tests/test_create_import_job.py=C2=A0 | 241 +++++++++++++= +
.../test_import_export_create_job_unit_test.py=C2=A0 =C2=A0 =C2=A0| 353 +++= ++++++++++++++++++
.../tests/test_import_export_message.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 135 ++++++++
.../tests/test_import_export_utils.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 | 194 +++++++++++
web/pgadmin/tools/storage_manager/__init__.py=C2=A0 =C2=A0 =C2=A0 |=C2=A0 7= 5 +++++
.../storage_manager/static/js/storage_manager.js=C2=A0 =C2=A0|=C2=A0 93 +++= +++
.../javascript/file_manager/file_manager_specs.js=C2=A0 |=C2=A0 18 ++
web/webpack.config.js=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01 +
web/webpack.shim.js=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A01 + 24 files changed, 1842 insertions(+), 61 deletions(-)

--000000000000b3fb3705b2926df4-- --000000000000b3fb3805b2926df6 Content-Type: application/octet-stream; name="remove_dead_code.diff" Content-Disposition: attachment; filename="remove_dead_code.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kgqj9fc00 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2ltcG9ydF9leHBvcnQvX19pbml0X18ucHkg Yi93ZWIvcGdhZG1pbi90b29scy9pbXBvcnRfZXhwb3J0L19faW5pdF9fLnB5CmluZGV4IGQxMTll OTc5Zi4uMWY2MjA0ZTgxIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9pbXBvcnRfZXhw b3J0L19faW5pdF9fLnB5CisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2ltcG9ydF9leHBvcnQvX19p bml0X18ucHkKQEAgLTEzNiwyNyArMTM2LDYgQEAgY2xhc3MgSUVNZXNzYWdlKElQcm9jZXNzRGVz Yyk6CiAgICAgICAgIF90eXBlX2Rlc2MgPSBfKCJJbXBvcnQgLSAiKSBpZiBzZWxmLmlzX2ltcG9y dCBlbHNlIF8oIkV4cG9ydCAtICIpCiAgICAgICAgIHJldHVybiBfdHlwZV9kZXNjICsgXygiQ29w eWluZyB0YWJsZSBkYXRhIikKIAotICAgICMgQHByb3BlcnR5Ci0gICAgIyBkZWYgY3VycmVudF9z dG9yYWdlX2RpcihzZWxmKToKLSAgICAjCi0gICAgIyAgICAgaWYgY29uZmlnLlNFUlZFUl9NT0RF OgotICAgICMgICAgICAgICBwYXRoID0gb3MucGF0aC5yZWFscGF0aChzZWxmLmJmaWxlKQotICAg ICMgICAgICAgICBpZiBnZXRfc3RvcmFnZV9kaXJlY3RvcnkoKSA8IHBhdGg6Ci0gICAgIyAgICAg ICAgICAgICBzdG9yYWdlX2RpcmVjdG9yeSA9IG9zLnBhdGguYmFzZW5hbWUoZ2V0X3N0b3JhZ2Vf ZGlyZWN0b3J5KCkpCi0gICAgIyAgICAgICAgICAgICBzdGFydCA9IHBhdGguaW5kZXgoc3RvcmFn ZV9kaXJlY3RvcnkpCi0gICAgIyAgICAgICAgICAgICBlbmQgPSBzdGFydCArIChsZW4oc3RvcmFn ZV9kaXJlY3RvcnkpKQotICAgICMKLSAgICAjICAgICAgICAgICAgIGxhc3RfZGlyID0gb3MucGF0 aC5kaXJuYW1lKHBhdGhbZW5kOl0pCi0gICAgIyAgICAgICAgIGVsc2U6Ci0gICAgIyAgICAgICAg ICAgICBsYXN0X2RpciA9ICdcXCcKLSAgICAjCi0gICAgIyAgICAgZWxzZToKLSAgICAjICAgICAg ICAgbGFzdF9kaXIgPSBvcy5wYXRoLmRpcm5hbWUoc2VsZi5iZmlsZSkgXAotICAgICMgICAgICAg ICAgICAgaWYgb3MucGF0aC5pc2ZpbGUoc2VsZi5iZmlsZSkgXAotICAgICMgICAgICAgICAgICAg ZWxzZSBzZWxmLmJmaWxlCi0gICAgIwotICAgICMgICAgIHJldHVybiBOb25lIGlmIHNlbGYuaXNf aW1wb3J0IGVsc2UgbGFzdF9kaXIKLQogICAgIGRlZiBkZXRhaWxzKHNlbGYsIGNtZCwgYXJncyk6 CiAgICAgICAgICMgRmV0Y2ggdGhlIHNlcnZlciBkZXRhaWxzIGxpa2UgaG9zdG5hbWUsIHBvcnQs IHJvbGVzIGV0YwogICAgICAgICBuYW1lLCBob3N0LCBwb3J0ID0gc2VsZi5nZXRfc2VydmVyX2Rl dGFpbHMoKQo= --000000000000b3fb3805b2926df6--