public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the
Date: Tue, 9 Feb 2021 20:15:28 +0530
Message-ID: <CAKKotZRf55wO1Lhq_T=cDX5iSjq8_paniFKsS-jY+-55d3jZhg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcyOUPg-550596eyubsv_n1zDcB839xWntusHpc+SYZFA@mail.gmail.com>
References: <[email protected]>
<CAKKotZSMqspSZ=_m6P0H5QpuAPzauTWaSfuAhMGbhGt3_Wt-Tg@mail.gmail.com>
<CANxoLDcyOUPg-550596eyubsv_n1zDcB839xWntusHpc+SYZFA@mail.gmail.com>
Hi,
On Tue, Feb 9, 2021 at 7:37 PM Akshay Joshi <[email protected]>
wrote:
> Hi Murtuza/Hackers
>
> On Tue, Feb 9, 2021 at 4:51 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> It will break the WSGI.
>>
>
> I have tested pgAdmin4 using the following combination:
>
> - Python wheel package + Apache (WSGI) on Ubuntu 18.04 (Fresh VM)
> - APT https://www.pgadmin.org/download/pgadmin-4-apt/ on Ubuntu 18.04
> (Fresh VM)
>
> I have made the code changes after installation, use sys.executable,
> and then restart the apache in both the above test scenario. All the
> utilities(Backup, Maintainance, etc...) working absolutely fine. Please
> refer to the below screenshot
>
> [image: pgAdmin_APT.png]
>
> Am I missing some scenario? If any specific test scenario that I missed
> please let me know so that I'll figure out some solution.
>
I don't remember the exact scenario/steps but AFAIR we rewrote that logic
to handle scenario when we run pgAdmin4 under WSGI and/or on Windows, It
was using the wrong python path to execute the process executor.
-- Murtuza
>
>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>>
>> On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Use 'sys.executable' to get the absolute path of the executable binary
>>> for the Python interpreter instead of existing complex logic.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>>
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d6...
>>>
>>> Modified Files
>>> --------------
>>> web/pgadmin/misc/bgprocess/processes.py | 89
>>> +--------------------------------
>>> 1 file changed, 1 insertion(+), 88 deletions(-)
>>>
>>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachments:
[image/png] pgAdmin_APT.png (474.9K, 3-pgAdmin_APT.png)
download | view image
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the
In-Reply-To: <CAKKotZRf55wO1Lhq_T=cDX5iSjq8_paniFKsS-jY+-55d3jZhg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox