Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkhLh-0006JO-LP for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Dec 2020 05:40:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kkhLf-0004Vo-Cd for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Dec 2020 05:40:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkhLe-0004Qi-Jy for pgadmin-hackers@lists.postgresql.org; Thu, 03 Dec 2020 05:40:10 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kkhLW-000157-J8 for pgadmin-hackers@lists.postgresql.org; Thu, 03 Dec 2020 05:40:08 +0000 Received: by mail-oi1-x242.google.com with SMTP id k2so974433oic.13 for ; Wed, 02 Dec 2020 21:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KmoWT0rzhQese0hHOaWC1u5lenRt0tTGQ89yRJoGrR8=; b=ZEGsqHDUnTK5Y56z2wHqOLbZmVM4GyJFCgc9ONDXlp6sXdpS5Koczs88vSUc8PxvIH hxcBHt7gkBcettmcO7aIwc3I8iqOMoOMxKcE3Yk4UVzRNPFvmYI2x732kwU5YbYYVsMR eojrwXD8IX3DJxcOkf8le9SnkJpQjJBKK4H4zzCijBQl71+WSfwKm0TogHNQcnb7ZezY TpL+inu3pVHRGmlT2K/3YZccV7jPy4BWu2QChqgD8jlk2FpV3EtSVVqv+v/pU0WCgTG5 8My2K+XBIujPT6ApY9e+ua31tdIt1qtivEvJu4cZtG3WKvnWDb4ty1GAT5r6wiol/QuJ LCng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KmoWT0rzhQese0hHOaWC1u5lenRt0tTGQ89yRJoGrR8=; b=tNzgmPv2igY12AseyobqN/c6xpRbp/1jfjJEwB73iGrcWU57OvoOEy4shl1b4honWD kZRnycgDIMH3xMEwjlTTb3jpP8hYpC7ZvO1iWJuh99KlkebLglKsm1BVLSUwkjhXhU0f 8x2AOIsx8hrNnApMBnnPUCLQuydHjy7Tj7S/Jnw5xa5A1Eu8QNk8kSesAB1tk863wVUa ugZiXBl4THeFDitw1IQAVnFR7QghkZd/FLhanKIxVuMhvh1bVtPHGVi+KpWhzgGVuUAF PL+J8Ao9ZVtCOrlcwkH2sZW9g9DI4UaRKqTs3AbuZjAS9AxX4bGpc3bW6gHLJgswd3R7 9uAA== X-Gm-Message-State: AOAM531BKDoor9lvHU0fv9xKv1qBL5D5YUkoDdt1SX4zIC8L+Fn3ekJK uBxdCZjRFwBdVilkTsGPp9n1nj4sAttWHcB5e4CIF3ptxHxbh3Gnr/74fdyJQvjbOIXRD/udIHK AD2kp1/P1lOmJDqvRKBDxOmErC7tcMh7BWskECe0ttq4JfaHzdMlb81HPMpGIovsnijb5J5mXNl EFXCA8yp2dcmPxshhJajdMoHJ991GlgOVDOYoxIf5Ysj5nn2o98LTSj5/hgoJDnHGGPLQeU2GD2 w== X-Google-Smtp-Source: ABdhPJzg9LtPlTT2x6YBafWtHqitVqjLRl0ghojhOmKGxIoQ697YMZk4cM2WdWCGMM/8oxmPXOmsEdtQTAXwhobHvyQ= X-Received: by 2002:aca:acca:: with SMTP id v193mr873257oie.41.1606974001958; Wed, 02 Dec 2020 21:40:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Murtuza Zabuawala Date: Thu, 3 Dec 2020 11:09:46 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Fixed an issue where the validation error message is To: Akshay Joshi , Rahul Shirsat Cc: pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary="0000000000008cebbd05b588cac0" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008cebbd05b588cac0 Content-Type: text/plain; charset="UTF-8" Hello, What is the reason for adding delay *setTimeout(, 120)*? This is causing issues in automation testing and makes buttons enable/disable with slight delay. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi wrote: > Fixed an issue where the validation error message is shown twice. Fixes > #5736 > > Branch > ------ > master > > Details > ------- > > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=183c83f0d2b2cb8dd33f9e8c41a030bc4cdaa4b2 > Author: Rahul Shirsat > > Modified Files > -------------- > docs/en_US/release_notes_4_28.rst | 1 + > web/pgadmin/browser/static/js/datamodel.js | 75 > +++++++++++++++++++++++++++++- > web/pgadmin/static/js/backform.pgadmin.js | 24 ++++------ > web/pgadmin/static/scss/_alert.scss | 6 +++ > 4 files changed, 90 insertions(+), 16 deletions(-) > > --0000000000008cebbd05b588cac0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

What is t= he reason for adding delay=C2=A0setTimeout(<func>, 120)?
=

This is causing issues in automation testing an= d makes buttons enable/disable with slight delay.

<= div>
=
--
Regards,
Murtuza Zabuawala
E= DB
POWE= R TO POSTGRES
=


On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi <akshay.joshi@enterprisedb.com>= ; wrote:
Fixed an issue where the validation erro= r message is shown twice. Fixes #5736

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdi= ff;h=3D183c83f0d2b2cb8dd33f9e8c41a030bc4cdaa4b2
Author: Rahul Shirsat <rahul.shirsat@enterprisedb.com>

Modified Files
--------------
docs/en_US/release_notes_4_28.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0= 1 +
web/pgadmin/browser/static/js/datamodel.js | 75 +++++++++++++++++++++++++++= ++-
web/pgadmin/static/js/backform.pgadmin.js=C2=A0 | 24 ++++------
web/pgadmin/static/scss/_alert.scss=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 6 ++= +
4 files changed, 90 insertions(+), 16 deletions(-)

--0000000000008cebbd05b588cac0--