public inbox for [email protected]  
help / color / mirror / Atom feed
[pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session
3+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session
@ 2019-01-18 14:32  Murtuza Zabuawala <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Murtuza Zabuawala @ 2019-01-18 14:32 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

PFA minor patch to fix the regression issue where a user kills the session
from the dashboard grid, but the grid was not getting refreshed and the
killed session was not getting removed from it.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachments:

  [application/octet-stream] fix_dashboard_gird_refresh_issue.diff (733B, 3-fix_dashboard_gird_refresh_issue.diff)
  download | inline diff:
diff --git a/web/pgadmin/dashboard/static/js/dashboard.js b/web/pgadmin/dashboard/static/js/dashboard.js
index 5b9c4026..3c9a43a3 100644
--- a/web/pgadmin/dashboard/static/js/dashboard.js
+++ b/web/pgadmin/dashboard/static/js/dashboard.js
@@ -70,12 +70,8 @@ define('pgadmin.dashboard', [
         return;
 
       // This will refresh the grid
-      var refresh_grid = function() {
-        if (is_server_dashboard) {
-          $('#btn_server_activity_refresh').trigger('click');
-        } else if (is_database_dashboard) {
-          $('#btn_database_activity_refresh').trigger('click');
-        }
+      let refresh_grid = () => {
+        $('#btn_refresh').trigger('click');
       };
 
       if (cell_action === 'cancel') {


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: [pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session
@ 2019-01-22 06:51  Murtuza Zabuawala <[email protected]>
  parent: Murtuza Zabuawala <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Murtuza Zabuawala @ 2019-01-22 06:51 UTC (permalink / raw)
  To: pgadmin-hackers

++ Gentle reminder


On Fri, Jan 18, 2019 at 8:02 PM Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA minor patch to fix the regression issue where a user kills the session
> from the dashboard grid, but the grid was not getting refreshed and the
> killed session was not getting removed from it.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: [pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session
@ 2019-01-22 08:56  Akshay Joshi <[email protected]>
  parent: Murtuza Zabuawala <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Akshay Joshi @ 2019-01-22 08:56 UTC (permalink / raw)
  To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers

Thanks patch applied.

On Tue, Jan 22, 2019 at 12:21 PM Murtuza Zabuawala <
[email protected]> wrote:

> ++ Gentle reminder
>
>
> On Fri, Jan 18, 2019 at 8:02 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the regression issue where a user kills the
>> session from the dashboard grid, but the grid was not getting refreshed and
>> the killed session was not getting removed from it.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2019-01-22 08:56 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 14:32 [pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session Murtuza Zabuawala <[email protected]>
2019-01-22 06:51 ` Murtuza Zabuawala <[email protected]>
2019-01-22 08:56   ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox