Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqgtO-0006at-Ro for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 15:10:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eqgtN-0002bu-Ov for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 15:10:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqgtN-0002bk-IA for pgadmin-hackers@lists.postgresql.org; Tue, 27 Feb 2018 15:10:09 +0000 Received: from mail-ot0-x22c.google.com ([2607:f8b0:4003:c0f::22c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eqgtF-0001xg-V8 for pgadmin-hackers@postgresql.org; Tue, 27 Feb 2018 15:10:08 +0000 Received: by mail-ot0-x22c.google.com with SMTP id w2so1494226otg.2 for ; Tue, 27 Feb 2018 07:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SgSLDpATe9znfmm3Lp9Tgyo+X22/YbAaVHpSfhnZLW0=; b=s3rJsBr4QqwBITG3s6jc2pZ8AbQBTvMrK3P+ldgULUtRXwGssS2TNXXeRoT9otiROR aqb0H53EPhmxXywfxKwgtg7cXSyHCAymKUH4UEOVARkHWoH+THmZwx/6Gs0N0EaMtj1J A1AUBdtcxTRMi67MMBVG2vYagnXoxNX4eyWbYQS9fdq4BxOBpe7wSJL7FcGoz53M0x+G 3LdqYeDRg5kxGkcB9L/15aVZo5vze+Byvl0YbcjdbwyJTSU84CZHbyaccyqbNhd2zRtz OpUtQ/GqY2W5rmHQ+jEPgwSiZSESE1JHIGKN0aItcUk9uFwP97YhSqPnq/8FaEIStl6T 7eTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SgSLDpATe9znfmm3Lp9Tgyo+X22/YbAaVHpSfhnZLW0=; b=SHUn2Ln6CCzPZ13VEuz0neoUH6nn6jsEmZlI5F+Q1xScxjQnhd8fQoWiEKCOch0mhD uouMder6hPMWXM0Y7T1kv3dAmZ6VvluBUYT1qfWYc3lh6T0k0k+TZV3WqJVAZtUyDBR6 h92jY+ci4IvY1a22j3UMR1s1JvIKeNlbGZ3fy6fYovA5e4ITBMr6xSVRGlNj/2J2uLAC 5/25O2RD7avBbQ0NnPwDZAzeEtE8LqY2vpwyOHpWPTlYbHtYSgX7MAAYdn8Os2fZZD+d oFVmz7h7oSDMksMXC/hhnw/gO8UwrTbFEkvov5Tw3aa//a2SLk04V8Mr9CGdf9UoIa1Q 5tww== X-Gm-Message-State: APf1xPCV//ucvtdhLNuwBHa/g2EycrR9e/W/RIZejpgq2oRATxwQlLJT j9FeqIYyuDIt8tuCPm1qj64nfe6ceWNz9sxIPr07kw== X-Google-Smtp-Source: AG47ELsnBslWrwKbYlbse+Vq8oVpS11avGHxKMbds7MPh6RbDIc8pCiAW1M81jGNRMnhh2UVSm9xRJr5cWdLbyemuHc= X-Received: by 10.157.22.233 with SMTP id s38mr10341964ots.97.1519744199684; Tue, 27 Feb 2018 07:09:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Tue, 27 Feb 2018 07:09:39 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Tue, 27 Feb 2018 20:39:39 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114790ea2c177105663305d8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114790ea2c177105663305d8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =E2=80=8BThanks Dave, I'll look into it. =E2=80=8B On Tue, Feb 27, 2018 at 8:37 PM, Dave Page wrote: > Hi > > On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> I'm not able to re-produce the issue, Could you hard refresh and try >> again? >> > > I still see it. > > >> >> If possible could you please provide exact steps? >> > > Attached is a dump of my test pgagent schema. > > 1) Load the schema dump into the maintenance database > 2) Connect pgAdmin > 3) Browse to pgAgent Jobs > 4) Right-click Properties, and select the Schedules tab > 5) Open the subnode for sched1 > > >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page wrote: >> >>> Sorry - here it is. >>> >>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Could you please send screenshot? >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> Still not quite right - see the attached screenshot which is the >>>>> result of simply viewing the properties of an existing job. Note that= the >>>>> start time is shown in the grid but not the subnode control. >>>>> >>>>> Thanks. >>>>> >>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> As validation related patch was committed with RM#3148 [ Sorry about >>>>>> that I forgot to checkout :) ] >>>>>> PFA patch to fix the issues you mentioned, I have also removed extra >>>>>> error message from sub node collection control and made it optional = via >>>>>> flag. >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page >>>>>> wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> PFA patch to fix the issue where user was not able to create >>>>>>>> pgAgent job from UI without entering End date in schedule section. >>>>>>>> >>>>>>> >>>>>>> Whilst this does resolve the validation issue, there are still a >>>>>>> couple of other related problems, as can be seen in the attached >>>>>>> screenshots: >>>>>>> >>>>>>> - The Start date/time in the subnode control doesn't seem to be >>>>>>> properly synchronised with the value in the grid. >>>>>>> >>>>>>> - If you leave the End date/time blank (but maybe click into it >>>>>>> first), the grid will show "Invalid date". >>>>>>> >>>>>>> It's possible there are other oddities as well - please check >>>>>>> carefully for anything else. >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114790ea2c177105663305d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=E2=80=8BThanks Dave, I'll look into it.
<= /div>
=E2=80=8B


On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I'm not able to re-produce the issue, Could yo= u hard refresh and try again?

I still see it.
=C2=A0
<= br>
If pos= sible could you please provide exact steps?
Attached is a dump of my test pgagent schema.

1) Load the schema dump into the maintenance database
2)= Connect pgAdmin
3) Browse to pgAgent Jobs
4) Right-cli= ck Properties, and select the Schedules tab
5) Open the subnode f= or sched1
=C2=A0

--
Regards,
Murtuza Zabu= awala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The = Enterprise PostgreSQL Company


On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <dpage@pgadmin.org&g= t; wrote:
Sorry -= here it is.

On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <= mur= tuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

Could you please send screenshot?

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://= www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Feb 27, 2018 at 5= :24 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Still not quite r= ight - see the attached screenshot which is the result of simply viewing th= e properties of an existing job. Note that the start time is shown in the g= rid but not the subnode control.

Thanks.

On Tue, Feb 27,= 2018 at 8:26 AM, Murtuza Zabuawala <murtuza.zabuawala@en= terprisedb.com> wrote:
Hi Dave,

As validation related patch was committed with RM#3148 [ Sor= ry about that I forgot to checkout :)=C2=A0]
PFA patch to fix the issues you me= ntioned, I have also removed extra error message from sub node collection c= ontrol and made it optional via flag.



--
Regards,
= Murtuza Zabuawala
E= nterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise= PostgreSQL Company


On Mon, Feb 26, 2018 at 10:14 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where user was not able to create = pgAgent job from UI without entering End date in schedule section.

=C2=A0Whilst this does resolve the vali= dation issue, there are still a couple of other related problems, as can be= seen in the attached screenshots:

- The Start dat= e/time in the subnode control doesn't seem to be properly synchronised = with the value in the grid.

- If you leave the End= date/time blank (but maybe click into it first), the grid will show "= Invalid date".

It'= s possible there are other oddities as well - please check carefully for an= ything else.

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot= .com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The= Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y




--
Dave Page
Blog: http://pgsnake.blogspot.com<= /a>
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company



--
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company
--001a114790ea2c177105663305d8--