public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4] Fix context menu CSS
4+ messages / 3 participants
[nested] [flat]

* [pgAdmin4] Fix context menu CSS
@ 2019-12-04 09:06 Murtuza Zabuawala <[email protected]>
  2019-12-04 10:52 ` Re: [pgAdmin4] Fix context menu CSS Dave Page <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Murtuza Zabuawala @ 2019-12-04 09:06 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

PFA patch to fix the issue where we have context menu open along with
submenu and the focus is not on context menu or submenu then it was picking
the CSS from jquery.contextMenu.scss and displaying different color then
the selected theme.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachments:

  [application/octet-stream] fix_context_menu_color.diff (748B, 3-fix_context_menu_color.diff)
  download | inline diff:
diff --git a/web/pgadmin/static/scss/_webcabin.pgadmin.scss b/web/pgadmin/static/scss/_webcabin.pgadmin.scss
index fca37c9795..7a7dd658dd 100644
--- a/web/pgadmin/static/scss/_webcabin.pgadmin.scss
+++ b/web/pgadmin/static/scss/_webcabin.pgadmin.scss
@@ -271,7 +271,7 @@
   background-color: $dropdown-bg;
 }
 
-.wcMenuItemHover, .wcMenuItem:hover, .context-menu-item:not(.context-menu-not-selectable).hover, .context-menu-item:not(.context-menu-not-selectable):hover {
+.wcMenuItemHover, .wcMenuItem:hover, .context-menu-item:not(.context-menu-not-selectable).hover, .context-menu-item:not(.context-menu-not-selectable):hover, .context-menu-hover {
   color: $dropdown-link-hover-color;
   background-color: $dropdown-link-hover-bg !important;
 }


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgAdmin4] Fix context menu CSS
  2019-12-04 09:06 [pgAdmin4] Fix context menu CSS Murtuza Zabuawala <[email protected]>
@ 2019-12-04 10:52 ` Dave Page <[email protected]>
  2019-12-04 12:29   ` Re: [pgAdmin4] Fix context menu CSS Murtuza Zabuawala <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Dave Page @ 2019-12-04 10:52 UTC (permalink / raw)
  To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers

Hi

Is there an RM for this?

On Wed, Dec 4, 2019 at 4:06 AM Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA patch to fix the issue where we have context menu open along with
> submenu and the focus is not on context menu or submenu then it was picking
> the CSS from jquery.contextMenu.scss and displaying different color then
> the selected theme.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgAdmin4] Fix context menu CSS
  2019-12-04 09:06 [pgAdmin4] Fix context menu CSS Murtuza Zabuawala <[email protected]>
  2019-12-04 10:52 ` Re: [pgAdmin4] Fix context menu CSS Dave Page <[email protected]>
@ 2019-12-04 12:29   ` Murtuza Zabuawala <[email protected]>
  2019-12-05 05:46     ` Re: [pgAdmin4] Fix context menu CSS Akshay Joshi <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Murtuza Zabuawala @ 2019-12-04 12:29 UTC (permalink / raw)
  To: Dave Page <[email protected]>; +Cc: pgadmin-hackers

Hi Dave,

On Wed, Dec 4, 2019 at 4:22 PM Dave Page <[email protected]> wrote:

> Hi
>
> Is there an RM for this?
>

I've created RM#4991 <https://redmine.postgresql.org/issues/4991;
Thanks,
Murtuza

>
> On Wed, Dec 4, 2019 at 4:06 AM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue where we have context menu open along with
>> submenu and the focus is not on context menu or submenu then it was picking
>> the CSS from jquery.contextMenu.scss and displaying different color then
>> the selected theme.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgAdmin4] Fix context menu CSS
  2019-12-04 09:06 [pgAdmin4] Fix context menu CSS Murtuza Zabuawala <[email protected]>
  2019-12-04 10:52 ` Re: [pgAdmin4] Fix context menu CSS Dave Page <[email protected]>
  2019-12-04 12:29   ` Re: [pgAdmin4] Fix context menu CSS Murtuza Zabuawala <[email protected]>
@ 2019-12-05 05:46     ` Akshay Joshi <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: Akshay Joshi @ 2019-12-05 05:46 UTC (permalink / raw)
  To: Murtuza Zabuawala <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers

Thanks, patch applied.

On Wed, Dec 4, 2019 at 6:00 PM Murtuza Zabuawala <
[email protected]> wrote:

> Hi Dave,
>
> On Wed, Dec 4, 2019 at 4:22 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Is there an RM for this?
>>
>
> I've created RM#4991 <https://redmine.postgresql.org/issues/4991;
> Thanks,
> Murtuza
>
>>
>> On Wed, Dec 4, 2019 at 4:06 AM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where we have context menu open along with
>>> submenu and the focus is not on context menu or submenu then it was picking
>>> the CSS from jquery.contextMenu.scss and displaying different color then
>>> the selected theme.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

end of thread, other threads:[~2019-12-05 05:46 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 09:06 [pgAdmin4] Fix context menu CSS Murtuza Zabuawala <[email protected]>
2019-12-04 10:52 ` Dave Page <[email protected]>
2019-12-04 12:29   ` Murtuza Zabuawala <[email protected]>
2019-12-05 05:46     ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox