Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Zxc-0004Fp-6t for pgadmin-hackers@arkaria.postgresql.org; Fri, 05 May 2017 09:55:40 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d6Zxb-0002E3-Pm for pgadmin-hackers@arkaria.postgresql.org; Fri, 05 May 2017 09:55:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d6ZxN-0001p0-Gc for pgadmin-hackers@postgresql.org; Fri, 05 May 2017 09:55:25 +0000 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d6ZxJ-0000Wp-3l for pgadmin-hackers@postgresql.org; Fri, 05 May 2017 09:55:24 +0000 Received: by mail-wr0-x229.google.com with SMTP id w50so824450wrc.0 for ; Fri, 05 May 2017 02:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=R6eB3YOkk/Q1MboCFQURd4zsspQkjXjXGFB8gA8vCCc=; b=TGS6jqtAay/9o1sspKBdgtZOkrNwLP5Sbaak85dNkhdiJaln+jXr7IZWW3koyiS/aX I7DG01hNDC9cQIEi3kl2f7iB4udraoeqsv8LB1Joy6xja5VzSgahiTxjIRdt7YeZk2Gk mRpsdPzI36xb1G64p05aFEf0CAjqes7L6H4OXRhz0rGLcOeuDScCI9U4z8BgJOSQv2Cx Ycxgvhw/oG37R/5jISDpZwrZxXCMAqN7DdwfKVXM8uEur+DcV2VqWQMBEyDrRN+Z5W+D kqGMS5T31NqF+N7guLKQmm8CQYKKqbCw9szaF9pPkVcwyVlMiuSl2sMX4pKYlG5U7iqM 291g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=R6eB3YOkk/Q1MboCFQURd4zsspQkjXjXGFB8gA8vCCc=; b=b8JlOIp2r9xPAyeFTBDI/c3VSFN2X8za0aESkfTxoxPhKf4eXACTumYwN/qarHkAVw uvlE0bWOpRK59FuV05ikrMiMdJPUXQbgbOf1Z/dVRiVpYBFqASTmfU0++KYYYkbs1atk EmvuPLoxRFLRGJfhysH7AMBVpIL71KypAHIp+3Wc4lU5X2MoFjjFytycUbLJRJIhHqSR Y7Y8yOzYp/OLgReXZgpwsJrJprbyeFut5TYo2wK/Z6dHEbcbk1YGcjzMJTtOnsfpzwAz 17fST+AxvxE485DWTenkNjtYf3i3b3C7XIivArUo/J3D9CARDKOXXoQl1+YS7+r3Nhr2 HC+Q== X-Gm-Message-State: AN3rC/5qtvJl81rpKxyqG6obj3JtFCYoQNyoOa8pGJAYLhG4PArwtzRN qGGYbkrlOsRIUojXdKAxD5/8GlHhgjkVh1o= X-Received: by 10.223.165.94 with SMTP id j30mr34172456wrb.111.1493978119081; Fri, 05 May 2017 02:55:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.136.70 with HTTP; Fri, 5 May 2017 02:54:58 -0700 (PDT) From: Murtuza Zabuawala Date: Fri, 5 May 2017 15:24:58 +0530 Message-ID: Subject: [pgAdmin4][PATCH] SlickGrid column resize triggers column select To: pgadmin-hackers Content-Type: multipart/mixed; boundary=f403045f240c1753b9054ec3e384 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --f403045f240c1753b9054ec3e384 Content-Type: multipart/alternative; boundary=f403045f240c1753b3054ec3e382 --f403045f240c1753b3054ec3e382 Content-Type: text/plain; charset=UTF-8 Hi, PFA patch to fix the issue where in SlickGrid column resize also triggers 'onHeaderClick' event and triggers column selection, In this scenario before drag event which column is under mouse gets selected, So to fix the issue we will check if header checkbox is clicked. RM#2348 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045f240c1753b3054ec3e382 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

PFA patch to fix the issue where in= SlickGrid column resize also triggers 'onHeaderClick' event and tr= iggers column selection, In this scenario=C2=A0before drag event which colu= mn is under mouse gets selected, So to fix the issue we will check if heade= r checkbox is clicked.
RM#2348

Please re= view.

--
Regards,Mur= tuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
= The Enterprise PostgreSQL Company
--f403045f240c1753b3054ec3e382-- --f403045f240c1753b9054ec3e384 Content-Type: text/plain; charset=US-ASCII; name="RM_2348.diff" Content-Disposition: attachment; filename="RM_2348.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j2bnzc570 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zZWxlY3Rpb24v Y29sdW1uX3NlbGVjdG9yLmpzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL3Nl bGVjdGlvbi9jb2x1bW5fc2VsZWN0b3IuanMKaW5kZXggYzg5YjNmYS4uNTI2 MGZjMyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL3NlbGVj dGlvbi9jb2x1bW5fc2VsZWN0b3IuanMKKysrIGIvd2ViL3BnYWRtaW4vc3Rh dGljL2pzL3NlbGVjdGlvbi9jb2x1bW5fc2VsZWN0b3IuanMKQEAgLTYsMTIg KzYsMTAgQEAgZGVmaW5lKFsnanF1ZXJ5JywgJ3NvdXJjZXMvc2VsZWN0aW9u L3JhbmdlX3NlbGVjdGlvbl9oZWxwZXInLCAnc2xpY2tncmlkJ10sIGZ1bmMK IAogICAgICAgICAgIGlmIChjb2x1bW4uc2VsZWN0YWJsZSAhPT0gZmFsc2Up IHsKIAotICAgICAgICAgICAgaWYgKCFjbGlja2VkQ2hlY2tib3goZXZlbnQp KSB7CisgICAgICAgICAgICBpZiAoY2xpY2tlZENoZWNrYm94KGV2ZW50KSkg ewogICAgICAgICAgICAgICB2YXIgJGNoZWNrYm94ID0gJCgiW2RhdGEtaWQ9 J2NoZWNrYm94LSIgKyBjb2x1bW4uaWQgKyAiJ10iKTsKLSAgICAgICAgICAg ICAgdG9nZ2xlQ2hlY2tib3goJGNoZWNrYm94KTsKKyAgICAgICAgICAgICAg dXBkYXRlUmFuZ2VzKGdyaWQsIGNvbHVtbi5pZCk7CiAgICAgICAgICAgICB9 Ci0KLSAgICAgICAgICAgIHVwZGF0ZVJhbmdlcyhncmlkLCBjb2x1bW4uaWQp OwogICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgKTsKQEAgLTU1LDE0 ICs1Myw2IEBAIGRlZmluZShbJ2pxdWVyeScsICdzb3VyY2VzL3NlbGVjdGlv bi9yYW5nZV9zZWxlY3Rpb25faGVscGVyJywgJ3NsaWNrZ3JpZCddLCBmdW5j CiAgICAgICByZXR1cm4gZS50YXJnZXQudHlwZSA9PSAiY2hlY2tib3giCiAg ICAgfTsKIAotICAgIHZhciB0b2dnbGVDaGVja2JveCA9IGZ1bmN0aW9uIChj aGVja2JveCkgewotICAgICAgaWYgKGNoZWNrYm94LnByb3AoImNoZWNrZWQi KSkgewotICAgICAgICBjaGVja2JveC5wcm9wKCJjaGVja2VkIiwgZmFsc2Up Ci0gICAgICB9IGVsc2UgewotICAgICAgICBjaGVja2JveC5wcm9wKCJjaGVj a2VkIiwgdHJ1ZSkKLSAgICAgIH0KLSAgICB9OwotCiAgICAgdmFyIGdldENv bHVtbkRlZmluaXRpb25zV2l0aENoZWNrYm94ZXMgPSBmdW5jdGlvbiAoY29s dW1uRGVmaW5pdGlvbnMpIHsKICAgICAgIHJldHVybiBfLm1hcChjb2x1bW5E ZWZpbml0aW9ucywgZnVuY3Rpb24gKGNvbHVtbkRlZmluaXRpb24pIHsKICAg ICAgICAgaWYgKGNvbHVtbkRlZmluaXRpb24uc2VsZWN0YWJsZSAhPT0gZmFs c2UpIHsK --f403045f240c1753b9054ec3e384 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --f403045f240c1753b9054ec3e384--