Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhsfo-0003X7-Jf for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Sep 2016 06:18:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bhsfn-0005GJ-Ke for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Sep 2016 06:18:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bhsfm-0005Fy-Iy for pgadmin-hackers@postgresql.org; Thu, 08 Sep 2016 06:18:54 +0000 Received: from mail-qk0-x231.google.com ([2607:f8b0:400d:c09::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bhsfi-0002hW-6J for pgadmin-hackers@postgresql.org; Thu, 08 Sep 2016 06:18:53 +0000 Received: by mail-qk0-x231.google.com with SMTP id m184so32240810qkb.1 for ; Wed, 07 Sep 2016 23:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=R6VBjBPCROoOHrimhX7s0sRUHJNuCRivhhpOeEO/UQQ=; b=sX2Aj3r1jrvtEAfi8gZ/rhusXig+VnMnbjnPF4QCSwWD/9s5VrfOm3cehYxsS7YnA6 URpgKB9CJVu3egPDW5nShxrWyXv8SslUd5CH28kVWPmv2U/qsJacNBsT3awDh3L2pRRJ E3usQ76bTuRbMdo6k765GiiLkcb4FxpTM+uamd+k1NRtiAitpZJhZ+hgEQOfsKx/DNG1 NHohzv3uBm1XkcMRhVWH0hys0bRmaAWtkmXwyh5KirQcR5+JptBB8Zk98a+lpkf/y9gK hDMg6eiKuBjWqlxyQt/mMxwkx2rIscvW9CpVgrhmuxV71+ZigENPDp1Oq9lKfoCQ0OPh Qjnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=R6VBjBPCROoOHrimhX7s0sRUHJNuCRivhhpOeEO/UQQ=; b=VfaD7RVkkfT6jr47NLP691zG90CjMHVWmtJXSP9KjS2qCg/IZAnsWT0YOEnkq4dQm+ OPmlKX7k5qqNdYyZo6/RI/hLhqKGFsgsAusUsIiRXIFDVo+eCGj8Y4rSWkA91OMRJB7U CPWdoxGpHHjBdp2ydHd8gMzzdM27AkQiM1WdSu1/vWbPGoEEgfjwrlJGSAdjMNSOEwu1 yXpil2zXPxslGKow+zV89G2xWuzqXV1yBwHSBT0YQLq/1gCVhMesT/FNHXcLIch5rumd TftC2kGrEZx9iiSN/i5ymaHPUNnuzcLOfFZ3Vgnpp/IgqqA0UVIcZckPCWP15zDOyfBM MIUQ== X-Gm-Message-State: AE9vXwNu4fWwk1pCrtmZOVjDaBioIMkb7qLDtwzooTM/VNVouJDFKlasWojuFqr9ffyHBS62eybLNm+9155ZazDk X-Received: by 10.55.132.71 with SMTP id g68mr58905151qkd.50.1473315527409; Wed, 07 Sep 2016 23:18:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.129.194 with HTTP; Wed, 7 Sep 2016 23:18:26 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 8 Sep 2016 11:48:26 +0530 Message-ID: Subject: Re: PATCH: Adding more confirmations in query tool (pgAdmin4) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=94eb2c0760dca768d7053bf9004b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c0760dca768d7053bf9004b Content-Type: multipart/alternative; boundary=94eb2c0760dca768d2053bf90049 --94eb2c0760dca768d2053bf90049 Content-Type: text/plain; charset=UTF-8 Hi Dave, Please find updated patch. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 7, 2016 at 7:30 PM, Dave Page wrote: > I think it's better to warn them as early as possible, as we do in > pgAdmin 3 (actually, there we just prompt them to save the changes, > but I think either is fine). > > On Wed, Sep 7, 2016 at 2:04 PM, Murtuza Zabuawala > wrote: > > Sure I'll do it, But I thought like let user traverse through file > manager > > (he may or may not select any file to load) and warn only if he/she try > to > > load file. > > > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Wed, Sep 7, 2016 at 6:30 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala > >> wrote: > >> > Hi, > >> > > >> > PFA patch to add more confirmations in query tool before taking any > >> > actions > >> > which might cause lose changes, > >> > - Clearing editor > >> > - Clearing history > >> > - Load file data > >> > RM#1666 > >> > > >> > Please review. > >> > >> Can you tweak it so that the confirmation is requested as soon as the > >> open file button is clicked, rather than when a file is selected > >> please? I think that's a little more 'normal' :-). > >> > >> Thanks! > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c0760dca768d2053bf90049 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

Please find updated patch.
Please review.

=
--
Regar= ds,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise P= ostgreSQL Company

On Wed, Sep 7, 2016 at 7:30 PM, Dave Page <= dpage@pgadmin.org> wrote:
I= think it's better to warn them as early as possible, as we do in
pgAdmin 3 (actually, there we just prompt them to save the changes,
but I think either is fine).

On Wed, Sep 7, 2016 at 2:04 PM, Murtuza Zabuawala
<murtuza.zabuawala= @enterprisedb.com> wrote:
> Sure I'll do it, But I thought like let user traverse through file= manager
> (he may or may not select any file to load) and warn only if he/she tr= y to
> load file.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Sep 7, 2016 at 6:30 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala
>> <murtuza.= zabuawala@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA patch to add more confirmations in query tool before taki= ng any
>> > actions
>> > which might cause lose changes,
>> > - Clearing editor
>> > - Clearing history
>> > - Load file data
>> >=C2=A0 RM#1666
>> >
>> > Please review.
>>
>> Can you tweak it so that the confirmation is requested as soon as = the
>> open file button is clicked, rather than when a file is selected >> please? I think that's a little more 'normal' :-).
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--94eb2c0760dca768d2053bf90049-- --94eb2c0760dca768d7053bf9004b Content-Type: text/x-patch; charset=US-ASCII; name="RM_1666_v2.patch" Content-Disposition: attachment; filename="RM_1666_v2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_isty02yv0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZW1w bGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVkaXRvci5qcyBiL3dlYi9wZ2FkbWlu L3Rvb2xzL3NxbGVkaXRvci90ZW1wbGF0ZXMvc3FsZWRpdG9yL2pzL3NxbGVk aXRvci5qcwppbmRleCA2MTUyNTVjLi5lMThlMjY4IDEwMDY0NAotLS0gYS93 ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVtcGxhdGVzL3NxbGVkaXRv ci9qcy9zcWxlZGl0b3IuanMKKysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3Fs ZWRpdG9yL3RlbXBsYXRlcy9zcWxlZGl0b3IvanMvc3FsZWRpdG9yLmpzCkBA IC00MTUsMTkgKzQxNSwxOSBAQCBkZWZpbmUoCiAgICAgICAvKiBUbyBwcm9t cHQgdXNlciBmb3IgdW5zYXZlZCBjaGFuZ2VzICovCiAgICAgICB1c2VyX2Nv bmZpcm1hdGlvbjogZnVuY3Rpb24ocGFuZWwsIG1zZykgewogICAgICAgICAv LyBJZiB0aGVyZSBpcyBhbnl0aGluZyB0byBzYXZlIHRoZW4gcHJvbXB0IHVz ZXIKLSAgICAgICAgICBhbGVydGlmeS5jb25maXJtKCd7eyBfKCdVbnNhdmVk IGNoYW5nZXMnKSB9fScsIG1zZywKLSAgICAgICAgICAgIGZ1bmN0aW9uKCkg ewotICAgICAgICAgICAgICAvLyBEbyBub3RoaW5nIGFzIHVzZXIgZG8gbm90 IHdhbnQgdG8gc2F2ZSwganVzdCBjb250aW51ZQotICAgICAgICAgICAgICB3 aW5kb3cub25iZWZvcmV1bmxvYWQgPSBudWxsOwotICAgICAgICAgICAgICBw YW5lbC5vZmYod2NEb2NrZXIuRVZFTlQuQ0xPU0lORyk7Ci0gICAgICAgICAg ICAgIHdpbmRvdy50b3AucGdBZG1pbi5Ccm93c2VyLmRvY2tlci5yZW1vdmVQ YW5lbChwYW5lbCk7Ci0gICAgICAgICAgICB9LAotICAgICAgICAgICAgZnVu Y3Rpb24oKSB7Ci0gICAgICAgICAgICAgIC8vIFN0b3AsIFVzZXIgd2FudHMg dG8gc2F2ZQotICAgICAgICAgICAgICAvLyBmYWxzZSB2YWx1ZSB3aWxsIHBy ZXZlbnQgZnJvbSBwYW5lbCB0byBjbG9zZQotICAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICApLnNldCgnbGFi ZWxzJywge29rOidZZXMnLCBjYW5jZWw6J05vJ30pOworICAgICAgICBhbGVy dGlmeS5jb25maXJtKCd7eyBfKCdVbnNhdmVkIGNoYW5nZXMnKSB9fScsIG1z ZywKKyAgICAgICAgICBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIC8vIERv IG5vdGhpbmcgYXMgdXNlciBkbyBub3Qgd2FudCB0byBzYXZlLCBqdXN0IGNv bnRpbnVlCisgICAgICAgICAgICB3aW5kb3cub25iZWZvcmV1bmxvYWQgPSBu dWxsOworICAgICAgICAgICAgcGFuZWwub2ZmKHdjRG9ja2VyLkVWRU5ULkNM T1NJTkcpOworICAgICAgICAgICAgd2luZG93LnRvcC5wZ0FkbWluLkJyb3dz ZXIuZG9ja2VyLnJlbW92ZVBhbmVsKHBhbmVsKTsKKyAgICAgICAgICB9LAor ICAgICAgICAgIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgLy8gU3RvcCwg VXNlciB3YW50cyB0byBzYXZlCisgICAgICAgICAgICAvLyBmYWxzZSB2YWx1 ZSB3aWxsIHByZXZlbnQgZnJvbSBwYW5lbCB0byBjbG9zZQorICAgICAgICAg ICAgcmV0dXJuIHRydWU7CisgICAgICAgICAgfQorICAgICAgICApLnNldCgn bGFiZWxzJywge29rOidZZXMnLCBjYW5jZWw6J05vJ30pOwogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgICB9LAogCkBAIC0xMTYyLDIxICsxMTYyLDQ5 IEBAIGRlZmluZSgKIAogICAgICAgLy8gQ2FsbGJhY2sgZnVuY3Rpb24gZm9y IHRoZSBjbGVhciBidXR0b24gY2xpY2suCiAgICAgICBvbl9jbGVhcjogZnVu Y3Rpb24oZXYpIHsKKyAgICAgICAgdmFyIHNlbGYgPSB0aGlzLCBzcWw7CiAg ICAgICAgIHRoaXMuX3N0b3BFdmVudFByb3BvZ2F0aW9uKGV2KTsKICAgICAg ICAgdGhpcy5fY2xvc2VEcm9wRG93bihldik7CiAKLSAgICAgICAgdGhpcy5x dWVyeV90b29sX29iai5zZXRWYWx1ZSgnJyk7CisgICAgICAgIC8vIFdlIHdp bGwgY2hlY2sgZm9yIG1vZGlmaWVkIHNxbCBjb250ZW50CisgICAgICAgIHNx bCA9IHNlbGYucXVlcnlfdG9vbF9vYmouZ2V0VmFsdWUoKTsKKyAgICAgICAg c3FsID0gc3FsLnJlcGxhY2UoL1xzKy9nLCAnJyk7CisgICAgICAgIC8vIElm IHRoZXJlIGlzIG5vdGhpbmcgdG8gc2F2ZSwgY2xlYXIgaXQuCisgICAgICAg IGlmICghc3FsLmxlbmd0aCkgeyBzZWxmLnF1ZXJ5X3Rvb2xfb2JqLnNldFZh bHVlKCcnKTsgIHJldHVybjsgfQorCisgICAgICAgIGFsZXJ0aWZ5LmNvbmZp cm0oCisgICAgICAgICAgJ3t7IF8oJ0NsZWFyIGVkaXRvci4uLicpIH19JywK KyAgICAgICAgICAne3sgXygnQXJlIHlvdSBzdXJlIHlvdSB3aXNoIHRvIGRp c2NhcmQgdGhlIGN1cnJlbnQgY2hhbmdlcz8nKSB9fScsCisgICAgICAgICAg ZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAvLyBEbyBub3RoaW5nIGFzIHVz ZXIgZG8gbm90IHdhbnQgdG8gc2F2ZSwganVzdCBjb250aW51ZQorICAgICAg ICAgICAgc2VsZi5xdWVyeV90b29sX29iai5zZXRWYWx1ZSgnJyk7CisgICAg ICAgICAgfSwKKyAgICAgICAgICBmdW5jdGlvbigpIHsKKyAgICAgICAgICAg IHJldHVybiB0cnVlOworICAgICAgICAgIH0KKyAgICAgICAgKS5zZXQoJ2xh YmVscycsIHtvazonWWVzJywgY2FuY2VsOidObyd9KTsKICAgICAgIH0sCiAK ICAgICAgIC8vIENhbGxiYWNrIGZ1bmN0aW9uIGZvciB0aGUgY2xlYXIgaGlz dG9yeSBidXR0b24gY2xpY2suCiAgICAgICBvbl9jbGVhcl9oaXN0b3J5OiBm dW5jdGlvbihldikgeworICAgICAgICB2YXIgc2VsZiA9IHRoaXM7CiAgICAg ICAgIHRoaXMuX3N0b3BFdmVudFByb3BvZ2F0aW9uKGV2KTsKICAgICAgICAg dGhpcy5fY2xvc2VEcm9wRG93bihldik7Ci0KLSAgICAgICAgLy8gUmVtb3Zl IGFueSBleGlzdGluZyBncmlkIGZpcnN0Ci0gICAgICAgIGlmICh0aGlzLmhp c3RvcnlfZ3JpZCkgewotICAgICAgICAgICAgdGhpcy5oaXN0b3J5X2NvbGxl Y3Rpb24ucmVzZXQoKTsKLSAgICAgICAgfQorICAgICAgICAvLyBhc2sgZm9y IGNvbmZpcm1hdGlvbiBvbmx5IGlmIGFueXRoaW5nIHRvIGNsZWFyCisgICAg ICAgIGlmKCFzZWxmLmhpc3RvcnlfY29sbGVjdGlvbi5sZW5ndGgpIHsgcmV0 dXJuOyB9CisKKyAgICAgICAgYWxlcnRpZnkuY29uZmlybSgne3sgXygnQ2xl YXIgaGlzdG9yeS4uLicpIH19JywKKyAgICAgICAgICAne3sgXygnQXJlIHlv dSBzdXJlIHlvdSB3aXNoIHRvIGNsZWFyIGFsbCB0aGUgaGlzdG9yeT8nKSB9 fScsCisgICAgICAgICAgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAvLyBS ZW1vdmUgYW55IGV4aXN0aW5nIGdyaWQgZmlyc3QKKyAgICAgICAgICAgIGlm IChzZWxmLmhpc3RvcnlfZ3JpZCkgeworICAgICAgICAgICAgICBzZWxmLmhp c3RvcnlfY29sbGVjdGlvbi5yZXNldCgpOworICAgICAgICAgICAgfQorICAg ICAgICAgIH0sCisgICAgICAgICAgZnVuY3Rpb24oKSB7CisgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICB9CisgICAgICAgICkuc2V0KCds YWJlbHMnLCB7b2s6J1llcycsIGNhbmNlbDonTm8nfSk7CiAgICAgICB9LAog CiAgICAgICAvLyBDYWxsYmFjayBmdW5jdGlvbiBmb3IgdGhlIGF1dG8gY29t bWl0IGJ1dHRvbiBjbGljay4KQEAgLTIxNjYsOCArMjE5NCwzMCBAQCBkZWZp bmUoCiAgICAgICAgICAgICB9CiAgICAgICAgICAgfSk7CiAgICAgICAgIH0s CisKICAgICAgICAgLy8gbG9hZCBzZWxlY3QgZmlsZSBkaWFsb2cKICAgICAg ICAgX2xvYWRfZmlsZTogZnVuY3Rpb24oKSB7CisgICAgICAgICAgdmFyIHNl bGYgPSB0aGlzOworICAgICAgICAgIC8vIFdlIHdpbGwgY2hlY2sgZm9yIG1v ZGlmaWVkIHNxbCBjb250ZW50CisgICAgICAgICAgc3FsID0gc2VsZi5ncmlk Vmlldy5xdWVyeV90b29sX29iai5nZXRWYWx1ZSgpCisgICAgICAgICAgc3Fs ID0gc3FsLnJlcGxhY2UoL1xzKy9nLCAnJyk7CisgICAgICAgICAgLy8gSWYg dGhlcmUgaXMgbm90aGluZyB0byBzYXZlLCBvcGVuIGZpbGUgbWFuYWdlci4K KyAgICAgICAgICBpZiAoIXNxbC5sZW5ndGgpIHsgc2VsZi5fb3Blbl9zZWxl Y3RfZmlsZV9tYW5hZ2VyKCk7IHJldHVybjsgfQorCisgICAgICAgICAgYWxl cnRpZnkuY29uZmlybSgne3sgXygnTG9hZCBmaWxlLi4uJykgfX0nLAorICAg ICAgICAgICAgJ3t7IF8oJ0lmIHlvdSBsb2FkIHRoZSBmaWxlIHlvdSB3aWxs IGxvc2UgYWxsIHRoZSBjdXJyZW50IGNoYW5nZXMsIEFyZSB5b3Ugc3VyZSB5 b3Ugd2lzaCB0byBjb250aW51ZT8nKSB9fScsCisgICAgICAgICAgICBmdW5j dGlvbigpIHsKKyAgICAgICAgICAgICAgLy8gVXNlciBkbyBub3Qgd2FudCB0 byBzYXZlLCBqdXN0IGNvbnRpbnVlCisgICAgICAgICAgICAgIHNlbGYuX29w ZW5fc2VsZWN0X2ZpbGVfbWFuYWdlcigpOworICAgICAgICAgICB9LAorICAg ICAgICAgICAgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgIHJldHVybiB0 cnVlOworICAgICAgICAgICAgfQorICAgICAgICAgICkuc2V0KCdsYWJlbHMn LCB7b2s6J1llcycsIGNhbmNlbDonTm8nfSk7CisgICAgICAgIH0sCisKKyAg ICAgICAgLy8gT3BlbiBGaWxlTWFuYWdlcgorICAgICAgICBfb3Blbl9zZWxl Y3RfZmlsZV9tYW5hZ2VyOiBmdW5jdGlvbigpIHsKICAgICAgICAgICB2YXIg cGFyYW1zID0gewogICAgICAgICAgICAgJ3N1cHBvcnRlZF90eXBlcyc6IFsi c3FsIl0sIC8vIGZpbGUgdHlwZXMgYWxsb3dlZAogICAgICAgICAgICAgJ2Rp YWxvZ190eXBlJzogJ3NlbGVjdF9maWxlJyAvLyBvcGVuIHNlbGVjdCBmaWxl IGRpYWxvZwo= --94eb2c0760dca768d7053bf9004b Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c0760dca768d7053bf9004b--