public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4] Fix help message alignment
Date: Wed, 23 Jan 2019 17:57:01 +0530
Message-ID: <CAKKotZRtigO2QBP4rBvy8LU5Ax=gH8oJir14JD=oHd9Jh5NXyQ@mail.gmail.com> (raw)

Hi,

PFA minor patch to fix the default input control help message alignment
issue on properties panel.

*Without fix:*
[image: image.png]

*With fix:*
[image: image.png]


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachments:

  [image/png] image.png (82.1K, 3-image.png)
  download | view image

  [image/png] image.png (70.0K, 4-image.png)
  download | view image

  [application/octet-stream] fix_help_message_alignment_on_properties_panel.diff (816B, 5-fix_help_message_alignment_on_properties_panel.diff)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index a4ed36be..369243dc 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -163,10 +163,10 @@ define([
       '  <span class="<%=Backform.controlClassName%> uneditable-input" <%=disabled ? "disabled readonly" : ""%>>',
       '    <%-value%>',
       '  </span>',
+      '  <% if (helpMessage && helpMessage.length) { %>',
+      '    <span class="<%=Backform.helpMessageClassName%>"><%=helpMessage%></span>',
+      '  <% } %>',
       '</div>',
-      '<% if (helpMessage && helpMessage.length) { %>',
-      '  <span class="<%=Backform.helpMessageClassName%>"><%=helpMessage%></span>',
-      '<% } %>',
     ].join('\n')),
 
     clearInvalid: function() {

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4] Fix help message alignment
  In-Reply-To: <CAKKotZRtigO2QBP4rBvy8LU5Ax=gH8oJir14JD=oHd9Jh5NXyQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox