Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evbJH-0006uK-VV for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 04:13:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evbJE-0003KA-Q1 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 04:13:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evbJE-0003K0-5o for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 04:13:08 +0000 Received: from mail-ot0-x236.google.com ([2607:f8b0:4003:c0f::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evbJ9-0000y9-5M for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 04:13:07 +0000 Received: by mail-ot0-x236.google.com with SMTP id 79so17593215oth.11 for ; Mon, 12 Mar 2018 21:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nzEzbuo/xGxdbrf6cnGdsXSWBBZZ+iyIqDpRbBF2cWk=; b=L6SPuTNMBUL1Ts70Nrf4aknaa22xZPx+nEuG8kpUT4IOm1q6lJkLgv5OoGv1d09j3w g7va8rQVhHVaOSsUm+0GDl6qI/lFYQmfi3YEyVclY66LX9TY8PzO+bIcMAdl90FaHARa ypAxFtQJQzg+Inrm87+8Pzdc1cXWl+3Ftp6GjR4TdZobREB37CG8I5WmHQTWxObxPABO 4QO1PhhlZbw+a5ne+ca1hEh8aFNk/aspqoUnOPvmQ9AwcfgtRshnmVUoc6B1szZO3zic W3gHC9pbLqsCU2b04N3USAn1Dl27KfRl/LPJz++lH0hrsPojH0v3sCkub4vfe4SJ6tYa 0ayw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nzEzbuo/xGxdbrf6cnGdsXSWBBZZ+iyIqDpRbBF2cWk=; b=YRw27I8dsuhv2/q0kY+bclf4tysyAccisDgYlSUmEUwLoPGsD/jJrSGJqg5eBpGatV ksYKJr4l13AInND4t5W9xShuFiUK6sZJKRnJtHzRE8NIcYNwnMJnsGNl3uA05pxwl9HH 2KnLII6o3Cgwx1fZQbidvyFB5P/LZEArk3bSCzWcFhfswjcbUVKlJlr01Cy4M2Of6lsM 3kZgbxMzPPPICcCVfyVoTYK9m/diRFTWVdedy3PGKsbD8io9hFX3z0WD5lV/HJgnaOWo 7i0UcNoewX9WCQYLQlag+lWU+EyOReH0fuwpwM/FJ/4Fxn71Q1LsMgxbVv+m7tjuG2AQ kPUA== X-Gm-Message-State: AElRT7HurHfDcZnw9ek58E2vdWipyl3BLvIYif2+EOKT3uwX4Z6/gSiT EUkgwXdeOOjkfaxkR/jatjoGtBvgmkapEero+3OjcA== X-Google-Smtp-Source: AG47ELuMBhpiVS3t/NMPc8hYSMJhR0ihQN6hgDdJe6WGYNtUaCeChw1+gFpHJMefZ+tI1Ibtbk2IPPx/hvbHYbiDMTE= X-Received: by 10.157.22.233 with SMTP id s38mr6786257ots.97.1520914380674; Mon, 12 Mar 2018 21:13:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Mon, 12 Mar 2018 21:12:40 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Tue, 13 Mar 2018 09:42:40 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3140] Add service parameter To: Ashesh Vashi Cc: Dave Page , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114790ea64f35e05674379c1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114790ea64f35e05674379c1 Content-Type: text/plain; charset="UTF-8" Hi Ashesh, I haven't implemented that intentionally because Khushboo is working on the same for SSL and our code will conflict, So once Khushboo's patch gets committed, I'll make changes for Service file as well. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vashi wrote: > Murtuza/Dave, > > I have to reviewed/seen the patch yet. > But - I have a question. > Have we used the service file in the external tools for backup, restore, > and import/export functionalities? > If not - we should fix that asap. > > We had missed that during SSL support, and now - we're fixing that. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Tue, Mar 13, 2018 at 6:18 AM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Dave and Murtuza, >>> >>> Regarding this patch we refactored the Javascript code so that is lives >>> in a different file and added some tests. >>> >>> Also we found an issue with karma-jasmine that does not allow us to use >>> jasmine 3.1 yet. You can find attached a patch that reverts that commit. >>> >> >> Sounds good, but neither patch will apply (in fact, the Jasmine one looks >> entirely backwards). One of the error messages was changed in Murtuza's >> patch, and wasn't reflected in your update for example. >> >> Can you rebase please? >> >> Thanks. >> >> >>> >>> Thanks >>> Victoria && Joao >>> >>> On Mon, Mar 12, 2018 at 4:46 PM Dave Page wrote: >>> >>>> Thanks, patch applied! >>>> >>>> On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> PFA updated patch. >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> I'll change the name and send you updated patch. >>>>>> >>>>>> >>>>>> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: >>>>>> >>>>>>> HI >>>>>>> >>>>>>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> PFA patch to add service parameter in server dialog. >>>>>>>> - Docs updated >>>>>>>> - Test case added for Service ID parameter >>>>>>>> >>>>>>>> Please note, >>>>>>>> I have extracted Connection class and Server manager class from our >>>>>>>> own custom Psycopg2 driver module. >>>>>>>> >>>>>>>> Patch also covers RM#3120 >>>>>>>> >>>>>>> >>>>>>> This patch seems a little confused. The "Service" and "Service ID" >>>>>>> fields from pgAdmin 3 are very different things. The Redmine ticket seems >>>>>>> to be asking for the Service field (the pg_service.conf service name), >>>>>>> *not* Service ID (the operating system's service ID, used to start/stop the >>>>>>> database server service). >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a114790ea64f35e05674379c1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ashesh,

I hav= en't implemented that intentionally because Khushboo is working on the = same for SSL and our code will conflict, So once Khushboo's patch gets = committed, I'll make changes for Service file as well.
<= br>

--
Regards,
Murtuza Zabuawala
EnterpriseDB:= =C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny


On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Murt= uza/Dave,

I have to reviewed/seen the patch yet.
= But - I have a question.
Have we used the s= ervice file in the external tools for backup, restore, and import/export fu= nctionalities?
If not - we should fix that asap.

We had = missed that during SSL support, and now - we're fixing that.

--

Thanks & Regards,=

Ashesh Vashi
EnterpriseDB INDIA: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">Enterprise Postgre= SQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave and Murtuza,

R= egarding this patch we refactored the Javascript code so that is lives in a= different file and added some tests.

Also we foun= d an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet= . You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply= (in fact, the Jasmine one looks entirely backwards). One of the error mess= ages was changed in Murtuza's patch, and wasn't reflected in your u= pdate for example.

Can you rebase please?

Thanks.
=C2=A0

Thanks
Victoria && Joao

On Mon, M= ar 12, 2018 at 4:46 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM,= Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.c= om> wrote:
Hi Dave,
=

PFA updated patch.

<= div dir=3D"ltr">
--=
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enter= prisedb.com
The Enterprise PostgreSQL Company

<= /div>

On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

I'll change the name and s= end you updated patch.
<= div dir=3D"ltr">


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to add=C2=A0service parameter in se= rver dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have= extracted Connection class and Server manager class from our own custom Ps= ycopg2 driver module.

Patch also covers RM#3120
<= br>
=C2=A0This patch seems a little confused. The "Service&q= uot; and "Service ID" fields from pgAdmin 3 are very different th= ings. The Redmine ticket seems to be asking for the Service field (the pg_s= ervice.conf service name), *not* Service ID (the operating system's ser= vice ID, used to start/stop the database server service).
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: = @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQ= L Company





--
Dave Page
Blo= g: http://pgsnake= .blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= font color=3D"#888888">



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twi= tter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Pos= tgreSQL Company

--001a114790ea64f35e05674379c1--