MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxox3gREiVKvXSh2=OjooseZH3cveT90C97k6mH6s0AYGnA@mail.gmail.com>
References: 
 <CAKKotZSRSKPWzapTT6fJQiCAprRs_h644mXkeP_ba-NbynJufg@mail.gmail.com>
 <CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com>
 <CA+OCxox3gREiVKvXSh2=OjooseZH3cveT90C97k6mH6s0AYGnA@mail.gmail.com>
From: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Date: Wed, 7 Mar 2018 18:14:51 +0530
Message-ID: 
 <CAKKotZRwaG6X-9ZZ3+CCMQ0y=h7kTR_ver=QfWf6savrjtbF3A@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node
To: Dave Page <dpage@pgadmin.org>
Cc: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="089e082c7f84128d3e0566d1ee45"
Precedence: bulk

--089e082c7f84128d3e0566d1ee45
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 7, 2018 at 6:12 PM, Dave Page <dpage@pgadmin.org> wrote:

> Hi
>
> On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <
> jdealmeidapereira@pivotal.io> wrote:
>
>> Hi Murtuza,
>>
>> The code change works, and I passed the patches through our pipeline and
>> everything is green.
>> Personally I would love this bug fixes to have refactored the function
>> into smaller chunk and made it more readable so that the next time someo=
ne
>> need to check out a problem in the same area it is easier. I understand
>> that without a good test coverage it is hard to have confidence while
>> refactoring, but we need to start somewhere.
>>
>
> Are you planning to look into this Murtuza?
>
=E2=80=8BYes Dave, I am working on another issue, I'll pick up after that.=
=E2=80=8B


>
>
>>
>> @Hackers
>> Here is a video that I saw some time ago about refactoring existing code
>> and code complexity that is very interesting
>> https://www.youtube.com/watch?v=3D8bZh5LMaSmE
>> In this video Sandi Metz does the Gilded Rose Kata in a talk in RailsCon=
f
>> 2014, and with it tries to demonstrate that code can be refactored and w=
ith
>> that it make the code much more simpler. But the journey is not always
>> simple and the complexity will increase before it get simpler. It is a g=
ood
>> example of something that we can try with our code.
>>
>
> Nice!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--089e082c7f84128d3e0566d1ee45
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif;color:#444444"><br></div><div class=3D"gmail_extra"><div class=
=3D"gmail_quote">On Wed, Mar 7, 2018 at 6:12 PM, Dave Page <span dir=3D"ltr=
">&lt;<a href=3D"mailto:dpage@pgadmin.org" target=3D"_blank">dpage@pgadmin.=
org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr=
">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Tue, M=
ar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <span dir=3D"ltr">&lt;<a hre=
f=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_blank">jdealmeidaperei=
ra@pivotal.io</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div =
dir=3D"ltr">Hi Murtuza,<div><br></div><div>The code change works, and I pas=
sed the patches through our pipeline and everything is green.</div><div>Per=
sonally I would love this bug fixes to have refactored the function into sm=
aller chunk and made it more readable so that the next time someone need to=
 check out a problem in the same area it is easier. I understand that witho=
ut a good test coverage it is hard to have confidence while refactoring, bu=
t we need to start somewhere.</div></div></blockquote><div><br></div><div>A=
re you planning to look into this Murtuza?</div></div></div></div></blockqu=
ote><div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-ser=
if;color:rgb(68,68,68);display:inline">=E2=80=8BYes Dave, I am working on a=
nother issue, I&#39;ll pick up after that.=E2=80=8B</div>=C2=A0</div><block=
quote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc=
 solid;padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_extra"><div c=
lass=3D"gmail_quote"><div>=C2=A0</div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div d=
ir=3D"ltr"><div><br></div><div>@Hackers</div><div>Here is a video that I sa=
w some time ago about refactoring existing code and code complexity that is=
 very interesting</div><div><a href=3D"https://www.youtube.com/watch?v=3D8b=
Zh5LMaSmE" target=3D"_blank">https://www.youtube.com/watch?<wbr>v=3D8bZh5LM=
aSmE</a><br></div><div>In this video Sandi Metz does the Gilded Rose Kata i=
n a talk in RailsConf 2014, and with it tries to demonstrate that code can =
be refactored and with that it make the code much more simpler. But the jou=
rney is not always simple and the complexity will increase before it get si=
mpler. It is a good example of something that we can try with our code.</di=
v></div></blockquote><div><br></div><div>Nice!=C2=A0</div></div><span class=
=3D"m_9109930983859666299HOEnZb"><font color=3D"#888888"><div><br></div>-- =
<br><div class=3D"m_9109930983859666299m_6995766218588808395gmail_signature=
" data-smartmail=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://p=
gsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>T=
witter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb=
.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise P=
ostgreSQL Company<br></div>
</font></span></div></div>
</blockquote></div><br></div></div>

--089e082c7f84128d3e0566d1ee45--