public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node
Date: Thu, 29 Mar 2018 18:36:40 +0530
Message-ID: <CAKKotZRynLe885bAzH94kgv0M=4Tg3c13YfLRmxtMT72HqmKHA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdsG7eSWLpL9u5dgMb73t61tu0pqN1QjoXoGAFc=h1+Pw@mail.gmail.com>
References: <CANxoLDdsG7eSWLpL9u5dgMb73t61tu0pqN1QjoXoGAFc=h1+Pw@mail.gmail.com>

Hi Akshay,

I have concerns regarding the fix, As you negate the condition, Before the
fix it was not displaying Index node for Tables but after the fix it will
not display it for Partition tables.
But when I read the Postgres docs it say,
*Partitions may themselves be defined as partitioned tables, using what is
called sub-partitioning. Partitions may have their own indexes, constraints
and default values, distinct from those of other partitions. Indexes must
be created separately for each partition. See CREATE TABLE
<https://www.postgresql.org/docs/10/static/sql-createtable.html; for more
details on creating partitioned tables and partitions.*
Ref: https://www.postgresql.org/docs/10/static/ddl-partitioning.html (Sec:
5.10.2)



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Mar 29, 2018 at 6:05 PM, Akshay Joshi <[email protected]
> wrote:

> Hi Hackers,
>
> Please find the attached patch to fix RM #3180 Index node is missing from
> the tree view of the table node. This is a regression of one of the older
> commit.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the tree view of the table node
  In-Reply-To: <CAKKotZRynLe885bAzH94kgv0M=4Tg3c13YfLRmxtMT72HqmKHA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox