Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3cnC-0007O4-0i for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 07:25:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3cnB-0005g1-3A for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 07:25:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3cnA-0005fK-Ol for pgadmin-hackers@lists.postgresql.org; Wed, 04 Apr 2018 07:25:12 +0000 Received: from mail-ot0-x234.google.com ([2607:f8b0:4003:c0f::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3cn5-0006T8-Gn for pgadmin-hackers@postgresql.org; Wed, 04 Apr 2018 07:25:12 +0000 Received: by mail-ot0-x234.google.com with SMTP id a14-v6so4106921otf.6 for ; Wed, 04 Apr 2018 00:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Ee/LiuyLThQOEkipLjkMWt1ji7y1nylYismPd52p6pg=; b=1MJLWk7EncUHL64QGHirKW3DrlMTRIqQ4Ncmt1JkuvLp9jkroX+RGSORzPqvy+dNit 0lhl6XRIKSONhGghHZqP9OPa8gXPV6G5A8dlS+3arcYT6U/LHwTboo8ZKXUwG+8QO5JU N8QuCfSedNQCMHnLv64AYJHsvKfn4diKeaKXfQTavuPJMJO5n4AOBC0BYbIYjCSq1hB0 FVR0iOq1cGnAJG+LR+d1xVgGciqyaHPF0HmmVcLyWbSdutV87NybdFE4REEyKKYQVBUP +FB8dyL/fhOi0d5NPAE3/fzHi5vMEQHHigBMIVaiDeBnKmzzzaezh2p+5ODi3fvOueyF 7F4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ee/LiuyLThQOEkipLjkMWt1ji7y1nylYismPd52p6pg=; b=ZTd4+gKNwzvAUQHD4fsiJ5CQi4F9IXlvOGvleR0LNxQlvp/T0ubbrhlcAYi+kBr5AE ZSJLmiRzsKiShCaGJP1cgUisyW9h6CXXquN8PwyTpq4SvG1SAkpfvw6Exhh5EPiqoi7O XNrNHVsWKCtlkkUlmaF1LYoIAiGQF6XkNgNZ28q5fQ9Kc+gK9YQju565VXLVxH1azfkR V3TXBJr8If0yUmffhzQ0RpBQjwwwm0/Wz3ZTJjdnQVuQKloAPMvgy0oWMokG0ZoZJe8I 8VPA8neRGS0k3u6/VUq2hTLwokwbexKNWzMB/yzvZPVt5ntQBd9Yfaceiv6vTnuXSZqx 3NkA== X-Gm-Message-State: AElRT7Gx2YHwO4jvzqKssN2ksVvfMlwrYSSskiFx+YqGuDCoJPUPukXQ P5susy9ih/nZiaHOsGNxh6R3B2e+ZLw3Du6SDthaHQ== X-Google-Smtp-Source: AIpwx49cB1ih2qMh5vjnpal6MAV98VUin9cjqU8E5dM9YeLFAGjrcM9/jmliOvuZPp0If/pAj13wBeA8aGIrGytfyr4= X-Received: by 2002:a9d:7308:: with SMTP id e8-v6mr10690655otk.271.1522826705015; Wed, 04 Apr 2018 00:25:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.138.6.138 with HTTP; Wed, 4 Apr 2018 00:24:44 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Wed, 4 Apr 2018 12:54:44 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version To: Joao De Almeida Pereira Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ceb2b0056900b863" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ceb2b0056900b863 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Joao, Yes it bundles latest version but I doubt that is not using it, If we upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. I have tried that and I started getting jQuery related errors when trying to run query tool or when running jasmine tests. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Murtuza, > > The patches look good and they pass all tests in CI. > One think that we realized was the SlickGrid as a npm package now: > https://www.npmjs.com/package/slickgrid > Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully > supported or not...... > > Thanks > Victoria & Joao > > On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala enterprisedb.com> wrote: > >> =E2=80=8BHi Dave, >> >> Reverted back jQuery version to 1.x because of SlickGrid dependancy. >> Please find updated patch. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala > enterprisedb.com> wrote: >> >>> Please hold on my previous patch. >>> >>> We can't use latest jQuery version as SlickGrid has dependancy on older >>> version. >>> I'll send updated patch again. >>> >>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala >> enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Please find updated patches, there are two patches attached one is for >>>> the story and another is for changes required as per new modules. >>>> >>>> >>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala >>>> enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch to update the modules to latest version. >>>>>> >>>>>> >>>>> - Why isn't jQuery updated to 3.3.1? >>>>> >>>> =E2=80=8BDone=E2=80=8B >>>> >>>> >>>>> =E2=80=8B >>>>> >>>>> >>>> >>>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 >>>>> and pycrypto etc? >>>>> >>>> =E2=80=8BDone=E2=80=8B >>>> >>>> >>>>> >>>>> >>>>> >>>>>> We are not able to update some of the modules to latest version due >>>>>> to dependancy on other modules, For example >>>>>> - Python: Flask-Security has dependancy on flask-babelex which cause= s >>>>>> conflict with flask_babel >>>>>> >>>>> >>>>> Hmm, flask-babelex might be a better option anyway; in particular, it >>>>> avoids loading catalogs with every request which seems desirable give= n the >>>>> size of ours. On the other hand, it hasn't been updated so recently. >>>>> >>>> =E2=80=8BI have removed flask-babel and used flask_babelex instead.=E2= =80=8B >>>> >>>> >>>>> >>>>> >>>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & >>>>>> Bootstrap Datetime picker has dependancy on Bootstrap3. >>>>>> >>>>> >>>>> OK. >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> --000000000000ceb2b0056900b863 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Joao,

Yes it= bundles latest version but I doubt that is not using it, If we upgrade the= jQuery to 3.3.1 then it's breaking the SlickGrid.
I have= tried that and I started getting jQuery related errors when trying to run = query tool or when running jasmine tests.

= --Regards,=
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.c= om
The Enterprise PostgreSQL Company
<= font size=3D"2">
<= /font>

On Wed, Apr 4, 2018 at 1:39 AM, Joao De Alme= ida Pereira <jdealmeidapereira@pivotal.io> wrote:=
Hi Murtuza,

The patches look good and they pass all tests in CI.
One = think that we realized was the SlickGrid as a npm package now:=C2=A0https://www.= npmjs.com/package/slickgrid=C2=A0
Also Slickgrid comes p= ackaged with jquery 3.1 not sure if it is fully supported or not......

Thanks
Victoria & Joao

On Tue, Apr 3, 2018 at 11:50 AM Murtuza= Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
=E2=80=8BHi= Dave,

Reverted back jQuery ve= rsion to 1.x because of SlickGrid dependancy.
Please find updated patch.

--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=
<= /div>

On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
P= lease hold on my previous patch.=C2=A0

W= e can't use latest jQuery version as SlickGrid has dependancy on older = version.
I'll send updated patch again.

On Tue, Apr 3, 2018 at 8:20= PM, Murtuza Zabuawala <murtuza.zabuawala@enterprise= db.com> wrote:
Hi Dave,

<= div style=3D"font-family:verdana,sans-serif;color:#444444">Please find upda= ted patches, there are two patches attached one is for the story and anothe= r is for changes required as per new modules.


On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to update the modules to latest version.


- Why isn't jQuery updated to 3.3.1?
=E2=80=8BDone=E2=80=8B
= =C2=A0
=E2=80=8B
=C2=A0

- Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2= and pycrypto etc?=C2=A0
=E2=80=8BDone=E2=80=8B
=C2=A0
<= div dir=3D"ltr">
=
=C2=A0
=
We are not able to updat= e some of the modules to latest version due to dependancy on other modules,= For example
- Python: Flask-Security has dependancy on flask-babelex which causes co= nflict with flask_babel

Hmm, fl= ask-babelex might be a better option anyway; in particular, it avoids loadi= ng catalogs with every request which seems desirable given the size of ours= . On the other hand, it hasn't been updated so recently.
=E2=80=8BI have removed flask-babel and us= ed flask_babelex instead.=E2=80=8B
=C2=A0
=C2=A0
- JS: Can't updat= e to Bootstrap4 because Bootstrap Switch & = Bootstrap=C2=A0Datetime picker has dependancy on Bootstrap3.

OK.=C2=A0


--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company




--000000000000ceb2b0056900b863--