Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iVEgW-0001Ch-36 for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Nov 2019 12:57:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iVEgT-000545-HM for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Nov 2019 12:57:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iVEgT-00053x-6n for pgadmin-hackers@lists.postgresql.org; Thu, 14 Nov 2019 12:57:13 +0000 Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iVEgQ-0001uU-8G for pgadmin-hackers@postgresql.org; Thu, 14 Nov 2019 12:57:11 +0000 Received: by mail-oi1-x22c.google.com with SMTP id m193so5173188oig.0 for ; Thu, 14 Nov 2019 04:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=g0UzQP50th5Z7OMqxNb0VYZmnDMsbPpWgfXYsmbtFFQ=; b=ISsGEYxT661FnwVmmO02h5zqDsmdR0Dh5a5GkoRK6ErKibKI34P7Vz1gYUI1kpbOiJ Akes2oxH0QrKT3g+A2N/58QtCSa1eSREymPXtkuKhWL2WTfHVCTrkm+5ZiEbi5bMukg8 KDNuzHML5uLTWLtFxQr1dOyFHAscYvRUza7zPO084VTTEY3o5FOxmVNBjtebNKh5L1di 8zzBu4rHhT35V7V95Ho3EbFU4aNhK8CEXmqLIj8inx1Oe1RPWr3DG2Yj8V3CTsHU09Xb 127GkOIVAeSO6wsGM3sadQZLQLzkQWhf9Qz430ZGYjMlSQXZgMahF/EwfxOulkYIWGCo FJLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=g0UzQP50th5Z7OMqxNb0VYZmnDMsbPpWgfXYsmbtFFQ=; b=hJn59KB1xk+dw9vAQRP4u0nTg1fpI1o+nIx6m0H2OONfamoowT2PKEqCetNIDOABLO dsnTPZ4oKsRjO4qWlONLcW+D4XsYt5EirtQqcCbahliQiAkbk39EWRbeCCcJmEyl0H+a NB0cqdcNswVx6DuzwhPIlpysjG2xh+vefxyItCe3dInxliN7XHH9fcCOJEBF9yrbkkm/ OfVAFYnqsMBnMVyh0coftsRUDV2QJgsZfaPwEzjQm7Pq2v/iWOpagiKtdEzYm5CCZaqt JC61mr1puCiB2wk9sJWo8dkfOE4sORSwLvQTioijpB7QtLA6vyRXgrRgB3zlKsn/fIYW 74yQ== X-Gm-Message-State: APjAAAUR/mP0zOSn2N/jsieqQFKNtC07iSyTgct6la93JltJovydMIpZ c+ZDQst3jBrf1twGSx4z1lGhaRrTg+FqwuOR/Y3FT9U8quAu2PaWGwxkZQPdRAw4PpWaUygOIK+ JT5B7IMlQ8kZCvFpy2emEjkQeaI8iRV76dc5Oi74JYd/iVhcpFVYOe7HBII8HZwyYqDKgBo779t ycLLa7bqxfNdW8d4aaIp/gbu9d02gu/xjdHoSXyFpnsMGi14DU3ykQUlP5Enk= X-Google-Smtp-Source: APXvYqytY3rg/D4jSTDxD/CrM/LstNzbR6n7bLgIQZ0huGIc6zHg5x/azHjHkWVbx0siCXyLF72tHNfXaRO8fWkMnqo= X-Received: by 2002:a54:468a:: with SMTP id k10mr3243809oic.87.1573736229374; Thu, 14 Nov 2019 04:57:09 -0800 (PST) MIME-Version: 1.0 From: Murtuza Zabuawala Date: Thu, 14 Nov 2019 18:26:53 +0530 Message-ID: Subject: [RM#4935] Accessibility related issues To: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000ec491a05974e046f" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ec491a05974e046f Content-Type: multipart/alternative; boundary="000000000000ec491705974e046d" --000000000000ec491705974e046d Content-Type: text/plain; charset="UTF-8" Hi, PFA patch for accessibility related issues, 1) Suppress ESC key presses in Alertify dialogues when the come from Select2 controls (It also closes the alertify dialog when user try to close Select2 using ESC key) 2) Do not allow Tabindex focus on Switch control when it is disbaled 3) Tab keyboard shortcut navigation does not work in wcDocker iframe. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000ec491705974e046d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

PFA patch for accessibility=C2=A0related is= sues,
1) Supp= ress=C2=A0ESC key=C2=A0presses=C2=A0in=C2=A0Alertify=C2=A0dialogues=C2=A0wh= en=C2=A0the=C2=A0come=C2=A0from=C2=A0Select2=C2=A0controls (It also closes = the alertify dialog when user try to close Select2 using ESC key)
2) Do not allow= Tabindex focus on Switch control when it is disbaled
3) Tab keyboard shortcut na= vigation does not work in wcDocker iframe.

<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:r= gb(68,68,68)">
--
Regards,
Murtuza Za= buawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=
<= /div>
--000000000000ec491705974e046d-- --000000000000ec491a05974e046f Content-Type: application/octet-stream; name="pgadmin4_fixes.diff" Content-Disposition: attachment; filename="pgadmin4_fixes.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k2ypwl880 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc3RhdGljL2pzL2tleWJvYXJkLmpzIGIv d2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMva2V5Ym9hcmQuanMKaW5kZXggZTY0YWYyN2Y3 My4uMzQzNjM4NWIyNiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMv a2V5Ym9hcmQuanMKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zdGF0aWMvanMva2V5Ym9hcmQu anMKQEAgLTE0LDYgKzE0LDcgQEAgaW1wb3J0IE1vdXNldHJhcCBmcm9tICdtb3VzZXRyYXAnOwog aW1wb3J0ICogYXMgY29tbW9uVXRpbHMgZnJvbSAnLi4vLi4vLi4vc3RhdGljL2pzL3V0aWxzJzsK IGltcG9ydCBkaWFsb2dUYWJOYXZpZ2F0b3IgZnJvbSAnLi4vLi4vLi4vc3RhdGljL2pzL2RpYWxv Z190YWJfbmF2aWdhdG9yJzsKIGltcG9ydCAqIGFzIGtleWJvYXJkRnVuYyBmcm9tICdzb3VyY2Vz L2tleWJvYXJkX3Nob3J0Y3V0cyc7CitpbXBvcnQgcGdXaW5kb3cgZnJvbSAnc291cmNlcy93aW5k b3cnOwogCiBjb25zdCBwZ0Jyb3dzZXIgPSBwZ0FkbWluLkJyb3dzZXIgPSBwZ0FkbWluLkJyb3dz ZXIgfHwge307CiAKQEAgLTU2NSw4ICs1NjYsOCBAQCBfLmV4dGVuZChwZ0Jyb3dzZXIua2V5Ym9h cmROYXZpZ2F0aW9uLCB7CiAgICAgfTsKICAgfSwKICAgZ2V0RGlhbG9nVGFiTmF2aWdhdG9yOiBm dW5jdGlvbihkaWFsb2dDb250YWluZXIpIHsKLSAgICBjb25zdCBiYWNrd2FyZF9zaG9ydGN1dCA9 IHBnQnJvd3Nlci5nZXRfcHJlZmVyZW5jZSgnYnJvd3NlcicsICdkaWFsb2dfdGFiX2JhY2t3YXJk JykudmFsdWU7Ci0gICAgY29uc3QgZm9yd2FyZF9zaG9ydGN1dCA9IHBnQnJvd3Nlci5nZXRfcHJl ZmVyZW5jZSgnYnJvd3NlcicsICdkaWFsb2dfdGFiX2ZvcndhcmQnKS52YWx1ZTsKKyAgICBjb25z dCBiYWNrd2FyZF9zaG9ydGN1dCA9IHBnV2luZG93LnBnQWRtaW4uQnJvd3Nlci5nZXRfcHJlZmVy ZW5jZSgnYnJvd3NlcicsICdkaWFsb2dfdGFiX2JhY2t3YXJkJykudmFsdWU7CisgICAgY29uc3Qg Zm9yd2FyZF9zaG9ydGN1dCA9IHBnV2luZG93LnBnQWRtaW4uQnJvd3Nlci5nZXRfcHJlZmVyZW5j ZSgnYnJvd3NlcicsICdkaWFsb2dfdGFiX2ZvcndhcmQnKS52YWx1ZTsKIAogICAgIHJldHVybiBu ZXcgZGlhbG9nVGFiTmF2aWdhdG9yLmRpYWxvZ1RhYk5hdmlnYXRvcihkaWFsb2dDb250YWluZXIs IGJhY2t3YXJkX3Nob3J0Y3V0LCBmb3J3YXJkX3Nob3J0Y3V0KTsKICAgfSwKZGlmZiAtLWdpdCBh L3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9hbGVydGlmeS5wZ2FkbWluLmRlZmF1bHRzLmpzIGIvd2Vi L3BnYWRtaW4vc3RhdGljL2pzL2FsZXJ0aWZ5LnBnYWRtaW4uZGVmYXVsdHMuanMKaW5kZXggZjk5 NzMwMzIyZC4uYThiZGI3YWFhYiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2Fs ZXJ0aWZ5LnBnYWRtaW4uZGVmYXVsdHMuanMKKysrIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2Fs ZXJ0aWZ5LnBnYWRtaW4uZGVmYXVsdHMuanMKQEAgLTQ0NSw3ICs0NDUsNyBAQCBkZWZpbmUoWwog ICAgKiBpbnN0ZWFkIG9mIGFsZXJ0aWZ5IGRpYWxvZwogICAgKi8KICAgJCgnYm9keScpLm9mZign a2V5dXAnKS5vbigna2V5dXAnLCBmdW5jdGlvbihldil7Ci0gICAgaWYoZXYud2hpY2ggPT09IDEz KSB7CisgICAgaWYoZXYud2hpY2ggPT09IDEzIHx8IGV2LndoaWNoID09PSAyNykgewogICAgICAg bGV0IHN1cHByZXNzRm9yQ2xhc3NlcyA9IFsnc2VsZWN0Mi1zZWxlY3Rpb24nLCAnc2VsZWN0Mi1z ZWFyY2hfX2ZpZWxkJ107CiAgICAgICBsZXQgJGVsID0gJChldi50YXJnZXQpOwogICAgICAgZm9y KGxldCBpPTA7IGk8c3VwcHJlc3NGb3JDbGFzc2VzLmxlbmd0aDsgaSsrKXsKZGlmZiAtLWdpdCBh L3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5wZ2FkbWluLmpzIGIvd2ViL3BnYWRtaW4v c3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKaW5kZXggOTVmNzg2ZDlmNC4uZDQ2YWMyODk2 ZiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMK KysrIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKQEAgLTYwNiw3 ICs2MDYsOCBAQCBkZWZpbmUoWwogCiAgICAgICB0aGlzLiRpbnB1dCA9IHRoaXMuJGVsLmZpbmQo J2lucHV0W3R5cGU9Y2hlY2tib3hdJykuZmlyc3QoKTsKICAgICAgIHRoaXMuJGlucHV0LmJvb3Rz dHJhcFRvZ2dsZSgpOwotICAgICAgdGhpcy4kZWwuZmluZCgnLnRvZ2dsZS5idG4nKS5hdHRyKCd0 YWJpbmRleCcsICcwJyk7CisgICAgICAvLyBXaGVuIGRpc2FibGUgdGhlbiBzZXQgdGFiaW5kZXgg dmFsdWUgdG8gLTEKKyAgICAgIHRoaXMuJGVsLmZpbmQoJy50b2dnbGUuYnRuJykuYXR0cigndGFi aW5kZXgnLCBkYXRhLm9wdGlvbnMuZGlzYWJsZWQgPyAnLTEnIDogJzAnKTsKICAgICAgIHRoaXMu dXBkYXRlSW52YWxpZCgpOwogCiAgICAgICByZXR1cm4gdGhpczsK --000000000000ec491a05974e046f--