Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0lnU-0005I7-A7 for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Mar 2018 10:25:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0lnT-0006RM-8n for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Mar 2018 10:25:43 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0lnS-0006RC-Si for pgadmin-hackers@lists.postgresql.org; Tue, 27 Mar 2018 10:25:43 +0000 Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0lnP-0002CD-Iu for pgadmin-hackers@postgresql.org; Tue, 27 Mar 2018 10:25:41 +0000 Received: by mail-oi0-x243.google.com with SMTP id t16-v6so18724484oih.3 for ; Tue, 27 Mar 2018 03:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=f4++QEJ4t4pzjZBTpsXc7JEn+bP2trzC89FrEoD5W4s=; b=gmUw3+5frnAIG8wA4JxsJfqTteySM+Qoryj0pRo0CNwX3WhbZPx2btMCTB7qCeEe2z JALOe+F1HIHuEW2Xtqb8SXe6TebLuG24ARkRRg5w8T53M/I2ToEDcHcNOd4zVD5uKvDd p/PIXu9bRnTIYxnTQJiPwi/zvQZttjAO0jViPAaoXncAPpiTPc4q86y19BJzUJQll5Ln 7ESgXcZxARGtmkUKownjq3BXX8EpxnDVVJ5Hg+9eFWl0KERE+GV/9BxXSnpHG90Gy91d mfb2VSDL0B8PjAeSFxnAt57PXeQkYhK1ehOrG63Ia+dG1gPnVC67ErDp0A/xHQbnBAMZ sgKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=f4++QEJ4t4pzjZBTpsXc7JEn+bP2trzC89FrEoD5W4s=; b=DA2E766PXzoumY5AdHrz/heMbn98z3fgQgpL5fuJxWfbG5B6f7pe2asoMPm81UXam2 oeFi3Ua6nUgonuYnCen5IhYTEhiQ6K1XJEkRRGb3hhRkd7aDPy4E9NEmykKSw5mz82N7 ao+mN5ZqfFcxE/sTIOjOC31uOGqnTMLjKL/VXvhcGWqVPp8R1gIWCCnUVkG3HEe59DaF K1Nrt/lzMy0kOqiHLhBTj6fqr1bLm7iywRR5pNIKZyLVmYnhItj9PfRxUpmoezJtku34 +EaYJz4d4qruB7uEwu+1Cg/9sVWEHW8AljqBTiNLRKkOwIL3yRam0eYg3+frNpNFkl79 ybzA== X-Gm-Message-State: AElRT7FVLIqc/h9et1Aw9XpC+4ZTzeKPh+1H1ceYIZLRsBFYWNG29cK6 Bip9fr1Va84vBGOr1azBfyQPY7wMfG0Cnbgu+4lPCQ== X-Google-Smtp-Source: AIpwx4+7iRGav5wSotc50+6Q9rI4G8TIP3zWHq7hGErU6lOuHN6t19I5TH1KpnLqWQVP0qRgY+ESr3HiP13Mexq+quI= X-Received: by 10.202.206.67 with SMTP id e64mr9764435oig.342.1522146338681; Tue, 27 Mar 2018 03:25:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.138.6.138 with HTTP; Tue, 27 Mar 2018 03:25:18 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Tue, 27 Mar 2018 15:55:18 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode To: Dave Page Cc: Robert Eckhardt , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113d23ded051a50568624fe2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113d23ded051a50568624fe2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 27, 2018 at 3:13 PM, Dave Page wrote: > > > On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt > wrote: > >> >> >> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> @Murtuza: The patch codewise looks good. Nice to see that we are using >>> axios instead of jquery ajax calls and that there is some coverage for = the >>> change. >>> Nevertheless the Javascript testing looks a bit slim and could be >>> improved. Also the DataSorting class could have some other member funct= ions >>> like the model validation could be extracted out so that it is easily >>> tested. >>> >>> >>> @Hackers: This was how we tried to test this feature: >>> 1 - Started pgAdmin >>> 2 - Opened the query tool for a specific server >>> 3 - Executed a SQL statment >>> 4 - Pressed the column header to try to order, nothing happened >>> 5 - Right clicked the column header to see if it was there the option, >>> nothing >>> >>> This is the behavior that we were expecting, not to have to open Data >>> View and then press the icon that is not even near the grid in order to >>> sort the column. Is this really the way we want people to use the grid = in >>> pgAdmin? Should it be more intuitive? >>> >> >> Have we considered making the grid behave more like excel or other grids= ? >> I think that having the ascending and descending inside the column heade= r, >> we could similarly provide filtering. Something that would give users a >> more intuitive place to look. >> > > Doing the sorting via header clicks is convenient but very restrictive. > How do you specify multiple columns to sort by for example? The current > design allows you to select columns and the sort order as you see fit. > Another reason we can't use that because w e have already occupied that behaviour for selecting entire column =E2=80=8B when user clicks on header. As Dave suggested, I will be merging it with filter dialog meaning it will be accessible via direct button on toolbar & keyboard shortcut.=E2=80=8B =E2=80=8B > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113d23ded051a50568624fe2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Mar 27, 2018 at 3:13 PM, Dave Page <dpage@pgadmin.org&g= t; = wrote:


On Mon, Mar 26, 2018 at 9:26 PM, Rober= t Eckhardt <reckhardt@pivotal.io> wrote:


On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeid= a Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Hackers,

@Murtuza: The patch codewise looks good. Nice to see that we are usin= g axios instead of jquery ajax calls and that there is some coverage for th= e change.
Nevertheless the Javascript testing looks a bit slim an= d could be improved. Also the DataSorting class could have some other membe= r functions like the model validation could be extracted out so that it is = easily tested.=C2=A0


@Hackers: This= was how we tried to test this feature:
1 - Started pgAdmin
=
2 - Opened the query tool for a specific server
3 - Executed= a SQL statment
4 - Pressed the column header to try to order, no= thing happened
5 - Right clicked the column header to see if it w= as there the option, nothing

This is the behavior = that we were expecting, not to have to open Data View and then press the ic= on that is not even near the grid in order to sort the column. Is this real= ly the way we want people to use the grid in pgAdmin? Should it be more int= uitive?

Have we consider= ed making the grid behave more like excel or other grids? I think that havi= ng the ascending and descending inside the column header, we could similarl= y provide filtering. Something that would give users a more intuitive place= to look.

Doing the= sorting via header clicks is convenient but very restrictive. How do you s= pecify multiple columns to sort by for example? The current design allows y= ou to select columns and the sort order as you see fit.
=C2=A0
Another reason= we can't use that because w
e have already occupied that behaviou= r for selecting entire column
=E2=80=8B when u= ser clicks on header.
=E2=80=8B
=C2=A0
--
Dave Page
Blog:= http://pgsnake.b= logspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

--001a113d23ded051a50568624fe2--