Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bs5Cf-00013o-PQ for pgadmin-hackers@arkaria.postgresql.org; Thu, 06 Oct 2016 09:43:01 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bs5Cf-0000sy-9D for pgadmin-hackers@arkaria.postgresql.org; Thu, 06 Oct 2016 09:43:01 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bs5Ce-0000sr-Kz for pgadmin-hackers@postgresql.org; Thu, 06 Oct 2016 09:43:00 +0000 Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bs5Cb-00025f-Hy for pgadmin-hackers@postgresql.org; Thu, 06 Oct 2016 09:42:59 +0000 Received: by mail-qk0-x232.google.com with SMTP id t7so11239145qkh.2 for ; Thu, 06 Oct 2016 02:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dIt0Cq7acpfKqbYf1LxKtrbWaMW9f9Ct5lIMk7FwxIE=; b=iq7XCPUcgnNdV4ZWWM/BPvmcWsux74XXo+B2JSaU1TBAUUb/Pudf9M1q1Agk1p+SZp tiJQjSTehZ106MxiQFBjvoHLYD1RObIzDp97ZGLG9nDqyOkQurpCL8wLpY94rWbUrJXt VpBjFYab1bKuRmf9RjUtugFISFE0po1+F2ru7opu27GtY7dzbwJ1cbjHrXfOqDQpAE8B vt8bRyvz1/mC9QSKe/5RIVDg9ZGKLo1of/fw2ur4og+xo7Fl/2UwsK72eYJfFmoJVXLV uB0uGqMXFWHOfJmyLPT9jx1SE/IUEVAwcjGmZk8XHK7N0tuUWUqdUt2/mqe/kVUL9BZs jtXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dIt0Cq7acpfKqbYf1LxKtrbWaMW9f9Ct5lIMk7FwxIE=; b=Q4RXDNCbOgK0oABaL6sdvxAbUwkO6QMSetYNq7gIeSHvZCN9h/9hgGNaduMJLzsZpY +EYP6vBY5ZTPATbvg27e5reX4C5CvStRcwtSWkel6SSXmCEoaZzSibnpR7Rf8mcYJvWf vTGWiLBAC5sQL24EtUg1D+SEut9UbE/ky1lZAZIag+ZWEN7xuEjsP0yQND/iFHEb2zD5 vsd+aXsgRJzEJywPvwesKPENRCmW2ev/WeumEjk1+ENWkQRUTBZMWDxN437DlpyvqWcR iLliZfhn/RyowquKlmx/CQqRVSIJoFCN3B3NNa3JlPxi5k8gleIHc4WUGuH6ef509l7F HI4Q== X-Gm-Message-State: AA6/9RkEVzwOd/lenAutyH+kD9+odGxveI1RQx00wPqRVVwgRdtrt/9OY8zAHVnVNeBC0zHFdWEYhgjiMx2O6AjG X-Received: by 10.55.12.210 with SMTP id 201mr13209318qkm.292.1475746976525; Thu, 06 Oct 2016 02:42:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.118.196 with HTTP; Thu, 6 Oct 2016 02:42:36 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 6 Oct 2016 15:12:36 +0530 Message-ID: Subject: Re: PATCH: To fix issue in synonym node (pgAdmin4) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c062cc650dbcb053e2f1e34 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c062cc650dbcb053e2f1e34 Content-Type: text/plain; charset=UTF-8 Hi Dave, The issue you mentioned is different issue and not related to synonyms node. I will create separate ticket & work on it mean while you can commit changes for RM#1611 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Oct 5, 2016 at 6:53 PM, Dave Page wrote: > Hi > > I created a synonym from within the "dave" schema, but selected > "public" (which wasn't expanded), and it placed the synonym as a > direct child of "public". See the attached screenshot. > > On Wed, Oct 5, 2016 at 1:28 PM, Murtuza Zabuawala > wrote: > > Hi Dave, > > > > PFA updated patch, Added schema filter in sql. > > Please review. > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Wed, Oct 5, 2016 at 5:38 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala > >> wrote: > >> > Hi, > >> > > >> > PFA patch to fix the issue in synonym node, where it was not horning > >> > parent > >> > node while creating in different node, issue was that we were not > >> > sending > >> > node properly. > >> > RM#1611 > >> > >> That doesn't seem like a reliable way to get the correct parent ID - > >> what if there are multiple synonyms in different schemas but with the > >> same name? > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c062cc650dbcb053e2f1e34 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

The issue you mentioned is dif= ferent issue and not related to synonyms node.
I will create sepa= rate ticket & work on it mean while you can commit changes for RM#1611<= /div>

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Oct 5, 2016 at 6:53 PM, Dave Page <= dpage@pgadmin.org> wrote:
H= i

I created a synonym from within the "dave" schema, but selected "public" (which wasn't expanded), and it placed the synonym a= s a
direct child of "public". See the attached screenshot.

On Wed, Oct 5, 2016 at 1:28 PM, Murtuza Zabuawala
<murtuza.zabuawala= @enterprisedb.com> wrote:
> Hi Dave,
>
> PFA updated patch, Added schema filter in sql.
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Oct 5, 2016 at 5:38 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala
>> <murtuza.= zabuawala@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue in synonym node, where it was not = horning
>> > parent
>> > node while creating in different node, issue was that we were= not
>> > sending
>> > node properly.
>> > RM#1611
>>
>> That doesn't seem like a reliable way to get the correct paren= t ID -
>> what if there are multiple synonyms in different schemas but with = the
>> same name?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--94eb2c062cc650dbcb053e2f1e34--