Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3iIp-00046r-9M for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Apr 2017 12:13:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d3iIn-0000lO-VS for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Apr 2017 12:13:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d3iIn-0000lF-Ex for pgadmin-hackers@postgresql.org; Thu, 27 Apr 2017 12:13:41 +0000 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d3iIi-0005Sh-OK for pgadmin-hackers@postgresql.org; Thu, 27 Apr 2017 12:13:40 +0000 Received: by mail-wr0-x235.google.com with SMTP id l50so15969208wrc.3 for ; Thu, 27 Apr 2017 05:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dmB1PNUC0FXjeeRB4RIYGk87EoUXPp0fYD4qYdPv3Nc=; b=Po+wZPAs8x55HQMq6Kf4PeGFBzjpKm0wG8acso6ls1eu4mvWDZzTTPtO60qTAJ+Gb1 9PbsoaiBjXNFMYRUECSEK5hXUAe+68K5FFqSeXBl9yV5A/7vaUrAzVGsaVLpYBXZKhod HR8dAUkgphbndXKe1swuQ3O+FIJZlnvd6qxdqvJobUGBAmEl6LYN73HinWk+wCFynZYh xSuP4MwcsMMgcn82nWnTsGljaoOQzUqZB/hRvdnRR7P+MhSiF8ptSXAwsYVvUmRlzkn7 s4EN3TUUJtz6XUiWEd1QeFGDPgzIPuJBWzIjrw+5BhbTr85FIlLsJaNbagbqIH8Ce++z 97gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dmB1PNUC0FXjeeRB4RIYGk87EoUXPp0fYD4qYdPv3Nc=; b=iTQk9iBmMn8yKPH3acNP+6MAYWvNtODbIRqMDorXo9PaUhW8MWXl8zLPmHe4PUA5Wu l8pb0WUcfip9idCoNYNvUz4QbKQYDJd/f8ZR0iGII1VfUSg5GsENOHg9aghETqbuHOUx mm8eEl5hDJTWWwz1GAUz9s1YY8UWYL3Gx1sM8EkEtJhp5haeqNOx4szvaa0xeuvb25gu 4OB3KN3oduxBsOUPbXuSsln44DZ+AhN2mAvjbrtkW5mzPA6zw8y5UTFztKQKymrgG70n 5ZLhaV5NvlMz1B2KGwQ0lBGdmMDjw1VVz2J3jiL+LmELKdEGx9oW4Y/50/qWxGEMSULC UMxQ== X-Gm-Message-State: AN3rC/6Nrkvm4Qy/o++h7xThJgcx24BBtr0vr1//d7qvgGPXd0eYONss ooEvzcOIRbE8mzuIo5aO4s7jwIQRLTHM X-Received: by 10.223.139.150 with SMTP id o22mr2772381wra.118.1493295214752; Thu, 27 Apr 2017 05:13:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.136.70 with HTTP; Thu, 27 Apr 2017 05:13:14 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 27 Apr 2017 17:43:14 +0530 Message-ID: Subject: Re: Issue with SlickGrid To: Joao Pedro De Almeida Pereira Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=f403045e9cd0d20e18054e24e276 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --f403045e9cd0d20e18054e24e276 Content-Type: text/plain; charset=UTF-8 No, we didn't. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 27, 2017 at 4:42 PM, Joao Pedro De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello Murtuza, > Thanks for the explanation. Based on what you said it looks like a bug in > the library, have you guys considered sending a PR to it? > > Thanks > > On Thu, Apr 27, 2017, 2:46 AM Murtuza Zabuawala enterprisedb.com> wrote: > >> +++ >> Reference: https://www.postgresql.org/message-id/ >> CAKKotZRjqbKAZev81Zk78nikDVXqLKEDV5r%2BsW8Me31Gpzrm_A%40mail.gmail.com >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Thu, Apr 27, 2017 at 12:09 PM, Murtuza Zabuawala > enterprisedb.com> wrote: >> >>> Hello Joao, >>> >>> Yes, We made some changes in SlickGrid library when we integrated it >>> into Query tool. >>> >>> *Issue:* Last row from the query result set was not displaying >>> correctly in query tool when we have scrollbar in grid. >>> >>> The row hight/width pixel size calculations is done inside SlickGrid >>> javascript code, Though we tried solve it through CSS but we had no luck, >>> so we had no other choice but to do it in library it self. >>> >>> The changes were, >>> 1) "getDataLengthIncludingAddNew()" function (slick.grid.js) to add two >>> new rows instead of one when user add values into row (one row is dummy & >>> not visible to user so that it displays last row correctly) >>> 2) Other change was done into "appendRowHtml()" function to calculating >>> the correct number of rows in SlickGrid result as we have added our own >>> custom row as mentioned earlier. >>> 3) Abbreviated long CSS classes as mentioed in README file. >>> >>> Apologies we missed to update this change in README. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hello Hackers, >>>> >>>> While doing some changes to the Query Results we found out that there >>>> was a issue with Slick grid. >>>> >>>> The issue that we found was with the CellSelectModel, behaved >>>> differently when pressing Ctrl and Command(Mac). We created a PR >>>> with the change to >>>> changes the behavior of the plugin. >>>> >>>> When this PR is applied to the SlickGrid library we need to apply it to >>>> the current version of SlickGrid that we have vendorized. >>>> According to the libraries.txt file we are in version 2.2.4 of the >>>> library but a diff between our code and the libraries version 2.2.4 shows >>>> differences in the code. >>>> >>>> Did we do any change to SlickGrid library that is vendorized? Or is >>>> just the information in libraries.txt that is incorrect? >>>> Does anyone know any problem if we bump the version of SlickGrid to the >>>> newer version after the PR is applied? >>>> >>>> Thanks >>>> Joao >>>> >>> >>> >> --f403045e9cd0d20e18054e24e276 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
No, we didn't.=C2=A0
<= br clear=3D"all">
--
Regard= s,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise P= ostgreSQL Company

On Thu, Apr 27, 2017 at 4:42 PM, Joao Pedro = De Almeida Pereira <jdealmeidapereira@pivotal.io>= wrote:

Hello Murtuza,
Thanks for the explanation. Based on what you said it looks like a bug in t= he library, have you guys considered sending a PR to it?

Thanks


On Thu, Apr 27, 2017, 2:46 = AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote= :

=
--=
Regards,
Murtuza Zabuawala
Enterpri= seDB:=C2=A0http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company

On Thu, Apr= 27, 2017 at 12:09 PM, Murtuza Zabuawala <murtuza.zabuawa= la@enterprisedb.com> wrote:
Hello Joao,

Yes, We made some cha= nges in SlickGrid library when we integrated it into Query tool.
=
Issue: Last row from the query result set was not dis= playing correctly in query tool when we have scrollbar in grid.

The row hight/width pixel size calculations is done = inside SlickGrid javascript code, Though we tried solve it through CSS but = we had no luck, so we had no other choice but to do it in library it self.<= /div>
=C2=A0=C2=A0
The changes were,
1) &= quot;getDataLengthIncludingAddNew()" function (slick.grid.js) to = add two new rows instead of one when user add values into row (one row is d= ummy & not visible to user so that it displays last row correctly)
2) Other change was done into "appendRowHtml()" function to= calculating the correct number of rows in SlickGrid result as we have adde= d our own custom row as mentioned earlier.
3) Abbreviated long CS= S classes as mentioed in README file.
=C2=A0
Apolo= gies we missed to update this change in README.

<= /div>

--
Regards,
Murtuza Zabuawala
EnterpriseDB= :=C2=A0http://www.enterprised= b.com
The Enterprise PostgreSQL Company

On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro = De Almeida Pereira <jdealmeidapereira@pivotal.io>= wrote:
Hello Hackers,
While doing some changes to the Query Results we found ou= t that there was a issue with Slick grid.=C2=A0

Th= e issue that we found was with the CellSelectModel, behaved differently whe= n pressing Ctrl and Command(Mac). We created a PR with the change to chan= ges the behavior of the plugin.

When this PR is ap= plied to the SlickGrid library we need to apply it to the current version o= f SlickGrid that we have vendorized.
According to the libraries.t= xt file we are in version 2.2.4 of the library but a diff between our code = and the libraries version 2.2.4 shows differences in the code.
Did we do any change to SlickGrid library that is vendorized? = Or is just the information in libraries.txt that is incorrect?
Do= es anyone know any problem if we bump the version of SlickGrid to the newer= version after the PR is applied?

Thanks
Joao



--f403045e9cd0d20e18054e24e276--