public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 commit: 1) Added email id validation on the login page.
Date: Wed, 16 Sep 2020 14:52:36 +0530
Message-ID: <CAKKotZSOqPiacUcP1ONhKZD2fomeGODP8v+w4VLJyXQyQfndqQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Hi Team,
PFA patch to fix typo introduced with this patch.
--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com
On Fri, Sep 11, 2020 at 8:07 PM Akshay Joshi <[email protected]>
wrote:
> 1) Added email id validation on the login page.
> 2) Added validation for the file manager.
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b82e6dbdb8646de0bd35c7297f81a32dee5d...
> Author: Aditya Toshniwal <[email protected]>
>
> Modified Files
> --------------
> web/pgadmin/authenticate/internal.py | 15 +++++++----
> web/pgadmin/misc/file_manager/__init__.py | 37
> ++++++++++++---------------
> web/pgadmin/setup/user_info.py | 10 +++-----
> web/pgadmin/tools/user_management/__init__.py | 22 +++++++++++-----
> web/pgadmin/utils/paths.py | 19 +++++++++++---
> web/pgadmin/utils/validation_utils.py | 26 +++++++++++++++++++
> 6 files changed, 86 insertions(+), 43 deletions(-)
>
>
Attachments:
[application/octet-stream] typo.diff (492B, 3-typo.diff)
download | inline diff:
diff --git a/web/pgadmin/utils/paths.py b/web/pgadmin/utils/paths.py
index 30bbcfa47..04522528b 100644
--- a/web/pgadmin/utils/paths.py
+++ b/web/pgadmin/utils/paths.py
@@ -37,7 +37,7 @@ def get_storage_directory():
def _preprocess_username(un):
ret_un = un
if len(ret_un) == 0 or ret_un[0].isdigit():
- ret_un = 'pga_user_' + username
+ ret_un = 'pga_user_' + un
ret_un = ret_un.replace('@', '_')\
.replace('/', 'slash')\
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: 1) Added email id validation on the login page.
In-Reply-To: <CAKKotZSOqPiacUcP1ONhKZD2fomeGODP8v+w4VLJyXQyQfndqQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox