public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list
Date: Mon, 20 May 2019 12:31:27 +0530
Message-ID: <CAKKotZSQuwBakQ0y9pi_V6W+WBgCZbpVnM438CuN5kE9k0ZmDA@mail.gmail.com> (raw)
Hi,
PFA minor patch to fix the issue with Backgrid PasswordCell.
In the Backgrid PasswordCell, The browser's autocomplete functionality
opens up the saved password list which cause the Backgrid to lose focus
from the current cell and causes issue in keyboard navigation.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] RM_4278.diff (432B, 3-RM_4278.diff)
download | inline diff:
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index 804dc92d..c8046093 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -1256,6 +1256,7 @@ define([
editor: Backgrid.InputCellEditor.extend({
attributes: {
type: 'password',
+ autocomplete: 'new-password',
},
render: function() {
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list
In-Reply-To: <CAKKotZSQuwBakQ0y9pi_V6W+WBgCZbpVnM438CuN5kE9k0ZmDA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox