Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjK2L-0003M1-9A for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Sep 2016 05:44:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bjK2K-0000AA-Rx for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Sep 2016 05:44:08 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bjK27-0008NP-HT for pgadmin-hackers@postgresql.org; Mon, 12 Sep 2016 05:43:55 +0000 Received: from mail-qt0-x22b.google.com ([2607:f8b0:400d:c0d::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bjK24-0000rT-A0 for pgadmin-hackers@postgresql.org; Mon, 12 Sep 2016 05:43:54 +0000 Received: by mail-qt0-x22b.google.com with SMTP id l91so50154139qte.3 for ; Sun, 11 Sep 2016 22:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bGd7H+bqdRrRwNHKQl8eIj/e7tJ0EHeXnVa/tS4mQzg=; b=mRSETcFL3iQC+uuZqecwk65RHzZ/yLhYyiuQW3wpgUWYx6+1SQfQBt6PX3NqjOXjrJ lUOg7AqirUSJ5+suTXHx/A5B/cX9M2wJs7G0Kf/FG9Px5kr6ZjolybxakCynq6PXavwm 02IE1+s/YpGeBilhE8PuvVZjYEQizRCQLgtLgq4Md1J24LxBh+tt6X656rfJ0p6xks9C pPxM5nvitzxq+tHISoD0qiwsxpvLksINUtj/rHkPl7JmfDHXppzfZpfBEWmjmZ7/6Lie B56QF+C0q/x3tTUjLGu400CSXwLpguQMx9RCESOhDxRg2rWPZzVM0lSlRTrZygTJa24G uQxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bGd7H+bqdRrRwNHKQl8eIj/e7tJ0EHeXnVa/tS4mQzg=; b=O/QoYLnscrel7eoBiaz37pCP3N6lk9U8/gPc1buJyw5HZySmxCiSGNK3gQSJ32Gfs0 //i9DqpquLdc0wgARiivsaoxDSprN6TUGgNY5MktM6orRJdQuIk0AUj5QtuW0jiZenIV 6cmUiXS1aK7G+7YjdzNE1fjbzBGOYTvh4h4SJXAdBoZZr5v9xI1vV30WgHp+DbaI3lPj svy8LweKFN7m7TFbODnLqGeTrd4NEqbOz+utv8bSYBVjOv2D0Z82dXHf07c8YipNbeRG MvQdKHdiJHStdrCFTDwkDhxuxZ8rZ3beAA/Ch4CAye/6KD5GZmcLzr+MgXjfNAAgD9/e 95jQ== X-Gm-Message-State: AE9vXwPIeXE/wW9jEylN5weHReJqhM5YAjKZrIG3HeUoL4PksZLPESVNx2/CPxYnOhnTrumUHRpyWJn0wsG8i42x X-Received: by 10.200.45.125 with SMTP id o58mr17738602qta.63.1473659031178; Sun, 11 Sep 2016 22:43:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.129.194 with HTTP; Sun, 11 Sep 2016 22:43:30 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 12 Sep 2016 11:13:30 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1147070012e2c8053c48fb8d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1147070012e2c8053c48fb8d Content-Type: text/plain; charset=UTF-8 Hi Surinder, Just a heads up, When server is not connected and listed down in browser tree then node has attribute 'type' instead of 'server_type'. I have fixed similar issue few days ago Ref. link -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 12, 2016 at 10:42 AM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi > > *Please find attached with following fixes:* > > 1) The function '*canCreateProc*' that checks if package is auth to > create under catalog gets failed due to improper check of 'type'. Instead > check should be like > node_hierarchy['server'].*server_type* == "ppas" not > node_hierarchy['server'].*type* == "ppas" > > 2) Also found, *package.js* was loading at schema level, due to this, > context menu doesn't popup under catalog. Now it is load at database level. > > 3) In *package.js*, remove extra comma from columns array. > > 4) Rule create option should not available on table under catalogs. Fixed. > > Please review. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --001a1147070012e2c8053c48fb8d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Surinder,

Just a heads up, When serv= er is not connected and listed down in browser tree then node has attribute= 'type' instead of 'server_type'.
I have fixed simi= lar issue few days ago Ref. li= nk

--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company=

On Mon, Sep 12, 2016 at 10:42 AM, Surinder K= umar <surinder.kumar@enterprisedb.com> wrote:<= br>
Hi

Please find attached with following fixes:

1) The function &#= 39;canCreateProc' that checks if package is auth to create under= catalog gets failed due to improper check of 'type'. Instead check= should be like
node_hierarchy['server'].server_type =3D=3D "ppas= " not=C2=A0
node_hierarchy['server'].type=C2=A0=3D=3D "p= pas"
<= br>
2) Also fou= nd, package.js was loading at schema level, due to this, context men= u doesn't popup under catalog. Now it is load at database level.
<= div class=3D"gmail_default" style=3D"font-size:small">
3) In package.js, remov= e extra comma from columns array.

4) Rule create option should not available on table under catalo= gs. Fixed.

=
Please review.=

Thanks,
Surinder Kumar


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers


--001a1147070012e2c8053c48fb8d--