Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAtNn-00014a-TB for pgadmin-hackers@arkaria.postgresql.org; Wed, 17 May 2017 07:28:32 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dAtNn-0002aS-Fn for pgadmin-hackers@arkaria.postgresql.org; Wed, 17 May 2017 07:28:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dAtNn-0002Vm-1N for pgadmin-hackers@postgresql.org; Wed, 17 May 2017 07:28:31 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dAtNi-00040o-Pa for pgadmin-hackers@postgresql.org; Wed, 17 May 2017 07:28:30 +0000 Received: by mail-wm0-x230.google.com with SMTP id b84so154260082wmh.0 for ; Wed, 17 May 2017 00:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=O1OskGAgZeIR6gow/q9MbhTSRPcAj5VTUhRoLTlFDPc=; b=Zs4FQLmJLIYTDCpeCsvEP8gxVSVjUdwuaeQwrs10vCC0tJWnqmKRW0QcjbkkMe7BtP CrIYmo9FsMIFXGazaaUoqZ3dSF+NNmpa8wFa1DtB9t4ia8jnwuCl/X5iF6YlLPpBdRb3 3W++lghgF/3e1Mrz2byg9Tc3FYxYOjL2ZEcWz1RZ5azk8HsBbC0WjZpGWd1pINPT2sRN AB8URwh7ppcyH3wd3Dw3WOpsnjMX+FsH7mfzvkn6etazoEEcL+QUBpWWI/iksX7xP4Td BAZurpUu1/pTIFJJ/xyUtEDqXiBleFI90RGHIdzlyv3048VrJzxWbCLn9MgBZlFdiO1c k8Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=O1OskGAgZeIR6gow/q9MbhTSRPcAj5VTUhRoLTlFDPc=; b=Kr+dn9U2ENS5A9cQqwa5GkbLcs61QmaY7jUC/9DUgSlN4j2qTxwnOMJjgiIWKGfgFY 5e5TDSPqbzMk11KES3ulh4o8uEEWG73hYBCv1Huhij1OfaJFVE+y4yZ3beeEfmuBeJQs toIgKLnLuXN33X5uQPLTPWxknS9zluFu+J6hs7SQBv6VzxM88vIHE73TY5iG52kOdJXZ YvuFuE8EnSQmy0CqcYKlJBahW1wZnPuqxMNyb34HlMgSRDJ9mWsrj3Ja+hjzenzrjrZ7 k0f8vwbEdUr9uK/yxexoP0eDCcL1p0jPlfNcdIkcw0avNEq7rVXA2/pDQxkxo879EOtp 01JA== X-Gm-Message-State: AODbwcBkxT8FVjy7c96fAXOqlZai/Gdgn1EYQ7y00rfRKqkuKC4U2+NL j9EvRE5TnS3J7ZKUKaO8CqkEZ5W0uPjoOWQ= X-Received: by 10.28.167.72 with SMTP id q69mr1342438wme.73.1495006105435; Wed, 17 May 2017 00:28:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.136.70 with HTTP; Wed, 17 May 2017 00:28:04 -0700 (PDT) From: Murtuza Zabuawala Date: Wed, 17 May 2017 12:58:04 +0530 Message-ID: Subject: [pgAdmin4][PATCH] To fix the issue in server group node To: pgadmin-hackers Content-Type: multipart/mixed; boundary="001a114b4186da67b0054fb33bb3" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114b4186da67b0054fb33bb3 Content-Type: multipart/alternative; boundary="001a114b4186da67aa054fb33bb1" --001a114b4186da67aa054fb33bb1 Content-Type: text/plain; charset="UTF-8" Hi, PFA minor patch to fix the in server group node, If you user creates/update server group name which is already present in tree then it fails and it does not provide clear informative error message regarding failure. Issue found during testing node rename issue :) RM#2414 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114b4186da67aa054fb33bb1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

PFA minor patch = to fix the in server group node,=C2=A0If you user creates/update server gro= up name which is already present in tree then it fails and it does not prov= ide clear informative error message regarding failure.

Issue found duri= ng testing node rename issue :)
RM#241= 4

--
Regards,
Murtuza Zabuawala
Enterpri= seDB:=C2=A0http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company
--001a114b4186da67aa054fb33bb1-- --001a114b4186da67b0054fb33bb3 Content-Type: text/plain; charset="US-ASCII"; name="server_group_duplicate_name_issue.diff" Content-Disposition: attachment; filename="server_group_duplicate_name_issue.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j2ry10ds0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9fX2luaXRfXy5weSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dy b3Vwcy9fX2luaXRfXy5weQppbmRleCA4ZDI4ZWM0Li5lMzM3ZDg1IDEwMDY0 NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvX19p bml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3Jv dXBzL19faW5pdF9fLnB5CkBAIC0xOSw5ICsxOSw5IEBAIGZyb20gZmxhc2tf c2VjdXJpdHkgaW1wb3J0IGN1cnJlbnRfdXNlcgogZnJvbSBwZ2FkbWluLmJy b3dzZXIgaW1wb3J0IEJyb3dzZXJQbHVnaW5Nb2R1bGUKIGZyb20gcGdhZG1p bi5icm93c2VyLnV0aWxzIGltcG9ydCBOb2RlVmlldwogZnJvbSBwZ2FkbWlu LnV0aWxzLmFqYXggaW1wb3J0IG1ha2VfanNvbl9yZXNwb25zZSwgZ29uZSwg XAotICAgIG1ha2VfcmVzcG9uc2UgYXMgYWpheF9yZXNwb25zZQorICAgIG1h a2VfcmVzcG9uc2UgYXMgYWpheF9yZXNwb25zZSwgYmFkX3JlcXVlc3QKIGZy b20gcGdhZG1pbi51dGlscy5tZW51IGltcG9ydCBNZW51SXRlbQotCitmcm9t IHNxbGFsY2hlbXkgaW1wb3J0IGV4YwogZnJvbSBwZ2FkbWluLm1vZGVsIGlt cG9ydCBkYiwgU2VydmVyR3JvdXAKIAogCkBAIC0xNzQsNiArMTc0LDEwIEBA IGNsYXNzIFNlcnZlckdyb3VwVmlldyhOb2RlVmlldyk6CiAgICAgICAgICAg ICAgICAgaWYgdSduYW1lJyBpbiBkYXRhOgogICAgICAgICAgICAgICAgICAg ICBzZXJ2ZXJncm91cC5uYW1lID0gZGF0YVt1J25hbWUnXQogICAgICAgICAg ICAgICAgIGRiLnNlc3Npb24uY29tbWl0KCkKKyAgICAgICAgICAgIGV4Y2Vw dCBleGMuSW50ZWdyaXR5RXJyb3I6CisgICAgICAgICAgICAgICAgcmV0dXJu IGJhZF9yZXF1ZXN0KGdldHRleHQoCisgICAgICAgICAgICAgICAgICAgICJU aGUgc3BlY2lmaWVkIHNlcnZlciBncm91cCBhbHJlYWR5IGV4aXN0cy4iCisg ICAgICAgICAgICAgICAgKSkKICAgICAgICAgICAgIGV4Y2VwdCBFeGNlcHRp b24gYXMgZToKICAgICAgICAgICAgICAgICByZXR1cm4gbWFrZV9qc29uX3Jl c3BvbnNlKAogICAgICAgICAgICAgICAgICAgICBzdGF0dXM9NDEwLCBzdWNj ZXNzPTAsIGVycm9ybXNnPWUubWVzc2FnZQpAQCAtMjIwLDE4ICsyMjQsNiBA QCBjbGFzcyBTZXJ2ZXJHcm91cFZpZXcoTm9kZVZpZXcpOgogICAgICAgICAp CiAgICAgICAgIGlmIGRhdGFbdSduYW1lJ10gIT0gJyc6CiAgICAgICAgICAg ICB0cnk6Ci0gICAgICAgICAgICAgICAgY2hlY2tfc2cgPSBTZXJ2ZXJHcm91 cC5xdWVyeS5maWx0ZXJfYnkoCi0gICAgICAgICAgICAgICAgICAgIHVzZXJf aWQ9Y3VycmVudF91c2VyLmlkLAotICAgICAgICAgICAgICAgICAgICBuYW1l PWRhdGFbdSduYW1lJ10pLmZpcnN0KCkKLQotICAgICAgICAgICAgICAgICMg VGhyb3cgZXJyb3IgaWYgc2VydmVyIGdyb3VwIGFscmVhZHkgZXhpc3RzLi4u Ci0gICAgICAgICAgICAgICAgaWYgY2hlY2tfc2cgaXMgbm90IE5vbmU6Ci0g ICAgICAgICAgICAgICAgICAgIHJldHVybiBtYWtlX2pzb25fcmVzcG9uc2Uo Ci0gICAgICAgICAgICAgICAgICAgICAgICBzdGF0dXM9NDA5LAotICAgICAg ICAgICAgICAgICAgICAgICAgc3VjY2Vzcz0wLAotICAgICAgICAgICAgICAg ICAgICAgICAgZXJyb3Jtc2c9Z2V0dGV4dCgnU2VydmVyIGdyb3VwIGFscmVh ZHkgZXhpc3RzJykKLSAgICAgICAgICAgICAgICAgICAgKQotCiAgICAgICAg ICAgICAgICAgc2cgPSBTZXJ2ZXJHcm91cCgKICAgICAgICAgICAgICAgICAg ICAgdXNlcl9pZD1jdXJyZW50X3VzZXIuaWQsCiAgICAgICAgICAgICAgICAg ICAgIG5hbWU9ZGF0YVt1J25hbWUnXSkKQEAgLTI0OCw5ICsyNDAsMTUgQEAg Y2xhc3MgU2VydmVyR3JvdXBWaWV3KE5vZGVWaWV3KToKICAgICAgICAgICAg ICAgICAgICAgICAgICJpY29uLSVzIiAlIHNlbGYubm9kZV90eXBlLAogICAg ICAgICAgICAgICAgICAgICAgICAgVHJ1ZSwKICAgICAgICAgICAgICAgICAg ICAgICAgIHNlbGYubm9kZV90eXBlLAotICAgICAgICAgICAgICAgICAgICAg ICAgY2FuX2RlbGV0ZT1UcnVlICAjIFRoaXMgaXMgdXNlciBjcmVhdGVkIGhl bmNlIGNhbiBkZWxldGVkCisgICAgICAgICAgICAgICAgICAgICAgICAjIFRo aXMgaXMgdXNlciBjcmVhdGVkIGhlbmNlIGNhbiBkZWxldGVkCisgICAgICAg ICAgICAgICAgICAgICAgICBjYW5fZGVsZXRlPVRydWUKICAgICAgICAgICAg ICAgICAgICAgKQogICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgIGV4 Y2VwdCBleGMuSW50ZWdyaXR5RXJyb3I6CisgICAgICAgICAgICAgICAgcmV0 dXJuIGJhZF9yZXF1ZXN0KGdldHRleHQoCisgICAgICAgICAgICAgICAgICAg ICJUaGUgc3BlY2lmaWVkIHNlcnZlciBncm91cCBhbHJlYWR5IGV4aXN0cy4i CisgICAgICAgICAgICAgICAgKSkKKwogICAgICAgICAgICAgZXhjZXB0IEV4 Y2VwdGlvbiBhcyBlOgogICAgICAgICAgICAgICAgIHJldHVybiBtYWtlX2pz b25fcmVzcG9uc2UoCiAgICAgICAgICAgICAgICAgICAgIHN0YXR1cz00MTAs Cg== --001a114b4186da67b0054fb33bb3 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114b4186da67b0054fb33bb3--