MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZRwaG6X-9ZZ3+CCMQ0y=h7kTR_ver=QfWf6savrjtbF3A@mail.gmail.com>
References: 
 <CAKKotZSRSKPWzapTT6fJQiCAprRs_h644mXkeP_ba-NbynJufg@mail.gmail.com>
 <CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com>
 <CA+OCxox3gREiVKvXSh2=OjooseZH3cveT90C97k6mH6s0AYGnA@mail.gmail.com>
 <CAKKotZRwaG6X-9ZZ3+CCMQ0y=h7kTR_ver=QfWf6savrjtbF3A@mail.gmail.com>
From: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Date: Wed, 7 Mar 2018 20:29:46 +0530
Message-ID: 
 <CAKKotZSas8Chx0neZqpvFwSBPE1JDwF=afbvP3aptfF578Xhxw@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node
To: Dave Page <dpage@pgadmin.org>
Cc: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="001a114790ea9520f30566d3d07d"
Precedence: bulk

--001a114790ea9520f30566d3d07d
Content-Type: multipart/alternative; boundary="001a114790ea9520ef0566d3d07b"

--001a114790ea9520ef0566d3d07b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Mar 7, 2018 at 6:14 PM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

>
> On Wed, Mar 7, 2018 at 6:12 PM, Dave Page <dpage@pgadmin.org> wrote:
>
>> Hi
>>
>> On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <
>> jdealmeidapereira@pivotal.io> wrote:
>>
>>> Hi Murtuza,
>>>
>>> The code change works, and I passed the patches through our pipeline an=
d
>>> everything is green.
>>> Personally I would love this bug fixes to have refactored the function
>>> into smaller chunk and made it more readable so that the next time some=
one
>>> need to check out a problem in the same area it is easier. I understand
>>> that without a good test coverage it is hard to have confidence while
>>> refactoring, but we need to start somewhere.
>>>
>>
>> Are you planning to look into this Murtuza?
>>
> =E2=80=8BYes Dave, I am working on another issue, I'll pick up after that=
.=E2=80=8B
>
>
>>
>>
>>>
>>> @Hackers
>>> Here is a video that I saw some time ago about refactoring existing cod=
e
>>> and code complexity that is very interesting
>>> https://www.youtube.com/watch?v=3D8bZh5LMaSmE
>>> In this video Sandi Metz does the Gilded Rose Kata in a talk in
>>> RailsConf 2014, and with it tries to demonstrate that code can be
>>> refactored and with that it make the code much more simpler. But the
>>> journey is not always simple and the complexity will increase before it=
 get
>>> simpler. It is a good example of something that we can try with our cod=
e.
>>>
>>
>> Nice!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--001a114790ea9520ef0566d3d07b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:verdana,=
sans-serif;color:#444444">Hi Dave,</div><div class=3D"gmail_default" style=
=3D"font-family:verdana,sans-serif;color:#444444"><br></div><div class=3D"g=
mail_default" style=3D"font-family:verdana,sans-serif;color:#444444">PFA up=
dated patch.</div></div><div class=3D"gmail_extra"><br clear=3D"all"><div><=
div class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div dir=
=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr">=
<div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2" face=3D"verdan=
a, sans-serif" color=3D"#444444">--</font><div><font size=3D"2" face=3D"ver=
dana, sans-serif" color=3D"#444444">Regards,</font><div><font size=3D"2"><f=
ont face=3D"verdana, sans-serif" color=3D"#444444">Murtuza Zabuawala<br>Ent=
erpriseDB:=C2=A0<a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer"=
 target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise Postgr=
eSQL Company</font></font></div></div><div><font size=3D"2"><font face=3D"v=
erdana, sans-serif" color=3D"#444444"><img src=3D"https://drive.google.com/=
a/enterprisedb.com/uc?id=3D0B6jGeB3BfKRMV0t4MEp0YnZCTTA&amp;export=3Ddownlo=
ad" width=3D"420" height=3D"31"><br></font></font></div></div></div></div><=
/div></div></div></div></div></div></div></div></div></div>
<br><div class=3D"gmail_quote">On Wed, Mar 7, 2018 at 6:14 PM, Murtuza Zabu=
awala <span dir=3D"ltr">&lt;<a href=3D"mailto:murtuza.zabuawala@enterprised=
b.com" target=3D"_blank">murtuza.zabuawala@enterprisedb.com</a>&gt;</span> =
wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bord=
er-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div class=3D"gma=
il_default" style=3D"font-family:verdana,sans-serif;color:#444444"><br></di=
v><div class=3D"gmail_extra"><div class=3D"gmail_quote">On Wed, Mar 7, 2018=
 at 6:12 PM, Dave Page <span dir=3D"ltr">&lt;<a href=3D"mailto:dpage@pgadmi=
n.org" target=3D"_blank">dpage@pgadmin.org</a>&gt;</span> wrote:<br><blockq=
uote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc =
solid;padding-left:1ex"><div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><=
br><div class=3D"gmail_quote">On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almei=
da Pereira <span dir=3D"ltr">&lt;<a href=3D"mailto:jdealmeidapereira@pivota=
l.io" target=3D"_blank">jdealmeidapereira@pivotal.io</a>&gt;</span> wrote:<=
br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left=
:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi Murtuza,<div><br></di=
v><div>The code change works, and I passed the patches through our pipeline=
 and everything is green.</div><div>Personally I would love this bug fixes =
to have refactored the function into smaller chunk and made it more readabl=
e so that the next time someone need to check out a problem in the same are=
a it is easier. I understand that without a good test coverage it is hard t=
o have confidence while refactoring, but we need to start somewhere.</div><=
/div></blockquote><div><br></div><div>Are you planning to look into this Mu=
rtuza?</div></div></div></div></blockquote><div><div class=3D"gmail_default=
" style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68);display:inlin=
e">=E2=80=8BYes Dave, I am working on another issue, I&#39;ll pick up after=
 that.=E2=80=8B</div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D=
"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D=
"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote"><div>=C2=A0</di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:=
1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><br></div><div>@Hack=
ers</div><div>Here is a video that I saw some time ago about refactoring ex=
isting code and code complexity that is very interesting</div><div><a href=
=3D"https://www.youtube.com/watch?v=3D8bZh5LMaSmE" target=3D"_blank">https:=
//www.youtube.com/watch?<wbr>v=3D8bZh5LMaSmE</a><br></div><div>In this vide=
o Sandi Metz does the Gilded Rose Kata in a talk in RailsConf 2014, and wit=
h it tries to demonstrate that code can be refactored and with that it make=
 the code much more simpler. But the journey is not always simple and the c=
omplexity will increase before it get simpler. It is a good example of some=
thing that we can try with our code.</div></div></blockquote><div><br></div=
><div>Nice!=C2=A0</div></div><span class=3D"HOEnZb"><font color=3D"#888888"=
><span class=3D"m_7443262665542031720m_9109930983859666299HOEnZb"><font col=
or=3D"#888888"><div><br></div>-- <br><div class=3D"m_7443262665542031720m_9=
109930983859666299m_6995766218588808395gmail_signature" data-smartmail=3D"g=
mail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" =
target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><=
br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blan=
k">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br>=
</div>
</font></span></font></span></div></div>
</blockquote></div><br></div></div>
</blockquote></div><br></div>

--001a114790ea9520ef0566d3d07b--

--001a114790ea9520f30566d3d07d
Content-Type: application/octet-stream; name="RM_2989_v1.diff"
Content-Disposition: attachment; filename="RM_2989_v1.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_jeh7lyk90

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh
dGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZXN0cy90ZXN0X3RhYmxlX2NvbHVtbl91cGRhdGUucHkg
Yi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2No
ZW1hcy90YWJsZXMvdGVzdHMvdGVzdF90YWJsZV9jb2x1bW5fdXBkYXRlLnB5Cm5ldyBmaWxlIG1v
ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjljNTljMWUKLS0tIC9kZXYvbnVsbAorKysgYi93ZWIv
cGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90
YWJsZXMvdGVzdHMvdGVzdF90YWJsZV9jb2x1bW5fdXBkYXRlLnB5CkBAIC0wLDAgKzEsOTAgQEAK
KyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMjIyMjCisjCisjIHBnQWRtaW4gNCAtIFBvc3RncmVTUUwgVG9vbHMKKyMK
KyMgQ29weXJpZ2h0IChDKSAyMDEzIC0gMjAxOCwgVGhlIHBnQWRtaW4gRGV2ZWxvcG1lbnQgVGVh
bQorIyBUaGlzIHNvZnR3YXJlIGlzIHJlbGVhc2VkIHVuZGVyIHRoZSBQb3N0Z3JlU1FMIExpY2Vu
Y2UKKyMKKyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCisKK2ltcG9ydCBqc29uCitpbXBvcnQgdXVpZAorCitm
cm9tIHBnYWRtaW4uYnJvd3Nlci5zZXJ2ZXJfZ3JvdXBzLnNlcnZlcnMuZGF0YWJhc2VzLnNjaGVt
YXMudGVzdHMgaW1wb3J0IFwKKyAgICB1dGlscyBhcyBzY2hlbWFfdXRpbHMKK2Zyb20gcGdhZG1p
bi5icm93c2VyLnNlcnZlcl9ncm91cHMuc2VydmVycy5kYXRhYmFzZXMudGVzdHMgaW1wb3J0IHV0
aWxzIGFzIFwKKyAgICBkYXRhYmFzZV91dGlscworZnJvbSBwZ2FkbWluLnV0aWxzLnJvdXRlIGlt
cG9ydCBCYXNlVGVzdEdlbmVyYXRvcgorZnJvbSByZWdyZXNzaW9uIGltcG9ydCBwYXJlbnRfbm9k
ZV9kaWN0Citmcm9tIHJlZ3Jlc3Npb24ucHl0aG9uX3Rlc3RfdXRpbHMgaW1wb3J0IHRlc3RfdXRp
bHMgYXMgdXRpbHMKK2Zyb20gLiBpbXBvcnQgdXRpbHMgYXMgdGFibGVzX3V0aWxzCisKKworY2xh
c3MgVGFibGVOb3ROdWxsVXBkYXRlVGVzdENhc2UoQmFzZVRlc3RHZW5lcmF0b3IpOgorICAgICIi
IlRoaXMgY2xhc3Mgd2lsbCBhZGQgbmV3IGNvbGxhdGlvbiB1bmRlciBzY2hlbWEgbm9kZS4iIiIK
KyAgICBzY2VuYXJpb3MgPSBbCisgICAgICAgICgnVXBkYXRlIFRhYmxlIHdpdGggbm90IG51bGwg
ZmllbGQnLCBkaWN0KHVybD0nL2Jyb3dzZXIvdGFibGUvb2JqLycpKSwKKyAgICBdCisKKyAgICBk
ZWYgc2V0VXAoc2VsZik6CisgICAgICAgIHNlbGYuZGJfbmFtZSA9IHBhcmVudF9ub2RlX2RpY3Rb
ImRhdGFiYXNlIl1bLTFdWyJkYl9uYW1lIl0KKyAgICAgICAgc2NoZW1hX2luZm8gPSBwYXJlbnRf
bm9kZV9kaWN0WyJzY2hlbWEiXVstMV0KKyAgICAgICAgc2VsZi5zZXJ2ZXJfaWQgPSBzY2hlbWFf
aW5mb1sic2VydmVyX2lkIl0KKyAgICAgICAgc2VsZi5kYl9pZCA9IHNjaGVtYV9pbmZvWyJkYl9p
ZCJdCisgICAgICAgIGRiX2NvbiA9IGRhdGFiYXNlX3V0aWxzLmNvbm5lY3RfZGF0YWJhc2UoCisg
ICAgICAgICAgICBzZWxmLCB1dGlscy5TRVJWRVJfR1JPVVAsIHNlbGYuc2VydmVyX2lkLCBzZWxm
LmRiX2lkCisgICAgICAgICkKKyAgICAgICAgaWYgbm90IGRiX2NvblsnZGF0YSddWyJjb25uZWN0
ZWQiXToKKyAgICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbigiQ291bGQgbm90IGNvbm5lY3QgdG8g
ZGF0YWJhc2UgdG8gYWRkIGEgdGFibGUuIikKKyAgICAgICAgc2VsZi5zY2hlbWFfaWQgPSBzY2hl
bWFfaW5mb1sic2NoZW1hX2lkIl0KKyAgICAgICAgc2VsZi5zY2hlbWFfbmFtZSA9IHNjaGVtYV9p
bmZvWyJzY2hlbWFfbmFtZSJdCisgICAgICAgIHNjaGVtYV9yZXNwb25zZSA9IHNjaGVtYV91dGls
cy52ZXJpZnlfc2NoZW1hcyhzZWxmLnNlcnZlciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGYuZGJfbmFtZSwKKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGYuc2NoZW1hX25hbWUp
CisgICAgICAgIGlmIG5vdCBzY2hlbWFfcmVzcG9uc2U6CisgICAgICAgICAgICByYWlzZSBFeGNl
cHRpb24oIkNvdWxkIG5vdCBmaW5kIHRoZSBzY2hlbWEgdG8gYWRkIGEgdGFibGUuIikKKworICAg
ICAgICBzZWxmLnRhYmxlX25hbWUgPSAidGVzdF90YWJsZV9jb2x1bW5fcHV0XyVzIiAlIChzdHIo
dXVpZC51dWlkNCgpKVsxOjhdKQorCisgICAgICAgIGN1c3RvbV9zcWwgPSAnY29sdW1uXzEgImNo
YXIiIE5PVCBOVUxMJworCisgICAgICAgIHNlbGYudGFibGVfaWQgPSB0YWJsZXNfdXRpbHMuY3Jl
YXRlX3RhYmxlKAorICAgICAgICAgICAgc2VsZi5zZXJ2ZXIsCisgICAgICAgICAgICBzZWxmLmRi
X25hbWUsCisgICAgICAgICAgICBzZWxmLnNjaGVtYV9uYW1lLAorICAgICAgICAgICAgc2VsZi50
YWJsZV9uYW1lLAorICAgICAgICAgICAgY3VzdG9tX3NxbAorICAgICAgICApCisKKyAgICBkZWYg
cnVuVGVzdChzZWxmKToKKyAgICAgICAgIiIiVGhpcyBmdW5jdGlvbiB3aWxsIGZldGNoIGFkZGVk
IHRhYmxlIHVuZGVyIHNjaGVtYSBub2RlLiIiIgorICAgICAgICB0YWJsZV9yZXNwb25zZSA9IHRh
Ymxlc191dGlscy52ZXJpZnlfdGFibGUoCisgICAgICAgICAgICBzZWxmLnNlcnZlciwgc2VsZi5k
Yl9uYW1lLCBzZWxmLnRhYmxlX2lkCisgICAgICAgICkKKyAgICAgICAgaWYgbm90IHRhYmxlX3Jl
c3BvbnNlOgorICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCJDb3VsZCBub3QgZmluZCB0aGUg
dGFibGUgdG8gdXBkYXRlLiIpCisKKyAgICAgICAgZGF0YSA9IHsKKyAgICAgICAgICAgICJpZCI6
IHNlbGYudGFibGVfaWQsCisgICAgICAgICAgICAiY29sdW1ucyI6IHsKKyAgICAgICAgICAgICAg
ICAiY2hhbmdlZCI6IFsKKyAgICAgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAg
ICAgICAgImF0dG51bSI6IDEsCisgICAgICAgICAgICAgICAgICAgICAgICAiYXR0bm90bnVsbCI6
IEZhbHNlCisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBdCisgICAgICAg
ICAgICB9CisgICAgICAgIH0KKworICAgICAgICByZXNwb25zZSA9IHNlbGYudGVzdGVyLnB1dCgK
KyAgICAgICAgICAgIHNlbGYudXJsICsgc3RyKHV0aWxzLlNFUlZFUl9HUk9VUCkgKyAnLycgKwor
ICAgICAgICAgICAgc3RyKHNlbGYuc2VydmVyX2lkKSArICcvJyArIHN0cihzZWxmLmRiX2lkKSAr
ICcvJyArCisgICAgICAgICAgICBzdHIoc2VsZi5zY2hlbWFfaWQpICsgJy8nICsgc3RyKHNlbGYu
dGFibGVfaWQpLAorICAgICAgICAgICAgZGF0YT1qc29uLmR1bXBzKGRhdGEpLCBmb2xsb3dfcmVk
aXJlY3RzPVRydWUKKyAgICAgICAgKQorCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHJlc3Bv
bnNlLnN0YXR1c19jb2RlLCAyMDApCisKKyAgICBkZWYgdGVhckRvd24oc2VsZik6CisgICAgICAg
ICMgRGlzY29ubmVjdCB0aGUgZGF0YWJhc2UKKyAgICAgICAgZGF0YWJhc2VfdXRpbHMuZGlzY29u
bmVjdF9kYXRhYmFzZShzZWxmLCBzZWxmLnNlcnZlcl9pZCwgc2VsZi5kYl9pZCkKZGlmZiAtLWdp
dCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9z
Y2hlbWFzL3RhYmxlcy90ZXN0cy91dGlscy5weSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVy
X2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy90ZXN0cy91dGlscy5weQpp
bmRleCA0Y2VjMzIzLi5iNzIyMTQ3IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3Nl
cnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdGVzdHMvdXRpbHMu
cHkKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJh
c2VzL3NjaGVtYXMvdGFibGVzL3Rlc3RzL3V0aWxzLnB5CkBAIC0xNSw3ICsxNSw4IEBAIGltcG9y
dCB0cmFjZWJhY2sKIGZyb20gcmVncmVzc2lvbi5weXRob25fdGVzdF91dGlscyBpbXBvcnQgdGVz
dF91dGlscyBhcyB1dGlscwogCiAKLWRlZiBjcmVhdGVfdGFibGUoc2VydmVyLCBkYl9uYW1lLCBz
Y2hlbWFfbmFtZSwgdGFibGVfbmFtZSk6CitkZWYgY3JlYXRlX3RhYmxlKHNlcnZlciwgZGJfbmFt
ZSwgc2NoZW1hX25hbWUsIHRhYmxlX25hbWUsCisgICAgICAgICAgICAgICAgIGN1c3RvbV9jb2x1
bW5fc3FsPU5vbmUpOgogICAgICIiIgogICAgIFRoaXMgZnVuY3Rpb24gY3JlYXRlcyBhIHRhYmxl
IHVuZGVyIHByb3ZpZGVkIHNjaGVtYS4KICAgICA6cGFyYW0gc2VydmVyOiBzZXJ2ZXIgZGV0YWls
cwpAQCAtMzksOSArNDAsMTMgQEAgZGVmIGNyZWF0ZV90YWJsZShzZXJ2ZXIsIGRiX25hbWUsIHNj
aGVtYV9uYW1lLCB0YWJsZV9uYW1lKToKICAgICAgICAgb2xkX2lzb2xhdGlvbl9sZXZlbCA9IGNv
bm5lY3Rpb24uaXNvbGF0aW9uX2xldmVsCiAgICAgICAgIGNvbm5lY3Rpb24uc2V0X2lzb2xhdGlv
bl9sZXZlbCgwKQogICAgICAgICBwZ19jdXJzb3IgPSBjb25uZWN0aW9uLmN1cnNvcigpCi0gICAg
ICAgIHF1ZXJ5ID0gIkNSRUFURSBUQUJMRSAlcy4lcyhpZCBzZXJpYWwgVU5JUVVFIE5PVCBOVUxM
LCBuYW1lIHRleHQsIiBcCi0gICAgICAgICAgICAgICAgIiBsb2NhdGlvbiB0ZXh0KSIgJVwKLSAg
ICAgICAgICAgICAgICAoc2NoZW1hX25hbWUsIHRhYmxlX25hbWUpCisgICAgICAgIGlmIGN1c3Rv
bV9jb2x1bW5fc3FsOgorICAgICAgICAgICAgcXVlcnkgPSAiQ1JFQVRFIFRBQkxFICVzLiVzKCVz
KSIgJSBcCisgICAgICAgICAgICAgICAgICAgIChzY2hlbWFfbmFtZSwgdGFibGVfbmFtZSwgY3Vz
dG9tX2NvbHVtbl9zcWwpCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBxdWVyeSA9ICJDUkVB
VEUgVEFCTEUgJXMuJXMoaWQgc2VyaWFsIFVOSVFVRSBOT1QgTlVMTCwgIiBcCisgICAgICAgICAg
ICAgICAgICAgICJuYW1lIHRleHQsIGxvY2F0aW9uIHRleHQpIiAlIFwKKyAgICAgICAgICAgICAg
ICAgICAgKHNjaGVtYV9uYW1lLCB0YWJsZV9uYW1lKQogICAgICAgICBwZ19jdXJzb3IuZXhlY3V0
ZShxdWVyeSkKICAgICAgICAgY29ubmVjdGlvbi5zZXRfaXNvbGF0aW9uX2xldmVsKG9sZF9pc29s
YXRpb25fbGV2ZWwpCiAgICAgICAgIGNvbm5lY3Rpb24uY29tbWl0KCkKZGlmZiAtLWdpdCBhL3dl
Yi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFz
L3RhYmxlcy91dGlscy5weSBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2
ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3RhYmxlcy91dGlscy5weQppbmRleCA0NTQwM2QxLi5iNDYw
MmI0IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVy
cy9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvdXRpbHMucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJv
d3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdGFibGVzL3V0aWxz
LnB5CkBAIC0xNzc5LDggKzE3NzksOCBAQCBjbGFzcyBCYXNlVGFibGVWaWV3KFBHQ2hpbGROb2Rl
Vmlldyk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICApIG9yIG1hdGNoT2Jq
Lmdyb3VwKDEpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjWydhdHRwcmVj
aXNpb24nXSA9IE5vbmUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbHNlOgotICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICBjWydhdHRsZW4nXSA9IE5vbmUKLSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgY1snYXR0cHJlY2lzaW9uJ10gPSBOb25lCisgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICMgVXNlIHRoZSBvbGQgdmFsdWVzIHRvIGF2b2lkIHVubmVj
ZXNzYXJ5CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNlbGYuYXNzaWduX29sZF9s
ZW5ndGhfcHJlY2lzaW9uKGMsIG9sZF9kYXRhKQogCiAgICAgICAgICAgICAgICAgICAgICAgICBp
ZiAnY2x0eXBlJyBpbiBjOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHR5cGVuYW1lID0g
Y1snY2x0eXBlJ10KZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw
cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3V0aWxzLnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nl
ci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdXRpbHMucHkKaW5kZXgg
ZGRlYmQ1ZS4uZTFiNTBhZCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJf
Z3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdXRpbHMucHkKKysrIGIvd2ViL3BnYWRt
aW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvdXRpbHMu
cHkKQEAgLTMyMCw2ICszMjAsMjUgQEAgY2xhc3MgRGF0YVR5cGVSZWFkZXI6CiAKICAgICAgICAg
cmV0dXJuIHR5cGVfbmFtZQogCisgICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIGFzc2lnbl9vbGRf
bGVuZ3RoX3ByZWNpc2lvbihjbHMsIGRhdGEsIG9sZF9kYXRhKToKKyAgICAgICAgIiIiCisgICAg
ICAgIEFzc2lnbiB0aGUgb2xkIHZhbHVlcyB0byBuZXcgd2hpY2ggd2lsbCBhdm9pZCB1bm5lY2Vz
c2FyeQorICAgICAgICBzcWwgZ2VuZXJhdGlvbgorCisgICAgICAgIEFyZ3M6CisgICAgICAgICAg
ICBkYXRhOiBOZXcgdmFsdWVzCisgICAgICAgICAgICBvbGRfZGF0YTogT2xkIHZhbHVlcworICAg
ICAgICAiIiIKKyAgICAgICAgaWYgJ2F0dGxlbicgaW4gb2xkX2RhdGE6CisgICAgICAgICAgICBp
ZiBvbGRfZGF0YVsnYXR0bGVuJ10gIT0gJy0xJzoKKyAgICAgICAgICAgICAgICBkYXRhWydhdHRs
ZW4nXSA9ICBvbGRfZGF0YS5nZXQoJ2F0dGxlbicsIE5vbmUpCisgICAgICAgICAgICBpZiAnYXR0
cHJlY2lzaW9uJyBpbiBvbGRfZGF0YToKKyAgICAgICAgICAgICAgICBpZiBvbGRfZGF0YVsnYXR0
cHJlY2lzaW9uJ10gIT0gJy0xJzoKKyAgICAgICAgICAgICAgICAgICAgZGF0YVsnYXR0cHJlY2lz
aW9uJ10gPSBvbGRfZGF0YS5nZXQoCisgICAgICAgICAgICAgICAgICAgICAgICAnYXR0cHJlY2lz
aW9uJywgTm9uZQorICAgICAgICAgICAgICAgICAgICApCisKIAogZGVmIHRyaWdnZXJfZGVmaW5p
dGlvbihkYXRhKToKICAgICAiIiIK
--001a114790ea9520f30566d3d07d--