Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brlJZ-0005s2-NB for pgadmin-hackers@arkaria.postgresql.org; Wed, 05 Oct 2016 12:28:49 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1brlJZ-0002JB-3V for pgadmin-hackers@arkaria.postgresql.org; Wed, 05 Oct 2016 12:28:49 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1brlJL-0001oW-8I for pgadmin-hackers@postgresql.org; Wed, 05 Oct 2016 12:28:35 +0000 Received: from mail-qt0-x233.google.com ([2607:f8b0:400d:c0d::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1brlJI-0006Wj-Ca for pgadmin-hackers@postgresql.org; Wed, 05 Oct 2016 12:28:34 +0000 Received: by mail-qt0-x233.google.com with SMTP id m5so49993801qtb.3 for ; Wed, 05 Oct 2016 05:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G9ADxf5ZWv0g3Omsp1GQKRK4HF5IezlnVQC8rRmNFQ8=; b=Hn4HJCmSK8d1jjvpZKOHqKF6c6oDBCQUan4pTJjBEXubqO/TDnN+fifglPWo1iCoJA yHX9u2VksLK4cja4PB/yVsQyaFo4q39QfFeqq1EEG/J/ZvZV1CFHSlm3aDIWiMoN+qeK 68vka2FX/n3XBX3LniNUZyvQzoHpDfn9aqhuEfK0gJPY4xmB7zKCbkpa5LSlT+DA5sCM Wbbk5sdRh1Wn+65mRcAEE3r/g99hMDWdRcMEG33bYu+DWAIWx2wEUoWns8AJjuNgAwI4 KAeMjwEu1Vs2HZmeCk7ikq6vzXpFUuYUzKY8BYSg1kBk5SHrLNF41m1Xtl0roa4LFv6/ 2xIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G9ADxf5ZWv0g3Omsp1GQKRK4HF5IezlnVQC8rRmNFQ8=; b=f+lVnHOwITjxOZsOw0ZX8rDx/4I8vgTFdrRfS7Ewl6YNI0sf5uMRmeC0uV1Uhy451D uEKVA4LidYNASnilCrcWTlxrz3E4CF4csT5zLVQ3zFNjYz2x4eUQSpQU5j9EA7wJo4rq 5dSvfy5O/M2GwkTDDvQOugXE50mmR7rGn7t5kWLTqyGQsTVO88Iq2qlnkQXAhXtZbwK+ aWOhe408qzH1OywNR0QryH0j/htGG9epb6jb74j7/tQBxwmImpMSWcz9urxsz1M98kM3 PN+KeTI4lZXHgjldQnUeWDNUP9HdjOrWmdZ3hv/3GhpdALuly5UcLjboumFbUCJPoVYW btAQ== X-Gm-Message-State: AA6/9Rkeaav1qnhxOuN5ROfn5pmwH4aRm6lWNmDRHPJuQlEGnfvDVf5JhhAsE1Zmexkzj/Wt0WLnqjTkbIJfuIXv X-Received: by 10.237.34.122 with SMTP id o55mr9056189qtc.15.1475670511554; Wed, 05 Oct 2016 05:28:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.118.196 with HTTP; Wed, 5 Oct 2016 05:28:11 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Wed, 5 Oct 2016 17:58:11 +0530 Message-ID: Subject: Re: PATCH: To fix issue in synonym node (pgAdmin4) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114684aea698b5053e1d50d5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114684aea698b5053e1d50d5 Content-Type: multipart/alternative; boundary=001a114684aea698b1053e1d50d3 --001a114684aea698b1053e1d50d3 Content-Type: text/plain; charset=UTF-8 Hi Dave, PFA updated patch, Added schema filter in sql. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Oct 5, 2016 at 5:38 PM, Dave Page wrote: > Hi > > On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to fix the issue in synonym node, where it was not horning > parent > > node while creating in different node, issue was that we were not sending > > node properly. > > RM#1611 > > That doesn't seem like a reliable way to get the correct parent ID - > what if there are multiple synonyms in different schemas but with the > same name? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114684aea698b1053e1d50d3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

PFA updated patch, Added schem= a filter in sql.
Please review.

--
<= font color=3D"#888888">Murtuza Zabuawala
EnterpriseDB:=C2=A0<= a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer" style=3D"color:r= gb(17,85,204)" target=3D"_blank">http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company

On Wed, Oct 5, 2016 at 5:38 PM, Dave Page <= dpage@pgadmin.org> wrote:
H= i

On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala
<murtuza.zabuawala= @enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in synonym node, where it was not horning p= arent
> node while creating in different node, issue was that we were not send= ing
> node properly.
> RM#1611

That doesn't seem like a reliable way to get the correct parent ID -
what if there are multiple synonyms in different schemas but with the
same name?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114684aea698b1053e1d50d3-- --001a114684aea698b5053e1d50d5 Content-Type: application/octet-stream; name="RM_1611_v1.patch" Content-Disposition: attachment; filename="RM_1611_v1.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itww3obe0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3N5bm9ueW1zL19faW5pdF9f LnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZl cnMvZGF0YWJhc2VzL3NjaGVtYXMvc3lub255bXMvX19pbml0X18ucHkKaW5k ZXggOTVlNThiNi4uOTdkZjVmNSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt YXMvc3lub255bXMvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJv d3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMv c3lub255bXMvX19pbml0X18ucHkKQEAgLTM5MSwxMCArMzkxLDE4IEBAIGNs YXNzIFN5bm9ueW1WaWV3KFBHQ2hpbGROb2RlVmlldyk6CiAgICAgICAgICAg ICBpZiBub3Qgc3RhdHVzOgogICAgICAgICAgICAgICAgIHJldHVybiBpbnRl cm5hbF9zZXJ2ZXJfZXJyb3IoZXJyb3Jtc2c9cmVzKQogCisgICAgICAgICAg ICAjIEZpbmQgcGFyZW50IG9pZCB0byBhZGQgcHJvcGVybHkgaW4gdHJlZSBi cm93c2VyCisgICAgICAgICAgICBTUUwgPSByZW5kZXJfdGVtcGxhdGUoIi8i LmpvaW4oW3NlbGYudGVtcGxhdGVfcGF0aCwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2dldF9wYXJlbnRfb2lkLnNx bCddKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRh PWRhdGEsIGNvbm49c2VsZi5jb25uKQorICAgICAgICAgICAgc3RhdHVzLCBw YXJlbnRfaWQgPSBzZWxmLmNvbm4uZXhlY3V0ZV9zY2FsYXIoU1FMKQorICAg ICAgICAgICAgaWYgbm90IHN0YXR1czoKKyAgICAgICAgICAgICAgICByZXR1 cm4gaW50ZXJuYWxfc2VydmVyX2Vycm9yKGVycm9ybXNnPXJlcykKKwogICAg ICAgICAgICAgcmV0dXJuIGpzb25pZnkoCiAgICAgICAgICAgICAgICAgbm9k ZT1zZWxmLmJsdWVwcmludC5nZW5lcmF0ZV9icm93c2VyX25vZGUoCiAgICAg ICAgICAgICAgICAgICAgIGRhdGFbJ25hbWUnXSwKLSAgICAgICAgICAgICAg ICAgICAgc2NpZCwKKyAgICAgICAgICAgICAgICAgICAgaW50KHBhcmVudF9p ZCksCiAgICAgICAgICAgICAgICAgICAgIGRhdGFbJ25hbWUnXSwKICAgICAg ICAgICAgICAgICAgICAgaWNvbj0iaWNvbi1zeW5vbnltIgogICAgICAgICAg ICAgICAgICkKQEAgLTQ4MywyNSArNDkxLDE0IEBAIGNsYXNzIFN5bm9ueW1W aWV3KFBHQ2hpbGROb2RlVmlldyk6CiAgICAgICAgICAgICAgICAgaWYgbm90 IHN0YXR1czoKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGludGVybmFs X3NlcnZlcl9lcnJvcihlcnJvcm1zZz1yZXMpCiAKLSAgICAgICAgICAgICAg ICByZXR1cm4gbWFrZV9qc29uX3Jlc3BvbnNlKAotICAgICAgICAgICAgICAg ICAgICBzdWNjZXNzPTEsCi0gICAgICAgICAgICAgICAgICAgIGluZm89IlN5 bm9ueW0gdXBkYXRlZCIsCi0gICAgICAgICAgICAgICAgICAgIGRhdGE9ewot ICAgICAgICAgICAgICAgICAgICAgICAgJ2lkJzogc3lpZCwKLSAgICAgICAg ICAgICAgICAgICAgICAgICdzY2lkJzogc2NpZCwKLSAgICAgICAgICAgICAg ICAgICAgICAgICdkaWQnOiBkaWQKLSAgICAgICAgICAgICAgICAgICAgfQot ICAgICAgICAgICAgICAgICkKLSAgICAgICAgICAgIGVsc2U6Ci0gICAgICAg ICAgICAgICAgcmV0dXJuIG1ha2VfanNvbl9yZXNwb25zZSgKLSAgICAgICAg ICAgICAgICAgICAgc3VjY2Vzcz0xLAotICAgICAgICAgICAgICAgICAgICBp bmZvPSJOb3RoaW5nIHRvIHVwZGF0ZSIsCi0gICAgICAgICAgICAgICAgICAg IGRhdGE9ewotICAgICAgICAgICAgICAgICAgICAgICAgJ2lkJzogc3lpZCwK LSAgICAgICAgICAgICAgICAgICAgICAgICdzY2lkJzogc2NpZCwKLSAgICAg ICAgICAgICAgICAgICAgICAgICdkaWQnOiBkaWQKLSAgICAgICAgICAgICAg ICAgICAgfQorICAgICAgICAgICAgcmV0dXJuIGpzb25pZnkoCisgICAgICAg ICAgICAgICAgbm9kZT1zZWxmLmJsdWVwcmludC5nZW5lcmF0ZV9icm93c2Vy X25vZGUoCisgICAgICAgICAgICAgICAgICAgIHN5aWQsCisgICAgICAgICAg ICAgICAgICAgIHNjaWQsCisgICAgICAgICAgICAgICAgICAgIHN5aWQsCisg ICAgICAgICAgICAgICAgICAgIGljb249Imljb24tc3lub255bSIKICAgICAg ICAgICAgICAgICApCisgICAgICAgICAgICApCiAKICAgICAgICAgZXhjZXB0 IEV4Y2VwdGlvbiBhcyBlOgogICAgICAgICAgICAgcmV0dXJuIGludGVybmFs X3NlcnZlcl9lcnJvcihlcnJvcm1zZz1zdHIoZSkpCmRpZmYgLS1naXQgYS93 ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRh YmFzZXMvc2NoZW1hcy9zeW5vbnltcy90ZW1wbGF0ZXMvc3lub255bS9zcWwv OS4xX3BsdXMvZ2V0X3BhcmVudF9vaWQuc3FsIGIvd2ViL3BnYWRtaW4vYnJv d3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMv c3lub255bXMvdGVtcGxhdGVzL3N5bm9ueW0vc3FsLzkuMV9wbHVzL2dldF9w YXJlbnRfb2lkLnNxbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi4wOGYwN2UwCi0tLSAvZGV2L251bGwKKysrIGIvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVt YXMvc3lub255bXMvdGVtcGxhdGVzL3N5bm9ueW0vc3FsLzkuMV9wbHVzL2dl dF9wYXJlbnRfb2lkLnNxbApAQCAtMCwwICsxLDUgQEAKK1NFTEVDVCBzeW5u YW1lc3BhY2UgYXMgc2NpZAorICAgIEZST00gcGdfc3lub255bSBzCitXSEVS RSBzeW5uYW1lID0ge3sgZGF0YS5uYW1lfHF0TGl0ZXJhbCB9fQorQU5EIHN5 bm5hbWVzcGFjZSBJTgorICAgICggU0VMRUNUIG9pZCBGUk9NIHBnX25hbWVz cGFjZSBXSEVSRSBuc3BuYW1lID0ge3sgZGF0YS5zY2hlbWF8cXRMaXRlcmFs IH19ICk7ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0 IGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMv ZGF0YWJhc2VzL3NjaGVtYXMvc3lub255bXMvdGVtcGxhdGVzL3N5bm9ueW0v c3FsLzkuNV9wbHVzL2dldF9wYXJlbnRfb2lkLnNxbCBiL3dlYi9wZ2FkbWlu L2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hl bWFzL3N5bm9ueW1zL3RlbXBsYXRlcy9zeW5vbnltL3NxbC85LjVfcGx1cy9n ZXRfcGFyZW50X29pZC5zcWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uMDhmMDdlMAotLS0gL2Rldi9udWxsCisrKyBiL3dlYi9wZ2Fk bWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9z Y2hlbWFzL3N5bm9ueW1zL3RlbXBsYXRlcy9zeW5vbnltL3NxbC85LjVfcGx1 cy9nZXRfcGFyZW50X29pZC5zcWwKQEAgLTAsMCArMSw1IEBACitTRUxFQ1Qg c3lubmFtZXNwYWNlIGFzIHNjaWQKKyAgICBGUk9NIHBnX3N5bm9ueW0gcwor V0hFUkUgc3lubmFtZSA9IHt7IGRhdGEubmFtZXxxdExpdGVyYWwgfX0KK0FO RCBzeW5uYW1lc3BhY2UgSU4KKyAgICAoIFNFTEVDVCBvaWQgRlJPTSBwZ19u YW1lc3BhY2UgV0hFUkUgbnNwbmFtZSA9IHt7IGRhdGEuc2NoZW1hfHF0TGl0 ZXJhbCB9fSApOwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK --001a114684aea698b5053e1d50d5 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114684aea698b5053e1d50d5--