Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqdvh-0002E1-12 for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 12:00:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eqdvf-0002J9-3X for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Feb 2018 12:00:19 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqdve-0002Ih-N3 for pgadmin-hackers@lists.postgresql.org; Tue, 27 Feb 2018 12:00:18 +0000 Received: from mail-ot0-x236.google.com ([2607:f8b0:4003:c0f::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eqdvb-00020N-GE for pgadmin-hackers@postgresql.org; Tue, 27 Feb 2018 12:00:17 +0000 Received: by mail-ot0-x236.google.com with SMTP id t2so3527190otj.4 for ; Tue, 27 Feb 2018 04:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4uZpZ1QJLIrMbIRsz2+KTGnRYEQGojEy8tb+4bfaZws=; b=mvRLsAtfklSIM9Yrd/9l9BBpgSJqlboJlWiASIkcn/O+tibh9UHNjtxiF+nJUShDZn jNorAu0TDf775p1jaQGdaRA1WkV3cWzisoIiuLMncfRKClnJT1iK2qFlTvKZiLWjdDtY NLl17kjb3VpcZL88NQAMDtfyxbOkVbsPfUzKR9Wpd0B0Z2s3u6ax4Iq5FxbrsY6kmJyx OLXdEdeOrU0D91wukc1qhDmWAIrLfeAQfy49Tho45xns2o9/r8DDPCkW5UbYbncliRBC IEc/mX5BTMIuyJq5xzrLjfld6VjyPyoUvIgQM/TnTPbTO7i1D09RiJQaXz1kwqY6NeqT 1VVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4uZpZ1QJLIrMbIRsz2+KTGnRYEQGojEy8tb+4bfaZws=; b=FuywQlFNZT8p/HXN8CYKX3uC+NNZJoMV+WMSij3EQUogZ3apzUtgl6RTMrDxVUIkBI bHdv28BKWS2LoLV4cLzqoi0YTh0nKnJVQY3HfkvwqWAIHLtmwg/7RjYzM30hEJzFEqh0 z82SchPjUDtKI5i3lrHAx+h90/JijlPVXVU2RWLIGn7qHrUU+ad5ALxZeOI5m0I9q8to VD1kN5zWO5MBW1Kw4ZVijPiTPm7qIuvmvDYadY5HHaA5lAS0gioNNM36EPTouF2W68hi yc0HwtW8imDvlwgV6cd3mV4IPbbWHtuEMn1bVHFChTGE4/5G/9iDWgdIVyK0qlzYkjn3 o43g== X-Gm-Message-State: APf1xPD2OheR3UOGZ2lWnoToRDovPU79ymNGkrAEH6aZLWdbfwHhPwgS ML2fcrM+YgAEAI1zvmPuCv+Uf2M1SR/iTMqIqQSn7Q== X-Google-Smtp-Source: AG47ELsJfROdDUC0UnjccSalcxm0mORxBN6tZV/YuqBUwcpuBfB6iSC7YRYKrzXi/0Vqyu8YSTTAAniX0XUKVTXPPPg= X-Received: by 10.157.4.204 with SMTP id 70mr9671601otm.291.1519732813610; Tue, 27 Feb 2018 04:00:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Tue, 27 Feb 2018 03:59:53 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Tue, 27 Feb 2018 17:29:53 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c09a5dc8259c80566305e26" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c09a5dc8259c80566305e26 Content-Type: text/plain; charset="UTF-8" Hi Dave, Could you please send screenshot? -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 27, 2018 at 5:24 PM, Dave Page wrote: > Hi > > Still not quite right - see the attached screenshot which is the result of > simply viewing the properties of an existing job. Note that the start time > is shown in the grid but not the subnode control. > > Thanks. > > On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> As validation related patch was committed with RM#3148 [ Sorry about that >> I forgot to checkout :) ] >> PFA patch to fix the issues you mentioned, I have also removed extra >> error message from sub node collection control and made it optional via >> flag. >> >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA patch to fix the issue where user was not able to create pgAgent >>>> job from UI without entering End date in schedule section. >>>> >>> >>> Whilst this does resolve the validation issue, there are still a couple >>> of other related problems, as can be seen in the attached screenshots: >>> >>> - The Start date/time in the subnode control doesn't seem to be properly >>> synchronised with the value in the grid. >>> >>> - If you leave the End date/time blank (but maybe click into it first), >>> the grid will show "Invalid date". >>> >>> It's possible there are other oddities as well - please check carefully >>> for anything else. >>> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c09a5dc8259c80566305e26 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

Could = you please send screenshot?

--
Regards,
Murtuza Zab= uawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=

On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

Still not quite right - see the atta= ched screenshot which is the result of simply viewing the properties of an = existing job. Note that the start time is shown in the grid but not the sub= node control.

Thanks.

On Tue, Feb 27, 2018 at 8:26 AM, M= urtuza Zabuawala <murtuza.zabuawala@enterprisedb.com= > wrote:
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:r= gb(68,68,68)">Hi Dave,

As vali= dation related patch was committed with RM#3148 [ Sorry about that I forgot= to checkout :)=C2=A0]
PFA patch to fix the issues you = mentioned, I have also removed extra error message from sub node collection= control and made it optional via flag.



= --
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.ent= erprisedb.com
The Enterprise PostgreSQL Company


On Mon, Feb 26, 2018 at 10:14 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where user was not able to create = pgAgent job from UI without entering End date in schedule section.

=C2=A0Whilst this does resolve the vali= dation issue, there are still a couple of other related problems, as can be= seen in the attached screenshots:

- The Start dat= e/time in the subnode control doesn't seem to be properly synchronised = with the value in the grid.

- If you leave the End= date/time blank (but maybe click into it first), the grid will show "= Invalid date".

It'= s possible there are other oddities as well - please check carefully for an= ything else.

Thanks.=

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y




--
Dave Page
Bl= og: http://pgsnak= e.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= /a>
The Enterprise PostgreSQL Company
--94eb2c09a5dc8259c80566305e26--