Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0UkX-0003vg-7U for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 16:13:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0UkV-0001hO-C1 for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 16:13:31 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0UkV-0001gc-00 for pgadmin-hackers@lists.postgresql.org; Mon, 26 Mar 2018 16:13:31 +0000 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0UkQ-0002gd-EP for pgadmin-hackers@postgresql.org; Mon, 26 Mar 2018 16:13:29 +0000 Received: by mail-ot0-x242.google.com with SMTP id h8-v6so21216186oti.6 for ; Mon, 26 Mar 2018 09:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Um7tr9zW5L9a4DEs4+fodEhdFkoDXaN16T9rYXt7aKk=; b=iWTBfZeP+Z2SBTh8Bte15xB37s1vAMFcJ1H9vZK125BtdmQKg23Whe/hMlWK7tfzrS og6RcYVFdiDA0kAoCK6GgnOKuG1whyuyBAvVRTJGnLLfEcxuag8pZ4WmgqdO19jxF1W2 pwu2gAiUuIyHS0ukDFJf9E0tuImDZmURulTMWtluVY+u1a3e9ZjV9f+u7fGhCfL+PrEW nNJcQPiJRIZWnAM5MX5BrMST2FHLUQPZ2LTmpXA7OgRTeKv349pjwoIs8d28ZJx9hVNk CJJzaMBUiWpalKmPp6KuckyfL5HcexdI8MfGOLj+xe1oxnpS25IxMJ05bhEKY/0/SktI WGVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Um7tr9zW5L9a4DEs4+fodEhdFkoDXaN16T9rYXt7aKk=; b=KIaljZ17p7Ckas1N34hdMfZLthE0NbaaB95jypJMMl7d0R6QTdAxDTpYPrwTXxm1tU 538k00RjR9bewWbvqieRGdUPl5ghGo0o/TeqvyO1D+t8KJFXrVQFOOvFwUtVMEPaqKvx Mrp6RXAQ5z7L3LUDo+ZQas5Gq/UpkYrPQ6lAOo2kfB/Ue2N73E3JE0qhEXsPmalfIw3Y h8I97PAtNM9ux0L9c74mHDo/rs/w/irMOrIQi5XJUf/SmB1i6oMXoU6ST14LIjTkR2gy gu5CJ84Od/wkOcPYWXiUYAr5V6h7p5b3+ogAElB9iIfc681CJ3P4b05kSV2g3AWWU6Yf LN9Q== X-Gm-Message-State: AElRT7FWRmNYoJHCKdIfs+I+P9Gmz9EG+TvKAtD7UGO67iYXrWHKi68c 2X3PhcbNusclmJ3IDlFv53/69/Ct/r504ylAka2mTQ== X-Google-Smtp-Source: AG47ELukKl0cUhTfpgbRdfOZ1EG9gP+ZspitYpdb8vnmR6lQI/NkDSOEnU94of+gEOdFMRxc6F02cOK9Tez4ET1DzPw= X-Received: by 2002:a9d:700c:: with SMTP id k12-v6mr12660294otj.178.1522080805399; Mon, 26 Mar 2018 09:13:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.138.6.138 with HTTP; Mon, 26 Mar 2018 09:13:05 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 26 Mar 2018 21:43:05 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b9c39d0568530de4" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b9c39d0568530de4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 26, 2018 at 5:52 PM, Dave Page wrote: > Hi > > On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which allow user to sort the data in View data mode. >> > > The patch looks good in general, however I'm not sure about the UI, in > particular that the closely-linked dialogue for filtering is a completely > different design. I think it would be better to combine the Sort/Filter > options and use a single dialogue for both, as pgAdmin 3 did (though, may= be > not using separate tabs for each part, but the top and bottom of the same > dialogue. > > That would certainly fix the consistency of the dialogues (obviously, as > there would only be one!), and I think would perhaps be a more simple > overall UI, particularly for those that want to sort and filter. > =E2=80=8BSure, I'll send updated it accordingly.=E2=80=8B > > Thoughts? > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000b9c39d0568530de4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Mar 26, 2018 at 5:52 PM, Dave Page <dpage@pgadmin.org&g= t; = wrote:

The patch looks good in general, however I'm not sure about the UI, = in particular that the closely-linked dialogue for filtering is a completel= y different design. I think it would be better to combine the Sort/Filter o= ptions and use a single dialogue for both, as pgAdmin 3 did (though, maybe = not using separate tabs for each part, but the top and bottom of the same d= ialogue.


--000000000000b9c39d0568530de4--