Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEUDI-00006Q-Fo for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 Mar 2020 08:38:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEUDH-000894-9f for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 Mar 2020 08:38:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEUDG-00085d-Um for pgadmin-hackers@lists.postgresql.org; Wed, 18 Mar 2020 08:38:07 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEUDA-0003fX-14 for pgadmin-hackers@postgresql.org; Wed, 18 Mar 2020 08:38:05 +0000 Received: by mail-ot1-x341.google.com with SMTP id e19so3575194otj.7 for ; Wed, 18 Mar 2020 01:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lRuivgabf/hQ39UVwXJbhhQEO+8VqpIt9A/DKn3GEq0=; b=Hx5m+k3tDXxHOfnv72DccBgyOOe2zA/2+N3Z+mOcRg2UmEDDzzDH3+70OS5/0xfOwo p5nrjIGO3/dJO4feD4go3oYYBh1bbreE4gvovmpukMum3GjZ4inFmA+2bFMuWiwdhlJz jp3mNPx4C3RRcGC6o4lUHk2DlNgMxX5Dq7mJ575TuBITaRLZNWVQTIhJdcPj+0REoW2t Qfm/P0w2bTeGR/thOOmFeYFicZ7RGaXNDHQVMCPNcr1lq1zxZTPhC7Y3w6bjXqvHO1C5 l/hMKrDcbtuWzHEgZ0xM/07O8hKcP4m1KDWU4bm0JYN1CGMDEzEEGS1yw9phknMFLeOM Acrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lRuivgabf/hQ39UVwXJbhhQEO+8VqpIt9A/DKn3GEq0=; b=fT8UHM37kRDP39bg9o5FEowjdUiiTorDuyaAHjAr43RIPbkrdKP5NT725nDbUByLLx duycNubpGRbJjxGGvYHMZn7Af9MniAFpA4ODuNTs7hbXyrBIQID9GFu89RjPJ25kSDI6 /LKIsHW+HLczIUtN2xLkdXk/Pnn1DmyZ6q+LT3r8ku8qpoq4S0G7NK3T1TL2/7tqcrn1 XymwWJjAceNGuGAVCytprwIiHzk+YThQ6RssSVI5WZ2xwQFw1K1MImTjX3HoXyAxOluu ityuu3KzQE2GvUOomBW+8aDDpk7bi7zsgL83VVJnF836ymsTtIOzBNFltUye+L2CoHFQ imSg== X-Gm-Message-State: ANhLgQ3/LbOiro9/0ww9BW7V+pKAHPemWwNo9d/nY0emfFjhm8atY0CP hY17VpshpCRlQP+Pz3dBMeptypTabgRUUY8WDki78hzUAGMRglu3JbuTonTr+Eww4t6leZgk3n5 +uI7D5g2SN3AZUmcgQg4C0ncbPe5LT4YEEfWYwp9UHfsm1Cq8E1woKHe8uagqfjxNy4d4TeichS im2lEczuRMNsBeXakxfuwmJrX+5Wl974muaEe/MZOIeeWPVGlZV+OPW6Mo X-Google-Smtp-Source: ADFU+vtxxepb/1vMiaLH4hbpz/RREP+zGds8gCgZGe8TuhlEGV2Z+E4QLT1TEQHKiQn0lcovuht4QpZaKXqlI+gW2rs= X-Received: by 2002:a9d:30c7:: with SMTP id r7mr2775367otg.289.1584520678614; Wed, 18 Mar 2020 01:37:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Murtuza Zabuawala Date: Wed, 18 Mar 2020 14:07:42 +0530 Message-ID: Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000303d5e05a11cf834" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000303d5e05a11cf834 Content-Type: text/plain; charset="UTF-8" Hi Aditya, On Wed, Mar 18, 2020 at 1:52 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Murtuza, > > Why do we need to add new variable swith-ternary ? What was the issue you > were facing ? > Just to make both class names consistent, I missed to git add those changes in the patch in which I removed the ternary scss variable. > On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hello, >> >> As per discussion with Chethana, We need to make switch box color change >> for light and dark theme, Color details provided by Chethana is updated on >> ticket. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > --000000000000303d5e05a11cf834 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya= ,

On Wed, Mar 18, 2020 at 1:52 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com= > wrote:
Hi Murtuza,

Why d= o we need to add new variable swith-ternary=C2=A0? W= hat was the issue you were facing ?
=
Just to make both class=C2=A0names consistent, I= missed to git = add those changes in the patch in which I removed the ternary scss variable= .


On We= d, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <murtuza.zabuawala@enterprise= db.com> wrote:
Hello,

As per discussion with Chethana, We need to make switch box color change= for light and dark theme, Color details provided by Chethana is updated on= ticket.
=C2=A0

=
--
Regards,
Murtuza Zabuawala
Enterpri= seDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL = Company

=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=
--000000000000303d5e05a11cf834--