Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhcXT-0001MI-J4 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 13:05:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bhcXT-0007dg-5g for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Sep 2016 13:05:15 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bhcXS-0007dL-Mu for pgadmin-hackers@postgresql.org; Wed, 07 Sep 2016 13:05:14 +0000 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bhcXM-0004LQ-Hq for pgadmin-hackers@postgresql.org; Wed, 07 Sep 2016 13:05:13 +0000 Received: by mail-qk0-x230.google.com with SMTP id l2so13681970qkf.3 for ; Wed, 07 Sep 2016 06:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=E2g53HIZUQOYkT4gy3gwXXuE0N/27fAiqpLtiF3XQsM=; b=s+5lDlS2XJ3P3o/d2r+5tp25LjsmtPKn7ONxpeqvWGofLz+iVwd6Nc0tUc9Fa9IlY2 AIDtwpKZ948nO7S7HhuZUfU1ylYxv7sKDkJDebQO4X+2IzNFOB2fWx38XXrJUXVGhSWc 5K/c4CcyW+/DJYv9FUBFZAEElwriPF6zdB54Z3neSswTf1awvp4ZFze1NYoQsHjY/pXq 20Hl25vG6LOr+L4IQlorsXWAhOzqhMvVz00jgmOV7Rgu5stG0IUIktrIpVrJkzluSVrM LcaHJiHGU2alF+nTH7rpulD9Z0CMpknagDWTgJspjZZ3tvekQuaNhb9IhOcVsBmUJKD4 9FeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=E2g53HIZUQOYkT4gy3gwXXuE0N/27fAiqpLtiF3XQsM=; b=GFsznf8xb/dY3Swpe1WSUIWmzdK9mFK3g6goOTQNX7XP/h1MwiBmyewO+2EGVcYsaz 1Hnkwa2jaEeR66GHFULoYtW8UqxJMzoCaWiGnazHb9o0m5xIsFtThJwsISwVpbf8apFV S6nL5gVF1BcGMbSEyErdbBfvlPcBXyg+5vaNbbDovXIKw9yb2wd+cTP+rBZWjwAcdI6T 7kLiUwJe9kmDoDjSOjdZTqakq7uXGapSWOXulp8PAza5WXxlbbxuxbjfV4qxJCxuq5Ex FU6ErWS5DYMjrGu3OoMigIVg3xUUG3lJxBveWrAwZeeqmWwtZW7YNY1g8X1R676wm2Lt f5Vg== X-Gm-Message-State: AE9vXwOmNuNxiXupo4VsHRw7M6ebuBjVbPbwHxg3yfXw93cMKuEcCR6q9Rwej/pOP7eTPsSr4flP8MLQiQEu8pO5 X-Received: by 10.55.158.210 with SMTP id h201mr651600qke.41.1473253507608; Wed, 07 Sep 2016 06:05:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.129.194 with HTTP; Wed, 7 Sep 2016 06:04:47 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Wed, 7 Sep 2016 18:34:47 +0530 Message-ID: Subject: Re: PATCH: Adding more confirmations in query tool (pgAdmin4) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c065474fc5cee053bea8f1d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c065474fc5cee053bea8f1d Content-Type: text/plain; charset=UTF-8 Sure I'll do it, But I thought like let user traverse through file manager (he may or may not select any file to load) and warn only if he/she try to load file. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Sep 7, 2016 at 6:30 PM, Dave Page wrote: > Hi > > On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala > wrote: > > Hi, > > > > PFA patch to add more confirmations in query tool before taking any > actions > > which might cause lose changes, > > - Clearing editor > > - Clearing history > > - Load file data > > RM#1666 > > > > Please review. > > Can you tweak it so that the confirmation is requested as soon as the > open file button is clicked, rather than when a file is selected > please? I think that's a little more 'normal' :-). > > Thanks! > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c065474fc5cee053bea8f1d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sure I'll do it, But I thought like let user traverse = through file manager (he may or may not select any file to load) and warn o= nly if he/she try to load file.


<= font size=3D"2" face=3D"tahoma, sans-serif">--
R= egards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterpris= e PostgreSQL Company

On Wed, Sep 7, 2016 at 6:30 PM, Dave Page <= dpage@pgadmin.org> wrote:
H= i

On Wed, Sep 7, 2016 at 10:38 AM, Murtuza Zabuawala
<murtuza.zabuawala= @enterprisedb.com> wrote:
> Hi,
>
> PFA patch to add more confirmations in query tool before taking any ac= tions
> which might cause lose changes,
> - Clearing editor
> - Clearing history
> - Load file data
>=C2=A0 RM#1666
>
> Please review.

Can you tweak it so that the confirmation is requested as soon as the
open file button is clicked, rather than when a file is selected
please? I think that's a little more 'normal' :-).

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--94eb2c065474fc5cee053bea8f1d--