Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsTcA-0004CE-JZ for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 11:46:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bsTcA-0001Po-4y for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 11:46:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bsTYg-0000pV-7S for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 11:43:22 +0000 Received: from mail-qt0-x22a.google.com ([2607:f8b0:400d:c0d::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bsTYc-0005W5-65 for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 11:43:21 +0000 Received: by mail-qt0-x22a.google.com with SMTP id m5so19982244qtb.3 for ; Fri, 07 Oct 2016 04:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gooA/bADzl3APSvL2xyTRbJDntL6NVlyMEs3nXhSq7Q=; b=RsKDO/XiCX2tsqdxE5WRpQRd/ZhrjVruhiGOOtQuISVU8IR9tAyFckgVEmTAUIqPYP WAmq9iQFp05vmvQC+06aIXioEGiyQWYQA4Nhq9hDfg939TAQfV2wFFOtU1OxnWhKpvaO 3Ly/SWT6O9Z5gU3xXo7kF/Rsm/sZKJELMUlDU4SL3bOR7uqixIGnQdO1QQbCkXO0ZQDO +7WmsH8hefgOCqgSdXGwHOpfPsvAguxZsbtvnKDEdangESsbmnP3AHZ+/tnuTrZIYBRA /Bfha4VWN8poljYdlQwUuW9UZLMhPb6eslZYhO1BqxS4C7RUWAQDsWAxAlusx2kXV4xn 76vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gooA/bADzl3APSvL2xyTRbJDntL6NVlyMEs3nXhSq7Q=; b=k1Dmbvuvz0PWwCeOwHZTt3NRp7XEpUzeFxQ6ZXKMqqwL8NiUW5Mn4AOHWMpyIJWetd sF3B3SxGK+kWEgLS6zMTiyfuD+NCvFl5yQBnP6gKRrL+xylFVVZq8RMvgaO0/lwdu1Q4 OI+LnKrISNgQNoGCRNV0AzVIJ67bObj8MIsKKqADRhCBHx6630xGAWzC7htSuHRftKjl WxQCfrCcjA2MTg4QCBF5J1bmK2mvetPxGlywlykSo+zACOLmiu9PncS/rQOmOVeQoeVI OBVAUbzkqlvR92Q6EVzCzaXJkHDy/ac8iq52r2s+zVdH++LcL2DOBjXBQF3gQlLPVRnN 1iRQ== X-Gm-Message-State: AA6/9RmjJr2Y2ks48h76jvAr5+yQTuGSZcBax5NBW+Mvhhr1KsyvHg0Po3nDI+9BqVRpvHW9vAQwSwsGTmLw3xU+ X-Received: by 10.200.42.236 with SMTP id c41mr19552752qta.121.1475840596408; Fri, 07 Oct 2016 04:43:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.118.196 with HTTP; Fri, 7 Oct 2016 04:42:55 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Fri, 7 Oct 2016 17:12:55 +0530 Message-ID: Subject: Re: PATCH: To fix the issue in Debugger module (pgAdmin4) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11406abc7e8f0f053e44ea75 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11406abc7e8f0f053e44ea75 Content-Type: text/plain; charset=UTF-8 Hi Dave, I faced the same issue when I initially tried that, but then as per Neel suggestion I changed SELECT pg_sleep() to PERFORM pg_sleep() in function. You will face the same in pgAdmin3 if you use select pg_sleep() in your function the debug call never returns from DB server. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Oct 7, 2016 at 4:16 PM, Dave Page wrote: > Hi > > It still seems buggy. I started debugging list_emp() from our sample > DB, and just hit Step Into a few times randomly. It got as far as the > pg_sleep call I added, then never returned so I couldn't proceed. See > attached screenshot. > > > On Thu, Oct 6, 2016 at 10:05 AM, Murtuza Zabuawala > wrote: > > Hi Dave, > > > > PFA updated patch with suggestion given. > > > > -- > > Regards, > > Murtuza Zabuawala > > EnterpriseDB: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > On Wed, Oct 5, 2016 at 7:29 PM, Dave Page wrote: > >> > >> OK, that's much better. I think I've figured out what's causing the > >> remaining execution error as well - we're not disabling the buttons > >> until we get a response from the server, so if you click too quickly, > >> you make multiple requests at once. I tested this by adding a "SELECT > >> pg_sleep(2);" to a loop in a function. > >> > >> If you can fix that as well, then I think we can call this issue fixed. > >> > >> Thanks! > >> > >> On Wed, Oct 5, 2016 at 1:09 PM, Murtuza Zabuawala > >> wrote: > >> > Hi Dave, > >> > > >> > PFA updated patch for the same. > >> > RM#1227 > >> > > >> > Please review. > >> > > >> > > >> > -- > >> > Regards, > >> > Murtuza Zabuawala > >> > EnterpriseDB: http://www.enterprisedb.com > >> > The Enterprise PostgreSQL Company > >> > > >> > On Mon, Oct 3, 2016 at 6:05 PM, Dave Page wrote: > >> >> > >> >> Hi > >> >> > >> >> On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala > >> >> wrote: > >> >> > Hi Dave, > >> >> > > >> >> > PFA updated patch to fix mentioned issue as well as incremental > msgs > >> >> > updates > >> >> > in Messages Tab. > >> >> > >> >> This doesn't seem to work well. In pgAdmin 4 I get the following: > >> >> > >> >> ==== > >> >> SELECT 1 > >> >> INFO: EMPNO ENAME > >> >> > >> >> > >> >> INFO: ----- ------- > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7369 SMITH > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7499 ALLEN > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7521 WARD > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7566 JONES > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7654 MARTIN > >> >> > >> >> > >> >> SELECT 1 > >> >> INFO: 7698 BLAKE > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7782 CLARK > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7788 SCOTT > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7839 KING > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7844 TURNER > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7876 ADAMS > >> >> > >> >> > >> >> SELECT 1 > >> >> INFO: 7900 JAMES > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7902 FORD > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> SELECT 1 > >> >> INFO: 7934 MILLER > >> >> > >> >> > >> >> SELECT 1 > >> >> SELECT 1 > >> >> SELECT 1 > >> >> SELECT 1 > >> >> ==== > >> >> > >> >> Whilst in pgAdmin III I get: > >> >> > >> >> ==== > >> >> INFO: EMPNO ENAME > >> >> INFO: ----- ------- > >> >> INFO: 7369 SMITH > >> >> INFO: 7499 ALLEN > >> >> INFO: 7521 WARD > >> >> INFO: 7566 JONES > >> >> INFO: 7654 MARTIN > >> >> INFO: 7698 BLAKE > >> >> INFO: 7782 CLARK > >> >> INFO: 7788 SCOTT > >> >> INFO: 7839 KING > >> >> INFO: 7844 TURNER > >> >> INFO: 7876 ADAMS > >> >> INFO: 7900 JAMES > >> >> INFO: 7902 FORD > >> >> INFO: 7934 MILLER > >> >> SELECT 1 > >> >> ==== > >> >> > >> >> Sidenote: pgAdmin III uses a fixed-width font for this output which > >> >> works far better than pgAdmin 4's variable width font. > >> >> > >> >> -- > >> >> Dave Page > >> >> Blog: http://pgsnake.blogspot.com > >> >> Twitter: @pgsnake > >> >> > >> >> EnterpriseDB UK: http://www.enterprisedb.com > >> >> The Enterprise PostgreSQL Company > >> > > >> > > >> > >> > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11406abc7e8f0f053e44ea75 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

I faced = the same issue when I initially tried that, but then as per Neel suggestion= I changed SELECT pg_sleep() to PERFORM pg_sleep() in function.
You will= face the same in pgAdmin3 if you use select pg_sleep() in your function th= e debug call never returns from DB server.



--
Regards,Murtu= za Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
=

On Fri, Oct 7, 2016 at 4:16 PM, Dave Page <= dpage@pgadmin.org> wrote:
H= i

It still seems buggy. I started debugging list_emp() from our sample
DB, and just hit Step Into a few times randomly. It got as far as the
pg_sleep call I added, then never returned so I couldn't proceed. See attached screenshot.


On Thu, Oct 6, 2016 at 10:05 AM, Murtuza Zabuawala
<murtuza.zabuawala= @enterprisedb.com> wrote:
> Hi Dave,
>
> PFA updated patch with suggestion given.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Oct 5, 2016 at 7:29 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> OK, that's much better. I think I've figured out what'= s causing the
>> remaining execution error as well - we're not disabling the bu= ttons
>> until we get a response from the server, so if you click too quick= ly,
>> you make multiple requests at once. I tested this by adding a &quo= t;SELECT
>> pg_sleep(2);" to a loop in a function.
>>
>> If you can fix that as well, then I think we can call this issue f= ixed.
>>
>> Thanks!
>>
>> On Wed, Oct 5, 2016 at 1:09 PM, Murtuza Zabuawala
>> <murtuza.= zabuawala@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > PFA updated patch for the same.
>> > RM#1227
>> >
>> > Please review.
>> >
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Mon, Oct 3, 2016 at 6:05 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala
>> >> <murtuza.zabuawala@enterprisedb.com> wrote:
>> >> > Hi Dave,
>> >> >
>> >> > PFA updated patch to fix mentioned issue as well as = incremental msgs
>> >> > updates
>> >> > in Messages Tab.
>> >>
>> >> This doesn't seem to work well. In pgAdmin 4 I get th= e following:
>> >>
>> >> =3D=3D=3D=3D
>> >> SELECT 1
>> >> INFO: EMPNO ENAME
>> >>
>> >>
>> >> INFO: ----- -------
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7369 SMITH
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7499 ALLEN
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7521 WARD
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7566 JONES
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7654 MARTIN
>> >>
>> >>
>> >> SELECT 1
>> >> INFO: 7698 BLAKE
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7782 CLARK
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7788 SCOTT
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7839 KING
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7844 TURNER
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7876 ADAMS
>> >>
>> >>
>> >> SELECT 1
>> >> INFO: 7900 JAMES
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7902 FORD
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> INFO: 7934 MILLER
>> >>
>> >>
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> SELECT 1
>> >> =3D=3D=3D=3D
>> >>
>> >> Whilst in pgAdmin III I get:
>> >>
>> >> =3D=3D=3D=3D
>> >> INFO:=C2=A0 EMPNO=C2=A0 =C2=A0 ENAME
>> >> INFO:=C2=A0 -----=C2=A0 =C2=A0 -------
>> >> INFO:=C2=A0 7369=C2=A0 =C2=A0 =C2=A0SMITH
>> >> INFO:=C2=A0 7499=C2=A0 =C2=A0 =C2=A0ALLEN
>> >> INFO:=C2=A0 7521=C2=A0 =C2=A0 =C2=A0WARD
>> >> INFO:=C2=A0 7566=C2=A0 =C2=A0 =C2=A0JONES
>> >> INFO:=C2=A0 7654=C2=A0 =C2=A0 =C2=A0MARTIN
>> >> INFO:=C2=A0 7698=C2=A0 =C2=A0 =C2=A0BLAKE
>> >> INFO:=C2=A0 7782=C2=A0 =C2=A0 =C2=A0CLARK
>> >> INFO:=C2=A0 7788=C2=A0 =C2=A0 =C2=A0SCOTT
>> >> INFO:=C2=A0 7839=C2=A0 =C2=A0 =C2=A0KING
>> >> INFO:=C2=A0 7844=C2=A0 =C2=A0 =C2=A0TURNER
>> >> INFO:=C2=A0 7876=C2=A0 =C2=A0 =C2=A0ADAMS
>> >> INFO:=C2=A0 7900=C2=A0 =C2=A0 =C2=A0JAMES
>> >> INFO:=C2=A0 7902=C2=A0 =C2=A0 =C2=A0FORD
>> >> INFO:=C2=A0 7934=C2=A0 =C2=A0 =C2=A0MILLER
>> >> SELECT 1
>> >> =3D=3D=3D=3D
>> >>
>> >> Sidenote: pgAdmin III uses a fixed-width font for this ou= tput which
>> >> works far better than pgAdmin 4's variable width font= .
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11406abc7e8f0f053e44ea75--