public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: Максим Кольцов <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] Remake Docker container packaging
Date: Mon, 2 Apr 2018 10:24:36 +0530
Message-ID: <CAKKotZSskdx7PXnpjH2TArqVYNxeurrURvfkWuVAm6ruP359AA@mail.gmail.com> (raw)
In-Reply-To: <CAB_Kkxwp6rsiWEW4vJm_02zcckbvpb+x74NhF5HqfTLVCdVzpQ@mail.gmail.com>
References: <CAB_Kkxwp6rsiWEW4vJm_02zcckbvpb+x74NhF5HqfTLVCdVzpQ@mail.gmail.com>

Hello,

I tested the patch and it is working fine.

- I had clean system before but after running DockerBuild, I can see 3
different images of pgAdmin4, Is this expected?


- We can remove /tests/ folder from each folders, we can also remove
/web/regression/ folder from the container, they are used to run tests.
We don't require them on production code.

- Can we make the ports configurable?
https://redmine.postgresql.org/issues/2997

- Allow user to choose whether to run it as Single user mode(SERVER_MODE =
False) or Multiuser mode(SERVER_MODE = True)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Sat, Mar 31, 2018 at 11:19 PM, Максим Кольцов <[email protected]> wrote:

> Hi all,
>
> I've been discussing this with Dave for about a month now. Today I
> finally present a proposed patch to update pgadmin4's Docker
> packaging.
>
> Key features of this update:
> - Main image is based on python:3.6-alpine3.7.
>   Using Alpine linux leads to much smaller image
> - All build is done with Docker multi-stage build. First of all build
> the frontend in node:6 image,
>   then build Sphinx documentation in separate Python container and in
> the end just install all
>   dependencies in a clean python:3.6-alpine3.7 image, so that it does
> not have any leftovers from the build
>   process and we don't rely on any tools available on the host.
> - Use Gunicorn (http://gunicorn.org) as lightweight HTTP / WSGI server.
>   Gunicorn supports both HTTP and HTTPS.
> - Install Alpine postgresql-client package, which includes pg_dump and
> other tools and config
>   PgAdmin to find these tools by default
> - Byte-compile all PgAdmin Python code in Dockerfile with optimization
> (-O) enabled. This way Python
>    does not have to compile modules on each container restart and
> consume space in overlay fs
>
> Please find attached patch from "git format-patch".
>


Attachments:

  [image/png] image.png (97.4K, 3-image.png)
  download | view image

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch] Remake Docker container packaging
  In-Reply-To: <CAKKotZSskdx7PXnpjH2TArqVYNxeurrURvfkWuVAm6ruP359AA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox