Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1euKQs-0001Fq-SO for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Mar 2018 15:59:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1euKQr-00013R-LO for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Mar 2018 15:59:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1euKQr-00013H-Cl for pgadmin-hackers@lists.postgresql.org; Fri, 09 Mar 2018 15:59:45 +0000 Received: from mail-ot0-x22f.google.com ([2607:f8b0:4003:c0f::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1euKQm-00083r-SN for pgadmin-hackers@postgresql.org; Fri, 09 Mar 2018 15:59:44 +0000 Received: by mail-ot0-x22f.google.com with SMTP id m22so9086387otf.10 for ; Fri, 09 Mar 2018 07:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uiLuMn3ZhI9zcvQ6Oll+AA1kAfMuegzWi6EToBw36e4=; b=XlhKnsClLF3r5TB7zoz6ob8LsZMNo9acofB+QSn2zFHCnbQtTOGpryCspVBY0MXBh1 WYM9HTg3M+bkcEc65BcIcuQWzmRPdRe6gaGJvBfT9r7R0b5et0tXNHwqc6zw+xnMXFG7 bHpBoaooAPw8jc/Zc0YQfheszYOBBIsQdDmBiJ9DS82jgAXGW4nISEqEYDjG3CxEqT1s Drx0vSMIKMfr7R1I8Q1kLq6GBM/b1J4KYioQ67pDW6Myyv/8d+DJY7W0VibymENwRBqD uMHwZwlsxTEkkVWOZKsBduHTeGcEjs8MxPgcWu/Yh3r9F1mzL5bAiR2ktstitdPv85hm D+bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uiLuMn3ZhI9zcvQ6Oll+AA1kAfMuegzWi6EToBw36e4=; b=bi1SfSzR6c/f3FHC0zpQVDDtN/pqc54udy9iB1UUw2vdTCu92Jcwg4OIw/NBKd1acG qoG/BOhc6SgGMwlfpi8eVf9h6r1QdWFxe/hMNVs17PFqWuwgGSuXh6F/5XXkpUNHorfK AZFwa80XY7uUWQDVsbi6ECU2J8APa+vBBM+mEiquah/0tx4R3N6bru4NeWGJeYMr9ImH hP4aXvylisnERQyoEuYBpimtVXqmWhTVL2Q1JhFNslIwqeJQ07x9W18bXpZReEHN72NZ SwwPvScvOWISQpp9n5YJKMpaChV9OGg6FIhFeiGgjwqOy58tZ5FxKISVKvXzAmTFsmCu 3jVw== X-Gm-Message-State: APf1xPDsqB4weRo53q2F+wE6vUBMEj/RiONS8RAU0LGT/0SYxs2HZ/db TQ9zAf/BMRSHrrmYon0UqZaMJjsRojJmN2Xtqouj/A== X-Google-Smtp-Source: AG47ELt8W2VIy3QmtiFXATdlOE6w+ZC+yTaKwmhniOPymC98G3/KsGRnU4vA4klw6/3C5dY2BohRfw1bX4CTS/ELXy0= X-Received: by 10.157.80.34 with SMTP id a34mr20227138oth.79.1520611178483; Fri, 09 Mar 2018 07:59:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Fri, 9 Mar 2018 07:59:18 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Fri, 9 Mar 2018 21:29:18 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3140] Add service parameter To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f4030435abd022a8dc0566fce1d0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f4030435abd022a8dc0566fce1d0 Content-Type: text/plain; charset="UTF-8" Hi Dave, I'll change the name and send you updated patch. On Fri, Mar 9, 2018 at 9:25 PM, Dave Page wrote: > HI > > On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to add service parameter in server dialog. >> - Docs updated >> - Test case added for Service ID parameter >> >> Please note, >> I have extracted Connection class and Server manager class from our own >> custom Psycopg2 driver module. >> >> Patch also covers RM#3120 >> > > This patch seems a little confused. The "Service" and "Service ID" fields > from pgAdmin 3 are very different things. The Redmine ticket seems to be > asking for the Service field (the pg_service.conf service name), *not* > Service ID (the operating system's service ID, used to start/stop the > database server service). > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --f4030435abd022a8dc0566fce1d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

I'= ll change the name and send you updated patch.
=
=
<= /div>
On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to add=C2=A0service parameter in se= rver dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have= extracted Connection class and Server manager class from our own custom Ps= ycopg2 driver module.

Patch also covers RM#3120
<= br>
=C2=A0This patch seems a little confused. The "Service&q= uot; and "Service ID" fields from pgAdmin 3 are very different th= ings. The Redmine ticket seems to be asking for the Service field (the pg_s= ervice.conf service name), *not* Service ID (the operating system's ser= vice ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterprise= DB UK: http://www= .enterprisedb.com
The Enterprise PostgreSQL Company

--f4030435abd022a8dc0566fce1d0--