Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3dCE-000267-R2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Apr 2017 06:46:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d3dCD-0002Vt-U3 for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Apr 2017 06:46:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d3dCD-0002Vj-FH for pgadmin-hackers@postgresql.org; Thu, 27 Apr 2017 06:46:33 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d3dC9-0006sh-CS for pgadmin-hackers@postgresql.org; Thu, 27 Apr 2017 06:46:32 +0000 Received: by mail-wm0-x231.google.com with SMTP id m123so8739358wma.0 for ; Wed, 26 Apr 2017 23:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Dc64QCAyARn7peHzn80dNBWh5EFL1ewDCR7/QVjCw5Y=; b=fXSa33q0Y4yBInOer5xYsjNCAQohVNToqsvkQ8DORLw/fOREWGMkpBDU4c7PFhxOc+ jq8RcCU+GNS7EjLsmB5/JZ/pJdnnUiqHwiIPjMV2Q7l8KHWFZQ9+F67ykTTh0Eafag0H 0juSRyV2eDZMch3FsWj7P60tKlSYlQbfT3BpL5QErmJig/xoo7ah2kMEJbb9e0CkF4pR 3q5E+SUDj9gnoMJ3eH45tzDw2Xn9V8AXs9YhQ6mphsBc+A50cwUKc4WGY2gw79894t5D cyT6WmGp2eH2XgGUwymnY2Nh0hXOYQH3nUm2ge+E2pWgLNyLwXbfC8kCahApkuRxlX2s o8RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Dc64QCAyARn7peHzn80dNBWh5EFL1ewDCR7/QVjCw5Y=; b=ZP6zR0VsaqCcwwrBe9F7DfGgK9eJFtrJwNXgQD0hZCXpQmzwtbkAEK5jyDeevFW1M5 QQitRKZ319gj+REfFmoQ7FWfdz+PYbY953cvHYQQfYHaP9bMWpEXFkraAp+n2tXpRgj3 moddUJCwlMQ/6j9T6rRUmIqfYfdokxz7fnfB404+JrFX1eRkD/SZFkvxdHcvFRg1z4Rx uwfIg8GE0PCMdcUUiX/2WThkAlGAvKPorhsAdXaucZlnK7kepSCCIK/uqBp9Z8eaSlkb kd5nFOhqtNAu4527JBIyWQDwgYQpippoPqvaXHsrNu+Nu+KnBOS0AXc2QlLwnn2NXH+z 4/Vw== X-Gm-Message-State: AN3rC/5kABkUUvr+9Cqks5N/x9nEA/OnfrAuFbR3PNRyvKvpJg+cmWl4 eNh8c2/1ahXVIDFYUsLU3DUGsxbXFi8R X-Received: by 10.28.167.3 with SMTP id q3mr994681wme.134.1493275588278; Wed, 26 Apr 2017 23:46:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.136.70 with HTTP; Wed, 26 Apr 2017 23:46:07 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 27 Apr 2017 12:16:07 +0530 Message-ID: Subject: Re: Issue with SlickGrid To: Joao Pedro De Almeida Pereira Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114ba604fde765054e2050e9 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114ba604fde765054e2050e9 Content-Type: text/plain; charset=UTF-8 +++ Reference: https://www.postgresql.org/message-id/CAKKotZRjqbKAZev81Zk78nikDVXqLKEDV5r%2BsW8Me31Gpzrm_A%40mail.gmail.com -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 27, 2017 at 12:09 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hello Joao, > > Yes, We made some changes in SlickGrid library when we integrated it into > Query tool. > > *Issue:* Last row from the query result set was not displaying correctly > in query tool when we have scrollbar in grid. > > The row hight/width pixel size calculations is done inside SlickGrid > javascript code, Though we tried solve it through CSS but we had no luck, > so we had no other choice but to do it in library it self. > > The changes were, > 1) "getDataLengthIncludingAddNew()" function (slick.grid.js) to add two > new rows instead of one when user add values into row (one row is dummy & > not visible to user so that it displays last row correctly) > 2) Other change was done into "appendRowHtml()" function to calculating > the correct number of rows in SlickGrid result as we have added our own > custom row as mentioned earlier. > 3) Abbreviated long CSS classes as mentioed in README file. > > Apologies we missed to update this change in README. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Hackers, >> >> While doing some changes to the Query Results we found out that there was >> a issue with Slick grid. >> >> The issue that we found was with the CellSelectModel, behaved differently >> when pressing Ctrl and Command(Mac). We created a PR >> with the change to changes >> the behavior of the plugin. >> >> When this PR is applied to the SlickGrid library we need to apply it to >> the current version of SlickGrid that we have vendorized. >> According to the libraries.txt file we are in version 2.2.4 of the >> library but a diff between our code and the libraries version 2.2.4 shows >> differences in the code. >> >> Did we do any change to SlickGrid library that is vendorized? Or is just >> the information in libraries.txt that is incorrect? >> Does anyone know any problem if we bump the version of SlickGrid to the >> newer version after the PR is applied? >> >> Thanks >> Joao >> > > --001a114ba604fde765054e2050e9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

--=
Regards,

On Thu, Apr 27, 2017 at 12:09 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hello Joao,
Yes, We made some changes in SlickGrid library when we inte= grated it into Query tool.

Issue: Last row = from the query result set was not displaying correctly in query tool when w= e have scrollbar in grid.

The row hight/w= idth pixel size calculations is done inside SlickGrid javascript code, Thou= gh we tried solve it through CSS but we had no luck, so we had no other cho= ice but to do it in library it self.
=C2=A0=C2=A0
=
The changes were,
1) "getDataLengthIncludingAddNew()" function (slick.grid.js) to add two new rows instead of one when u= ser add values into row (one row is dummy & not visible to user so that= it displays last row correctly)
2) Other change was done into &q= uot;appendRowHtml()" function to calculating the correct number of row= s in SlickGrid result as we have added our own custom row as mentioned earl= ier.
3) Abbreviated long CSS classes as mentioed in README file.<= /div>
=C2=A0
Apologies we missed to update this change i= n README.


--Regards,

On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro = De Almeida Pereira <jdealmeidapereira@pivotal.io>= wrote:
Hello Hackers,
While doing some changes to the Query Results we found ou= t that there was a issue with Slick grid.=C2=A0

Th= e issue that we found was with the CellSelectModel, behaved differently whe= n pressing Ctrl and Command(Mac). We created a PR with the change to chan= ges the behavior of the plugin.

When this PR is ap= plied to the SlickGrid library we need to apply it to the current version o= f SlickGrid that we have vendorized.
According to the libraries.t= xt file we are in version 2.2.4 of the library but a diff between our code = and the libraries version 2.2.4 shows differences in the code.
Did we do any change to SlickGrid library that is vendorized? = Or is just the information in libraries.txt that is incorrect?
Do= es anyone know any problem if we bump the version of SlickGrid to the newer= version after the PR is applied?

Thanks
Joao


--001a114ba604fde765054e2050e9--