Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erGb7-0001XZ-H0 for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 05:17:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erGb6-00081x-Bs for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 05:17:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erGXq-0004Qo-1o for pgadmin-hackers@lists.postgresql.org; Thu, 01 Mar 2018 05:14:18 +0000 Received: from mail-ot0-x231.google.com ([2607:f8b0:4003:c0f::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erGXl-000552-Or for pgadmin-hackers@postgresql.org; Thu, 01 Mar 2018 05:14:16 +0000 Received: by mail-ot0-x231.google.com with SMTP id f11so4481257otj.12 for ; Wed, 28 Feb 2018 21:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oOY+3aEC5dNEpSpnlz26WNwUJAW0aTmkHav21LFz+Cg=; b=T30jm37/lRHDgqvRy6vsDezd+cSSXr5+ZPg777NX+nClQU6oS5Tc6TQHTSFKbK/HBl 8q+JCvlkHyOOdZ9HaL0Os+omo9+qD560aP7cTSHTunBtYCYTPBsoMWX+/JeZl70+rxcg 6Bq1qTjJZptHWdfmWJmGEYZUR7N6q75Xvim2OuBfNwf2g7HBxbaHZNT0T0n8qVxrPS0f nbHoQWTXxZJZcUJS6fpU0CWJjOO4I719ROqJuItkqZ9koPiYXQKp3EajGTUPRLd8kp+N W6Ezhsyt+lPzirMx+l0w3qoJzBuoGilGTwo4Eno+B2w2HOGyVNWgtmf5OkPV91f4ZDuX gXcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oOY+3aEC5dNEpSpnlz26WNwUJAW0aTmkHav21LFz+Cg=; b=q/Y4EMEQwvI964cznqkCxEXduRcbNxF+VWIclsHXYcKNKjPJEavpK2nHZAewXFVQau /X7er04PbIOMDnZyc7W88MNSS6YCl6nVumqhzvHcMlkUVT14tlNOKHw0Y494N/GEudAO EAwr+S+3ShusisfBzx2esFNNqhjsgTqobJqbbyuZoVzkpkHybCiKWPnIJXtpOOtAxCFD HWDwFcz6ua3i1WJKYe9zQoxIV7sdeFSXzIJbcQ+G6pvWNww/u4ZN7PuP4wmdyINZp/Jp yE9O8uCUSfli20K71O/uSP2mLnXeDNxky5dVdWly8YiM+RoY5ZUIaca9t9qURkih8KT+ 5kMQ== X-Gm-Message-State: APf1xPA92VVEqHveVF4Cpxhb1IujVQgVMWRDqaStEYOunL3d6cI6OG+q 8oCC2akyl5ZYnI61vbjNrhs7528bgS8vDahIz2Sn3g== X-Google-Smtp-Source: AG47ELuu2pG3QbQ5sIsCYPZG5urqfoL4Ww1BgDNgmKg/FRP1kSo6OHuCw5pOHbSjnVjQOdxcA69wKJaCGzhFNOb88y0= X-Received: by 10.157.22.233 with SMTP id s38mr396201ots.97.1519881251493; Wed, 28 Feb 2018 21:14:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Wed, 28 Feb 2018 21:13:51 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 1 Mar 2018 10:43:51 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3161] Fix PEP-8 issues To: Joao De Almeida Pereira Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114790ea18ad66056652ee27" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114790ea18ad66056652ee27 Content-Type: text/plain; charset="UTF-8" Thank you Joao for reviewing. On Thu, Mar 1, 2018 at 3:10 AM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello Murtuza, > > I passed the patch through our CI and all test are green. Also run the > codestyle in all those folders and everything is clean. > > 575 issues to go > > Thanks > Joao > > On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions and >> Languages module. >> >> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ >> servers/databases/languages/ >> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ >> servers/databases/extensions/ >> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ >> servers/databases/event_triggers/ >> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ >> servers/databases/casts/ >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> --001a114790ea18ad66056652ee27 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you Joao for reviewing.

On Thu, Mar 1, 2018 at 3:10 AM, Joao De Alme= ida Pereira <jdealmeidapereira@pivotal.io> wrote:=
Hello Murtuza,

=
I passed the patch through our CI and all test are green. Also r= un the codestyle in all those folders and everything is clean.
575 issues to go

Thanks
Joa= o

On Wed, Feb 28= , 2018 at 1:05 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.co= m> wrote:
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">Hi,
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">
=
PFA patch= to fix the PEP8 issues in=C2=A0Casts, Event triggers, Extensions and Langu= ages module.

pycodestyle --config=3D.pycod= estyle pgadmin/browser/server_groups/servers/databases/languages/
pycodestyle --config=3D.pycodestyle pgad= min/browser/server_groups/servers/databases/extensions/
pycodestyle --config=3D.pycodestyle pgadmin/browse= r/server_groups/servers/databases/event_triggers/
pycodestyle --config=3D.pycodestyle pgadmin/b= rowser/server_groups/servers/databases/casts/

=
--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.<= wbr>enterprisedb.com
The Enterprise PostgreSQL Company=

<= /div>

--001a114790ea18ad66056652ee27--