Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMVQf-00035y-FP for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 07:14:57 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bMVQf-00039V-2M for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 07:14:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bMVQS-0002uq-4n for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 07:14:44 +0000 Received: from mail-qt0-x231.google.com ([2607:f8b0:400d:c0d::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bMVQP-0004fm-3S for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 07:14:42 +0000 Received: by mail-qt0-x231.google.com with SMTP id w38so9900918qtb.0 for ; Mon, 11 Jul 2016 00:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=PWQyBFLKty40radcDHJwB2PtnebtfV6ayEc0r9og6Jo=; b=dioYYeVhBM09xwKfkQhNih6Wm7YdvYPvFNfW0ygYGx8PlMwckSzh1V0v5JpIJuyWeH 3ZGKdBJdtW5rzWEu1ht8pqsPgpVLF9lvmpU1VGNy7nRWxvQPDblxKPQJwS9XIJFJZbzn 7VYVd8j6iZil1QZzi8fJQKwn0RMr+4fMsVznjAOlWZpeDuDDigCHv/iWjKuOTuiNzv9H fRcfA33mxe5yGKzjOTnnI5vWqlu0uT9WAy+lANHqlm9lxUtou+s2WeLTQinjcn7cbveP fI34WSn4TvdsodLRNgq5LoHsx3NB4LgADjYdqVoG4ac8hHXSyfulvHuAaEb4q43saSug txIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=PWQyBFLKty40radcDHJwB2PtnebtfV6ayEc0r9og6Jo=; b=BTPm+sHhbDc6HBqlxYCo74rhbKOAqIDiJlBg39+RVw8FcErZxhrxFp/Op6jd9Z7Z3z Ho9wrSXZNTNJt96PoAazfW3lFEE+6LTtsYINla3LUU+M28ot09v/HFklPLCJsnvGlRwG iJI/yiMzdWxVEeEZBCSkdsBRbIL0mXd9Q5iYLce1swZyQq1u+RMy6FMDqD319k1ELMxY JrqZZDOcyy22ErHlKWISRepAks5ev0svCF+7e2V/wjf83xN7bNAImaFJvQPue0xtzLuG kL1ndP8hYHVUffytDIN64Jv1SQHwdnVs4eBw9T26ZHZPsIvU+D6H/KCdQcFZZ/uUDwpM Vt0A== X-Gm-Message-State: ALyK8tIIgQEW8kmZILrXuUD1JTfBGqIieOAEvaly5upI10phrjT8pkiYxYCvf9X2opV1CH9tn3J8VgC24sVREZGE X-Received: by 10.200.47.92 with SMTP id k28mr6215399qta.50.1468221280146; Mon, 11 Jul 2016 00:14:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.8.3 with HTTP; Mon, 11 Jul 2016 00:14:20 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 11 Jul 2016 12:44:20 +0530 Message-ID: Subject: Re: PATCH: To fix salt generation in session.py To: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11356d62daf7df053756e747 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11356d62daf7df053756e747 Content-Type: text/plain; charset=UTF-8 Hi, Please hold on in this patch, Need additional changes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > With latest pull session.py fails with below error with python3 because in > python3 strings 'lowercase' method has been renamed to 'ascii_lowercase', > PFA patch to fix the issue. > > Issue: > ---------- > * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign* > * self.randval = ''.join(random.sample(string.lowercase+string.digits, > 20))* > *AttributeError: module 'string' has no attribute 'lowercase'* > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11356d62daf7df053756e747 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Please hold on in this patch, Need = additional changes.

--
Regards,
= Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny

On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

With latest pull session.py fails with below error with python3 bec= ause in python3 strings 'lowercase' method has been renamed to '= ;ascii_lowercase', PFA patch to fix the issue.

Issue:
----------
=C2=A0 File "../pgadmin= 4/web/pgadmin/utils/session.py", line 59, in sign
=C2= =A0 =C2=A0 self.randval =3D ''.join(random.sample(string.lowercase+= string.digits, 20))
AttributeError: module 'string'= ; has no attribute 'lowercase'


-= -
Regards,
Murtuza Zabuawala<= br style=3D"color:rgb(136,136,136)">= EnterpriseDB:=C2=A0http://www.ente= rprisedb.com
The Enterprise PostgreSQL Company

--001a11356d62daf7df053756e747--